From becfbbf2b0b964bf2ff989236ece0d51c646c477 Mon Sep 17 00:00:00 2001 From: Shenghang Tsai Date: Sun, 15 Nov 2020 13:39:54 +0800 Subject: [PATCH 01/10] add --- .github/workflows/pull_img.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pull_img.yml b/.github/workflows/pull_img.yml index 4efff61..2d77947 100644 --- a/.github/workflows/pull_img.yml +++ b/.github/workflows/pull_img.yml @@ -22,6 +22,7 @@ on: required: false jobs: downloadDockerImg: + if: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'need_ci') }} runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 From 8b5976b7e35b03cd6bfb7d0f8106464b8c52f512 Mon Sep 17 00:00:00 2001 From: Shenghang Tsai Date: Sun, 15 Nov 2020 15:53:08 +0800 Subject: [PATCH 02/10] requested_reviewer --- .github/workflows/pull_img.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_img.yml b/.github/workflows/pull_img.yml index 2d77947..2a25086 100644 --- a/.github/workflows/pull_img.yml +++ b/.github/workflows/pull_img.yml @@ -22,7 +22,7 @@ on: required: false jobs: downloadDockerImg: - if: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'need_ci') }} + if: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.requested_reviewer.*.name, 'oneflow-bot') }} runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 From ba3934947622e6f02514e959a513a5b6f3875514 Mon Sep 17 00:00:00 2001 From: Shenghang Tsai Date: Sun, 15 Nov 2020 15:55:13 +0800 Subject: [PATCH 03/10] types: [review_requested] --- .github/workflows/pull_img.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_img.yml b/.github/workflows/pull_img.yml index 2a25086..2e6bba9 100644 --- a/.github/workflows/pull_img.yml +++ b/.github/workflows/pull_img.yml @@ -5,7 +5,7 @@ on: branches: - master pull_request: - types: [synchronize, opened, reopened, ready_for_review] + types: [review_requested] branches: - '*' workflow_dispatch: From e5539b85731cbe4264210b9882bbb5b17328d666 Mon Sep 17 00:00:00 2001 From: Shenghang Tsai Date: Sun, 15 Nov 2020 15:57:22 +0800 Subject: [PATCH 04/10] fix --- .github/workflows/pull_img.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_img.yml b/.github/workflows/pull_img.yml index 2e6bba9..0097145 100644 --- a/.github/workflows/pull_img.yml +++ b/.github/workflows/pull_img.yml @@ -22,7 +22,7 @@ on: required: false jobs: downloadDockerImg: - if: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.requested_reviewer.*.name, 'oneflow-bot') }} + if: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.requested_reviewers.*.name, 'oneflow-bot') }} runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 From dfdebcea347ac018c9072c4ba2014a6398f42c3e Mon Sep 17 00:00:00 2001 From: Shenghang Tsai Date: Sun, 15 Nov 2020 16:01:02 +0800 Subject: [PATCH 05/10] add --- .github/workflows/pull_img.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_img.yml b/.github/workflows/pull_img.yml index 0097145..9b50f02 100644 --- a/.github/workflows/pull_img.yml +++ b/.github/workflows/pull_img.yml @@ -22,7 +22,7 @@ on: required: false jobs: downloadDockerImg: - if: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.requested_reviewers.*.name, 'oneflow-bot') }} + if: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.requested_reviewers, 'oneflow-bot') }} runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 From 6b9fe79aa3eb905ff98874bdcd254601853cbc30 Mon Sep 17 00:00:00 2001 From: Shenghang Tsai Date: Sun, 15 Nov 2020 16:04:23 +0800 Subject: [PATCH 06/10] fix --- .github/workflows/pull_img.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pull_img.yml b/.github/workflows/pull_img.yml index 9b50f02..506ae87 100644 --- a/.github/workflows/pull_img.yml +++ b/.github/workflows/pull_img.yml @@ -22,7 +22,7 @@ on: required: false jobs: downloadDockerImg: - if: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.requested_reviewers, 'oneflow-bot') }} + if: ${{ github.event_name == 'pull_request' runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -33,6 +33,7 @@ jobs: OSS_ACCESS_KEY_ID: ${{ secrets.OSS_ACCESS_KEY_ID }} OSS_ACCESS_KEY_SECRET: ${{ secrets.OSS_ACCESS_KEY_SECRET }} run: | + echo '${{ toJson(github.event.pull_request.requested_reviewers) }}' IMG_NAME=${IMG_NAME:-"busybox"} COMPRESS=${COMPRESS:-"1"} OSSPATH=${OSSPATH:-"oss://oneflow-static/img"} From ff3c21e4dd836d9f4240c35d0a0929dde03b09df Mon Sep 17 00:00:00 2001 From: Shenghang Tsai Date: Sun, 15 Nov 2020 16:05:59 +0800 Subject: [PATCH 07/10] add --- .github/workflows/pull_img.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pull_img.yml b/.github/workflows/pull_img.yml index 506ae87..71c8628 100644 --- a/.github/workflows/pull_img.yml +++ b/.github/workflows/pull_img.yml @@ -32,8 +32,9 @@ jobs: OSSPATH: ${{ github.event.inputs.ossPath }} OSS_ACCESS_KEY_ID: ${{ secrets.OSS_ACCESS_KEY_ID }} OSS_ACCESS_KEY_SECRET: ${{ secrets.OSS_ACCESS_KEY_SECRET }} + requested_reviewers: ${{ toJson(github.event.pull_request.requested_reviewers) }} run: | - echo '${{ toJson(github.event.pull_request.requested_reviewers) }}' + echo ${requested_reviewers} IMG_NAME=${IMG_NAME:-"busybox"} COMPRESS=${COMPRESS:-"1"} OSSPATH=${OSSPATH:-"oss://oneflow-static/img"} From 3634035ade68a870e59a6e59d4e50d61f7e11bcf Mon Sep 17 00:00:00 2001 From: Shenghang Tsai Date: Sun, 15 Nov 2020 16:07:00 +0800 Subject: [PATCH 08/10] fix --- .github/workflows/pull_img.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_img.yml b/.github/workflows/pull_img.yml index 71c8628..8ce8f4c 100644 --- a/.github/workflows/pull_img.yml +++ b/.github/workflows/pull_img.yml @@ -22,7 +22,7 @@ on: required: false jobs: downloadDockerImg: - if: ${{ github.event_name == 'pull_request' + if: ${{ github.event_name == 'pull_request' }} runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 From a5fe6a7f9e4e1a20be0af635e1ffe9425b68a8af Mon Sep 17 00:00:00 2001 From: Shenghang Tsai Date: Sun, 15 Nov 2020 16:09:25 +0800 Subject: [PATCH 09/10] fix --- .github/workflows/pull_img.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_img.yml b/.github/workflows/pull_img.yml index 8ce8f4c..3f7ff11 100644 --- a/.github/workflows/pull_img.yml +++ b/.github/workflows/pull_img.yml @@ -22,7 +22,7 @@ on: required: false jobs: downloadDockerImg: - if: ${{ github.event_name == 'pull_request' }} + if: ${{ github.event_name == 'pull_request' }} && contains(github.event.pull_request.requested_reviewers.*.login, 'oneflow-bot') runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 From 217dd0cc411450a4c2bc36ffe14ce9164b6e5cac Mon Sep 17 00:00:00 2001 From: Shenghang Tsai Date: Sun, 15 Nov 2020 16:43:37 +0800 Subject: [PATCH 10/10] add --- .github/workflows/pull_img.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_img.yml b/.github/workflows/pull_img.yml index 3f7ff11..aaa59e9 100644 --- a/.github/workflows/pull_img.yml +++ b/.github/workflows/pull_img.yml @@ -22,7 +22,7 @@ on: required: false jobs: downloadDockerImg: - if: ${{ github.event_name == 'pull_request' }} && contains(github.event.pull_request.requested_reviewers.*.login, 'oneflow-bot') + if: ${{ github.event_name == 'pull_request' }} && contains(github.event.pull_request.requested_reviewers.*.login, 'oneflow-ci-bot') runs-on: ubuntu-latest steps: - uses: actions/checkout@v2