Skip to content

Commit 576cfac

Browse files
author
Adam Schlesinger
committed
Copy Android res folder directly instead of contained with branded folder
Having "res" within other folders no longer appears to function as intended
1 parent a840aa4 commit 576cfac

File tree

50 files changed

+15
-86
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+15
-86
lines changed

OneSignalExample/Assets/Plugins/Android/OneSignalConfig.meta

Lines changed: 0 additions & 8 deletions
This file was deleted.

OneSignalExample/Assets/Plugins/Android/OneSignalConfig.plugin.meta

Lines changed: 0 additions & 33 deletions
This file was deleted.

OneSignalExample/Assets/Plugins/Android/OneSignalConfig/README.txt

Lines changed: 0 additions & 6 deletions
This file was deleted.

OneSignalExample/Assets/Plugins/Android/OneSignalConfig/README.txt.meta

Lines changed: 0 additions & 7 deletions
This file was deleted.

com.onesignal.unity.android/Editor/OneSignalConfig/README.txt

Lines changed: 0 additions & 6 deletions
This file was deleted.

com.onesignal.unity.android/Editor/OneSignalConfig/README.txt.meta

Lines changed: 0 additions & 8 deletions
This file was deleted.

com.onesignal.unity.android/Editor/SetupSteps/ExportAndroidResourcesStep.cs

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -32,41 +32,40 @@
3232

3333
namespace OneSignalSDK {
3434
/// <summary>
35-
/// Copies the OneSignalConfig.plugin to Assets/Plugins/Android/*
35+
/// Copies the OneSignal SDK default Android resources to Assets/Plugins/Android/*
3636
/// </summary>
3737
public sealed class ExportAndroidResourcesStep : OneSignalSetupStep {
3838
public override string Summary
39-
=> "Copy Android plugin to Assets";
39+
=> "Copy Android resources to Assets";
4040

4141
public override string Details
42-
=> $"Will create a plugin directory of {_pluginExportPath} filled with files necessary for the OneSignal SDK " +
43-
"to operate on Android.";
42+
=> $"Will export necessary files (such as default notification icons) to {_androidPluginPath}";
4443

4544
public override bool IsRequired
46-
=> true;
45+
=> false;
4746

4847
protected override bool _getIsStepCompleted() {
49-
if (!Directory.Exists(_pluginExportPath))
48+
if (!Directory.Exists(_androidPluginPath))
5049
return false;
5150

52-
var packagePaths = Directory.GetFiles(_pluginPackagePath, "*", SearchOption.AllDirectories)
53-
.Select(path => path.Remove(0, path.LastIndexOf(_pluginName, StringComparison.InvariantCulture)));
51+
var packagePaths = Directory.GetFiles(_exportsPath, "*", SearchOption.AllDirectories)
52+
.Select(path => path.Remove(0, _exportsPath.Length + 1));
5453

55-
var exportPaths = Directory.GetFiles(_pluginExportPath, "*", SearchOption.AllDirectories)
56-
.Select(path => path.Remove(0, path.LastIndexOf(_pluginName, StringComparison.InvariantCulture)));
54+
var exportPaths = Directory.GetFiles(_androidPluginPath, "*", SearchOption.AllDirectories)
55+
.Select(path => path.Remove(0, _androidPluginPath.Length + 1));
5756

5857
var fileDiff = packagePaths.Except(exportPaths);
5958

6059
return !fileDiff.Any();
6160
}
6261

6362
protected override void _runStep() {
64-
var files = Directory.GetFiles(_pluginPackagePath, "*", SearchOption.AllDirectories);
63+
var files = Directory.GetFiles(_exportsPath, "*", SearchOption.AllDirectories);
6564
var filteredFiles = files.Where(file => !file.EndsWith(".meta"));
6665

6766
foreach (var file in filteredFiles) {
68-
var trimmedPath = file.Remove(0, _pluginPackagePath.Length + 1);
69-
var fileExportPath = Path.Combine(_pluginExportPath, trimmedPath);
67+
var trimmedPath = file.Remove(0, _exportsPath.Length + 1);
68+
var fileExportPath = Path.Combine(_androidPluginPath, trimmedPath);
7069
var containingPath = fileExportPath.Remove(fileExportPath.LastIndexOf(Path.DirectorySeparatorChar));
7170

7271
/*
@@ -85,10 +84,8 @@ protected override void _runStep() {
8584
AssetDatabase.Refresh();
8685
}
8786

88-
private const string _pluginName = "OneSignalConfig";
89-
private static readonly string _packagePath = Path.Combine("Packages", "com.onesignal.unity.android", "Editor");
90-
private static readonly string _androidPluginsPath = Path.Combine("Assets", "Plugins", "Android");
91-
private static readonly string _pluginPackagePath = Path.Combine(_packagePath, _pluginName);
92-
private static readonly string _pluginExportPath = Path.Combine(_androidPluginsPath, _pluginName);
87+
88+
private static readonly string _exportsPath = Path.Combine("Packages", "com.onesignal.unity.android", "Editor", "Exports");
89+
private static readonly string _androidPluginPath = Path.Combine("Assets", "Plugins", "Android");
9390
}
9491
}

0 commit comments

Comments
 (0)