Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: PermissionsActivity does not follow app theme #2203

Open
1 task done
michael-winkler opened this issue Oct 10, 2024 · 0 comments
Open
1 task done

[Bug]: PermissionsActivity does not follow app theme #2203

michael-winkler opened this issue Oct 10, 2024 · 0 comments

Comments

@michael-winkler
Copy link

What happened?

If we request any permission with the default android implementation the dialog looks like this:
image

Statusbar and navigationbar is here transparent.

If we request the notification permission with the OneSignal implementation the dialog looks like this:
image

Why the difference? Can this please be improved?
The lines of the OneSignal Activity are here:

<activity android:name="com.onesignal.core.activities.PermissionsActivity"
                  android:theme="@android:style/Theme.Translucent.NoTitleBar"
                  android:exported="false" />

image

Steps to reproduce?

Just use the OneSignal code "OneSignal.Notifications.requestPermission(false)"

What did you expect to happen?

A better style for the theme like the default android permission dialogs!

OneSignal Android SDK version

5.1.23

Android version

14

Specific Android models

All

Relevant log output

-

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants