Skip to content

Commit 7f922df

Browse files
arashsheydaantfu
andauthored
fix(terminals): badge number (nuxt#279)
Co-authored-by: Anthony Fu <[email protected]>
1 parent 980ad3c commit 7f922df

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

packages/devtools-kit/src/_types/custom-tabs.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ export interface ModuleBuiltinTab {
121121
path?: string
122122
category?: TabCategory
123123
show?: () => MaybeRefOrGetter<any>
124-
badge?: () => number | string | undefined
124+
badge?: () => MaybeRefOrGetter<number | string | undefined>
125125
onClick?: () => void
126126
}
127127

packages/devtools/client/components/SideNavItem.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const isActive = computed(() => route.path.startsWith(tabPath.value))
3131
v-if="badge" absolute bottom-0 right-0 h-4 w-4 rounded-full text-9px text-white flex="~ items-center justify-center"
3232
:class="isActive ? 'bg-primary' : 'bg-gray'"
3333
>
34-
<span translate-y-0.5px>{{ badge }}</span>
34+
<span translate-y-0.5px>{{ toValue(badge) }}</span>
3535
</div>
3636
</NuxtLink>
3737
<template #popper>

packages/devtools/client/meta.d.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { TabCategory } from "../src/types"
1+
import { MaybeRefOrGetter } from 'vue'
2+
import { TabCategory } from '../src/types'
23

34
declare module '#app' {
45
interface PageMeta {
@@ -7,7 +8,7 @@ declare module '#app' {
78
order?: number
89
category?: TabCategory
910
show?: () => any
10-
badge?: () => string | number | undefined
11+
badge?: () => MaybeRefOrGetter<string | number | undefined>
1112
}
1213
}
1314

packages/devtools/client/pages/modules/terminals.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@ definePageMeta({
1616

1717
<template>
1818
<AuthRequiredPanel>
19-
<TerminalsPage />
19+
<TerminalPage />
2020
</AuthRequiredPanel>
2121
</template>

0 commit comments

Comments
 (0)