From f09347de58ced0a403ebc746f8f73a61845848db Mon Sep 17 00:00:00 2001 From: dewanshparashar Date: Mon, 10 Mar 2025 20:06:15 +0530 Subject: [PATCH] dev: comments --- .../src/components/TransactionHistory/helpers.ts | 2 +- packages/arb-token-bridge-ui/src/state/app/state.ts | 2 ++ packages/arb-token-bridge-ui/src/state/app/utils.ts | 5 ++++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/arb-token-bridge-ui/src/components/TransactionHistory/helpers.ts b/packages/arb-token-bridge-ui/src/components/TransactionHistory/helpers.ts index ce795b4526..c47a46e54b 100644 --- a/packages/arb-token-bridge-ui/src/components/TransactionHistory/helpers.ts +++ b/packages/arb-token-bridge-ui/src/components/TransactionHistory/helpers.ts @@ -528,7 +528,7 @@ export async function getUpdatedTeleportTransfer( ...tx, status, timestampResolved, - l1ToL2MsgData, + l1ToL2MsgData, // note: in contrast to general deposits which use `parentToChildMsgData`, Teleport transfers still follow L1/L2/L3 terminology, so we have `l1ToL2MsgData` and `l2ToL3MsgData` l2ToL3MsgData } diff --git a/packages/arb-token-bridge-ui/src/state/app/state.ts b/packages/arb-token-bridge-ui/src/state/app/state.ts index 4488f5b321..8b45aa30b0 100644 --- a/packages/arb-token-bridge-ui/src/state/app/state.ts +++ b/packages/arb-token-bridge-ui/src/state/app/state.ts @@ -69,6 +69,8 @@ export interface MergedTransaction { } export interface TeleporterMergedTransaction extends MergedTransaction { + // note: in contrast to general deposits which use `parentToChildMsgData`, + // Teleport transfers still follow L1/L2/L3 terminology, so we have `l1ToL2MsgData` and `l2ToL3MsgData` l1ToL2MsgData?: ParentToChildMessageData l2ToL3MsgData: L2ToL3MessageData } diff --git a/packages/arb-token-bridge-ui/src/state/app/utils.ts b/packages/arb-token-bridge-ui/src/state/app/utils.ts index 60ca2b2603..603c1b9cf9 100644 --- a/packages/arb-token-bridge-ui/src/state/app/utils.ts +++ b/packages/arb-token-bridge-ui/src/state/app/utils.ts @@ -63,7 +63,10 @@ export const getDepositStatus = ( } if (isTeleportTx(tx)) { - const { l2ToL3MsgData, l1ToL2MsgData } = tx + // note: in contrast to general deposits which use `parentToChildMsgData` + // teleport transfers still follow L1/L2/L3 terminology, so we have `l1ToL2MsgData` and `l2ToL3MsgData` + + const { l1ToL2MsgData, l2ToL3MsgData } = tx // if any of the retryable info is missing, first fetch might be pending if (!l1ToL2MsgData || !l2ToL3MsgData) return DepositStatus.L2_PENDING