diff --git a/src/remediation/fix-commands.ts b/src/remediation/fix-commands.ts index cca4ce31..5998965b 100644 --- a/src/remediation/fix-commands.ts +++ b/src/remediation/fix-commands.ts @@ -247,7 +247,7 @@ export function buildSuggestedFixCommandPlan( upsertTarget(targetsByPackage, { package: finding.recommendedNpmTransitiveRemediation.package, currentVersion: finding.recommendedNpmTransitiveRemediation.currentVersion, - targetVersion: finding.recommendedNpmTransitiveRemediation.targetChildVersion, + targetVersion: finding.recommendedNpmTransitiveRemediation.currentVersion, scannedVersions: null, knownVulnerableVersions: null, kind: "parent-update", @@ -561,7 +561,7 @@ export function findFixTargetForFinding( if (finding.recommendedNpmTransitiveRemediation?.kind === "update-parent-within-range") { return ( item.kind === "parent-update" && - item.targetVersion === finding.recommendedNpmTransitiveRemediation.targetChildVersion && + (item.targetVersion === finding.recommendedNpmTransitiveRemediation.currentVersion || item.targetVersion === finding.recommendedNpmTransitiveRemediation.targetChildVersion) && (item.package === finding.recommendedNpmTransitiveRemediation.package || item.package === finding.pkg.name) ); } diff --git a/tests/output.test.ts b/tests/output.test.ts index 83cee9b5..db56f957 100644 --- a/tests/output.test.ts +++ b/tests/output.test.ts @@ -597,7 +597,7 @@ describe("output formatters", () => { expect.objectContaining({ package: "mocha", currentVersion: "10.0.0", - targetVersion: "5.1.0", + targetVersion: "10.0.0", kind: "parent-update", }), ],