Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_compose.yml doesn't set MONGODB_URI #213

Closed
rcowsill opened this issue Sep 20, 2020 · 1 comment
Closed

docker_compose.yml doesn't set MONGODB_URI #213

rcowsill opened this issue Sep 20, 2020 · 1 comment

Comments

@rcowsill
Copy link
Contributor

When deployed through docker-compose the default configuration makes the web service connect to mongodb://ds159217.mlab.com:59217/nodegoat. The deploy instructions for docker include a step to point the web service at the mongo service, but it's easy to forget that.

Also, as mentioned here, the CI configuration has been changed in branch feature/187 to use docker. The default database setting is used, so all three jobs in the build simultaneously connect to the mLab database and interfere with each other. Currently only one job can succeed at a time, and none will succeed after the mLab database gets shut down (see #212).

I think the MONGODB_URI should be set to mongodb://mongo:27017/nodegoat in the docker-compose.yml. That way the web service will always connect to the correct mongo instance when deployed through docker-compose.

@rcowsill
Copy link
Contributor Author

Resolved by #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant