Skip to content

Expose delay fitting options in CLI config classes #130

@ltorres6

Description

@ltorres6

Problem

Delay fitting is implemented in the library layer but not exposed through the CLI configuration system:

  • DCE: fit_model() in osipy/dce/fitting.py accepts fit_delay (bool) and uses _DelayAwareModel with default bounds (0.0, 60.0), but DCEFittingConfig has no corresponding fields.
  • DSC: Delay maps are computed and exported (osipy/dsc/parameters/maps.py), but there is no config to control delay-related behavior.

Users cannot enable or configure delay fitting through YAML config files or the CLI.

Proposal

Add the missing delay-related fields to the Pydantic config classes:

  • DCEFittingConfig: add fit_delay: bool = False and delay_bounds: tuple[float, float] = (0.0, 60.0)
  • Wire these fields through the runner (osipy/cli/runner.py) so they are passed to fit_model()
  • Add equivalent fields to DSC config if applicable

Affected code

  • osipy/cli/config.pyDCEFittingConfig, DSCPipelineYAML
  • osipy/cli/runner.py — where config values are passed to fitting functions

🤖 Generated with Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions