Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release, Docs] - Findings, docs grammar and comments #1300

Open
JoshuaSBrown opened this issue Feb 10, 2025 · 0 comments
Open

[Release, Docs] - Findings, docs grammar and comments #1300

JoshuaSBrown opened this issue Feb 10, 2025 · 0 comments

Comments

@JoshuaSBrown
Copy link
Collaborator

JoshuaSBrown commented Feb 10, 2025

Description

List of grammar and comments, that need to be fixed.

  1. Pull request template .github/pull_request_template.md
A reviwer has been added
  1. Comment in CI job has misspelled script name
stage_build_base.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
stage_build_base.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/force_build_gcs_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/force_build_gcs_base_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/build_gcs_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/build_gcs_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/build_core_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/build_core_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/force_build_foxx_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/build_foxx_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/build_foxx_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/force_build_core_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/force_build_ws_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/build_repo_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/build_repo_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/force_build_repo_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/build_ws_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/build_ws_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/build_gcs_base_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
build/build_gcs_base_image.yml:    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count

Acceptance

Fixes spelling grammar and comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant