opendap/hyrax_ncwms:1.16.2 wms broken

[gajowi]

Previously wms and godiva3 worked for/with /opendap/data/nc/coads_climatology.nc.html

• such as at our production service:
  https://data-cbr.csiro.au/ncWMS2/Godiva3.html?server=https://data-cbr.csiro.au/ncWMS2/wms/lds/testdata/nc/coads_climatology.nc (also fine without tls...).

With 1.16.2 I think the related wms GetCapabilities response is OK but when getting data there is an error. 400 Bad Request

Could not read underlying data

(for url /ncWMS2/wms/lds/data/nc/coads_climatology.nc?FORMAT=image%2Fpng&TRANSPARENT=TRUE&STYLES=default-scalar%2Fdefault&LAYERS=lds%2Fdata%2Fnc%2Fcoads_climatology.nc%2FSST&TIME=0000-12-16T01%3A20%3A06.000Z&COLORSCALERANGE=%2C&NUMCOLORBANDS=250&ABOVEMAXCOLOR=extend&BELOWMINCOLOR=extend&BGCOLOR=extend&LOGSCALE=false&SERVICE=WMS&VERSION=1.1.1&REQUEST=GetMap&SRS=EPSG%3A4326&BBOX=-57.12,32.88,65.76,155.76&WIDTH=256&HEIGHT=256)

I haven't fully understood the associated godiva3 set of requests. The ones that return empty tiles seem to be OK. The error only happens for tiles with data.

Can you see the problem?

regards, Gareth

[ndp-opendap]

I think issue lies in the netcdf-java library used by NcWMS 4.2.2. That (older) library fails to properly URL encode the constraint expressions sent to the DAP service. Uncoded URLs that contain characters that should be encoded (like "[" and "]") have been rejected by Tomcat since roughly June 2018 (Tomcat-8.0.53). Certainly the version of Tomcat in the "latest" docker container will reject them, returning only an HTTP status of 400 and no response body.

See this issue for more: #29

The NcWMS-2.2.2 bundle contains WEB-INF/lib/netcdf4-5.0.0-20160523.203326-5.jar which is definitely older than the patch for this issue.

I think I need to reach out to our friends at NcWMS and see if they have a newer version with an updated netcdf-java library.

Sincerely,

Nathan

[gajowi]

Thanks Nathan. It had crossed my mind that might be related. FWIW with TDS I've been working around this with relaxedQueryChars as documented in https://tomcat.apache.org/tomcat-8.5-doc/config/http.html (and more specifically described in many posts/questions/answers). I can probably moderate the issue by crafting a custom server.xml for tomcat until the upstream problem can be solved - or I keep holding off on upgrading hyrax.

If I try tweaking tomcat, I'll first try:
relaxedQueryChars="[:]"

Gareth

BTW. Our data providers and users place high value on WMS (via ncWMS) and also godiva3, particularly to get a quick overview of data. I'm considering running ncWMS2 in a separate container and figuring out how to integrate that service in to hyrax. I see there is a container referenced in ncWMS2 docs: https://reading-escience-centre.gitbooks.io/ncwms-user-guide/content/02-installation.html#docker

[ndp-opendap]

Hi Gareth,
I have been trying to avoid delivering containers with relaxedQueryChars because, well, we should fix the clients. I am wondering if the updated netcdf-java.jar file could just be injected into the docker image using a volume.

I reached out to the ncWMS folks and maybe they'll supply a new WAR file with an update netcdf-java...

I'm considering running ncWMS2 in a separate container and figuring out how to integrate that service in to hyrax.

This section of our documentation: https://opendap.github.io/hyrax_guide/Master_Hyrax_Guide.html#WMS_Service
describes what to do, except for the docker container business.

[ndp-opendap]

Hi Gareth,

I heard back from Guy Griffiths - looks like we need to update the ncWMS distribution in the server. I need to get together with my team to decide how to proceed, but I suspect it means a new numbered release, as:

• A new ncWMS deployment is a big change and needs configuration and integration testing.
• We have a fair bit of new code in the Hyrax project so a 1.16.3 release probably makes sense at this point.

What is your level of urgency? (I suspect fairly high based on your comments about how popular this featured is)

Sincerely,

Nathan

[gajowi]

Thanks Nathan. Sounds good. My level of urgency is low. I'm just sticking with 1.16.1 for the moment and don't think there are any critical updates I need. It will be good to have this resolved in future releases along with general developments/improvements.
Gareth

[gajowi]

Any news?

[gajowi]

bump

[ndp-opendap]

Thanks Gareth - We will be planning the next block of work during the next ten days and I will get this on the schedule.

[gajowi]

any news?

[gajowi]

While working on #36 I built a new container that should be equivalent to the one in dockerhub (and his issue). Something is different and I get the following stacktrace info. Possibly I should make a new issue. Ultimately I'd like to help with upstream fixes and wait. for 1.16.3 :-)

HTTP Status 500 - ncWMS configuration object is null
type Exception report

message ncWMS configuration object is null

description The server encountered an internal error that prevented it from fulfilling this request.

exception

javax.servlet.ServletException: ncWMS configuration object is null
	uk.ac.rdg.resc.edal.ncwms.NcwmsServlet.init(NcwmsServlet.java:92)
	org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:498)
	org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
	org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:962)
	org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:445)
	org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1091)
	org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:637)
	org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:316)
	java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
	java.lang.Thread.run(Thread.java:748)
note The full stack trace of the root cause is available in the Apache Tomcat/7.0.76 logs.

[ndp-opendap]

Rebuilt and pushed hyrax_ncwms:1.16.2 with updated ncWMS-2.4.2 and of course patched OS.

[ndp-opendap]

@gajowi Please let me know if this works for you when you have a chance.

Thanks,

N

[gajowi]

Will do.

…

On Sat, 19 Dec 2020, 6:33 am Nathan Potter, ***@***.***> wrote: @gajowi <https://github.com/gajowi> Please let me know if this works for you when you have a chance. Thanks, N — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAUSKFIT2PQWYW3BHK2TH4LSVOVCJANCNFSM4OYBAOBQ> .

[gajowi]

Hi Nathan. I have has partial success testing. Actually that is optimistic... I have a new error: javax.servlet.ServletException: ncWMS configuration object is null (when getting /ncWMS2/wms/lds/testdata/nc/coads_climatology.nc?SERVICE=WMS&REQUEST=GetCapabilities&VERSION=1.3.0)
Maybe I need to explicitly configure ncWMS2 with the new code.
I'll get back to this later in the month.
BTW I tested the new 1.16.2 build. I'd happily move straight to testing the new 1.16.3 build if that has the same changes.