Skip to content

Feature review process

jasehumphr edited this page Jul 13, 2020 · 15 revisions

Development to Review

Before the ticket can be turned into a Pull request in Github the following steps have to be met.

  • All Acceptance Criteria must be me.
  • A visual front end check to make sure that the feature actually looks as it should according to the designs attached to the ticket
  • A linter is run against the code yarn lint
  • The Tests pass yarn test
  • The Test Coverage is passed yarn test --coverage

No console.log(); or unwanted code comments // import ScrollPane from "components/ScrollPane"; to be left in unless necessary.

A link to the Jira ticket is a must so the reviewer has easy access to the A/C. Screen grabs of what has been done can be helpful Steps on how to build can be helpful if new approach. Steps on how to test can be helpful

Review to PO Approval

Clone this wiki locally