1558 adding quality statements to filter outputs page

Author: mr-nick17

mapper/census.go

@@ -12,6 +12,7 @@ import (
 	"github.com/ONSdigital/dp-api-clients-go/v2/population"
 	"github.com/ONSdigital/dp-frontend-dataset-controller/helpers"
 	sharedModel "github.com/ONSdigital/dp-frontend-dataset-controller/model"
+	"github.com/ONSdigital/dp-frontend-dataset-controller/model/datasetLandingPageCensus"
 	coreModel "github.com/ONSdigital/dp-renderer/v2/model"
 )
 
@@ -146,3 +147,12 @@ func getDataLayerJavaScript(analytics map[string]string) template.JS {
 	jsonStr, _ := json.Marshal(analytics)
 	return template.JS(`dataLayer.push(` + string(jsonStr) + `);`)
 }
+
+// formatPanels is a helper function given an array of panels will format the final panel with the appropriate css class
+func formatPanels(panels []datasetLandingPageCensus.Panel) []datasetLandingPageCensus.Panel {
+	if len(panels) > 0 {
+		panelLen := len(panels)
+		panels[panelLen-1].CssClasses = append(panels[panelLen-1].CssClasses, "ons-u-mb-l")
+	}
+	return panels
+}

mapper/census_filter_outputs.go

@@ -69,7 +69,7 @@ func CreateCensusFilterOutputsPage(ctx context.Context, req *http.Request, baseP
 	}
 
 	// DIMENSIONS
-	p.DatasetLandingPage.Dimensions = mapFilterOutputDims(fDims, queryStrValues, req.URL.Path, p.DatasetLandingPage.IsMultivariate)
+	p.DatasetLandingPage.Dimensions, p.DatasetLandingPage.QualityStatements = mapFilterOutputDims(fDims, queryStrValues, req.URL.Path, lang, p.DatasetLandingPage.IsMultivariate)
 	coverage := sharedModel.Dimension{
 		IsCoverage:        true,
 		IsDefaultCoverage: hasNoAreaOptions,
@@ -125,15 +125,17 @@ func CreateCensusFilterOutputsPage(ctx context.Context, req *http.Request, baseP
 		}
 	}
 
+	// FINAL FORMATTING
+	p.DatasetLandingPage.QualityStatements = formatPanels(p.DatasetLandingPage.QualityStatements)
+
 	return p
 }
 
 // mapFilterOutputDims links dimension options to FilterDimensions and prepares them for display
-func mapFilterOutputDims(dims []sharedModel.FilterDimension, queryStrValues []string, path string, isMultivariate bool) []sharedModel.Dimension {
+func mapFilterOutputDims(dims []sharedModel.FilterDimension, queryStrValues []string, path, lang string, isMultivariate bool) (dimensions []sharedModel.Dimension, qs []datasetLandingPageCensus.Panel) {
 	sort.Slice(dims, func(i, j int) bool {
 		return *dims[i].IsAreaType
 	})
-	dimensions := []sharedModel.Dimension{}
 	for _, dim := range dims {
 		var isAreaType bool
 		if helpers.IsBoolPtr(dim.IsAreaType) {
@@ -165,9 +167,15 @@ func mapFilterOutputDims(dims []sharedModel.FilterDimension, queryStrValues []st
 			q.Add(queryStrKey, pDim.ID)
 		}
 		pDim.TruncateLink = generateTruncatePath(path, pDim.ID, q)
+		if dim.QualityStatementText != "" && dim.QualitySummaryURL != "" {
+			qs = append(qs, datasetLandingPageCensus.Panel{
+				Body:       []string{fmt.Sprintf("<p>%s</p>%s", dim.QualityStatementText, helper.Localise("QualityNoticeReadMore", lang, 1, dim.QualitySummaryURL))},
+				CssClasses: []string{"ons-u-mt-no"},
+			})
+		}
 		dimensions = append(dimensions, pDim)
 	}
-	return dimensions
+	return dimensions, qs
 }
 
 // getFilterAnalytics returns a map to add to the data layer which will be used on file download

mapper/census_filter_outputs_test.go

@@ -433,6 +433,50 @@ func TestCreateCensusFilterOutputsPagination(t *testing.T) {
 	})
 }
 
+func TestCreateCensusFilterOutputsQualityNotices(t *testing.T) {
+	helper.InitialiseLocalisationsHelper(mocks.MockAssetFunction)
+	req := httptest.NewRequest("", "/", nil)
+	pageModel := coreModel.Page{}
+	contacts := getTestContacts()
+	relatedContent := getTestRelatedContent()
+	datasetModel := getTestDatasetDetails(contacts, relatedContent)
+	datasetModel.Type = "multivariate"
+	serviceMessage := getTestServiceMessage()
+	emergencyBanner := getTestEmergencyBanner()
+
+	Convey("given a request for a filter outputs census landing page", t, func() {
+		version := getTestVersionDetails(1, getTestDefaultDimensions(), getTestDownloads([]string{"xlsx"}), nil)
+		filterDims := []sharedModel.FilterDimension{getTestFilterDimension("geography", true, []string{"option 1", "option 2"}, 2), getTestFilterDimension("first", false, []string{}, 2), getTestFilterDimension("second", false, []string{}, 2)}
+		filterOutputs := filter.Model{
+			Downloads: getTestFilterDownloads([]string{"xlsx"}),
+		}
+
+		Convey("when there is a quality notice on the dimension", func() {
+			filterDims[0].QualityStatementText = "This is a quality notice statement"
+			filterDims[0].QualitySummaryURL = "https://quality-notice-1.com"
+			filterDims[1].QualityStatementText = "This is another quality notice statement"
+			filterDims[1].QualitySummaryURL = "https://quality-notice-2.com"
+
+			page := CreateCensusFilterOutputsPage(context.Background(), req, pageModel, datasetModel, version, "", false, []dataset.Version{version}, 1, "/a/version/1", "", []string{}, 50, false, true, filterOutputs, filterDims, serviceMessage, emergencyBanner, true, population.GetDimensionsResponse{}, cantabular.GetBlockedAreaCountResult{}, population.GetPopulationTypeResponse{})
+
+			Convey("then the 'quality notice' panel is displayed", func() {
+				mockPanel := []datasetLandingPageCensus.Panel{
+					{
+						Body:       []string{"<p>This is a quality notice statement</p>Read more about this"},
+						CssClasses: []string{"ons-u-mt-no"},
+					},
+					{
+						Body:       []string{"<p>This is another quality notice statement</p>Read more about this"},
+						CssClasses: []string{"ons-u-mt-no", "ons-u-mb-l"},
+					},
+				}
+				So(page.DatasetLandingPage.QualityStatements, ShouldHaveLength, 2)
+				So(page.DatasetLandingPage.QualityStatements, ShouldResemble, mockPanel)
+			})
+		})
+	})
+}
+
 func TestCreateCensusFilterOutputsAnalytics(t *testing.T) {
 	Convey("given we have changed area_type only", t, func() {
 		filterDimensions := []sharedModel.FilterDimension{

mapper/census_landing_page.go

@@ -72,10 +72,7 @@ func CreateCensusLandingPage(ctx context.Context, req *http.Request, basePage co
 	p.PreGTMJavaScript = append(p.PreGTMJavaScript, getDataLayerJavaScript(getAnalytics(p.DatasetLandingPage.Dimensions)))
 
 	// FINAL FORMATTING
-	if len(p.DatasetLandingPage.QualityStatements) > 0 {
-		qsLen := len(p.DatasetLandingPage.QualityStatements)
-		p.DatasetLandingPage.QualityStatements[qsLen-1].CssClasses = append(p.DatasetLandingPage.QualityStatements[qsLen-1].CssClasses, "ons-u-mb-l")
-	}
+	p.DatasetLandingPage.QualityStatements = formatPanels(p.DatasetLandingPage.QualityStatements)
 
 	return p
 }