diff --git a/api/versions.go b/api/versions.go index 0d43baed..335c179f 100644 --- a/api/versions.go +++ b/api/versions.go @@ -849,7 +849,7 @@ func (api *DatasetAPI) addDatasetVersionCondensed(w http.ResponseWriter, r *http newInstance, err := instance.UnmarshalInstance(ctx, r.Body, true) if err != nil { log.Error(ctx, "failed to unmarshal instance", err, logData) - handleDatasetAPIErr(ctx, errs.ErrInvalidBody, w, nil) + handleVersionAPIErr(ctx, errs.ErrUnableToParseJSON, w, logData) return } @@ -869,7 +869,7 @@ func (api *DatasetAPI) addDatasetVersionCondensed(w http.ResponseWriter, r *http newInstance, err = api.dataStore.Backend.AddInstance(ctx, newInstance) if err != nil { log.Error(ctx, "failed to add instance", err, logData) - handleDatasetAPIErr(ctx, errs.ErrInternalServer, w, nil) + handleVersionAPIErr(ctx, err, w, logData) return } diff --git a/api/versions_test.go b/api/versions_test.go index 97123008..2f565af2 100644 --- a/api/versions_test.go +++ b/api/versions_test.go @@ -3025,6 +3025,6 @@ func TestAddDatasetVersionCondensed(t *testing.T) { api := GetAPIWithCMDMocks(mockedDataStore, &mocks.DownloadsGeneratorMock{}, datasetPermissions, permissions) api.addDatasetVersionCondensed(w, r) - convey.So(w.Code, convey.ShouldEqual, http.StatusInternalServerError) + convey.So(w.Code, convey.ShouldEqual, http.StatusBadRequest) }) }