Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v7.2]: Ensure we're returning the correct type of object #84

Open
lloydwatkin opened this issue Feb 24, 2025 · 0 comments
Open

[v7.2]: Ensure we're returning the correct type of object #84

lloydwatkin opened this issue Feb 24, 2025 · 0 comments

Comments

@lloydwatkin
Copy link
Member

By @nguyenngoc2505 in #47 (comment)

@lloydwatkin Thanks for the quick fixing, But I've another error.

https://github.com/OLIOEX/janus-ar/blob/main/lib/janus-ar/active_record/connection_adapters/janus_mysql2_adapter.rb#L130-L132

https://github.com/rails/rails/blob/v7.2.0/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb#L113-L115

I think replica_connection.execute(sql) return mysql result not ActiveRecord::Result so may we need to change execute to exec_query. I've try and it worked

Image
@lloydwatkin lloydwatkin changed the title Ensure we're returning the correct type of object [v7.2]: Ensure we're returning the correct type of object Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant