[IMP] report_pdf_form: Various improvements

fix(report_pdf_form): move binding to PDF form record

This commit moves the binding configuration from the ir.actions.report

record to the actual report.pdf.form record, which is the proper

location for the binding since the module inherits from ir.actions.report

using _inherits. This ensures the demo report appears in the contact's

print menu.

Author: bosd

report_pdf_form/README.rst

@@ -44,11 +44,11 @@ Creating PDF Form Fields
 To create PDFs with form fields for use with this module, you can use
 various tools:
 
--  **docfly.com**: An online tool for adding form fields to PDFs
--  **LibreOffice Draw**: Part of the LibreOffice suite, can add form
-   fields to PDFs
--  **Scribus**: A desktop publishing application that can create PDFs
-   with form fields
+- **docfly.com**: An online tool for adding form fields to PDFs
+- **LibreOffice Draw**: Part of the LibreOffice suite, can add form
+  fields to PDFs
+- **Scribus**: A desktop publishing application that can create PDFs
+  with form fields
 
 .. IMPORTANT::
    This is an alpha version, the data model and design can change at any time without warning.
@@ -87,7 +87,7 @@ Authors
 Contributors
 ------------
 
--  Akim Juillerat [email protected]
+- Akim Juillerat [email protected]
 
 Maintainers
 -----------

report_pdf_form/demo/report_pdf_form_demo.xml

@@ -19,8 +19,6 @@
         <field name="report_name">demo_partner_report</field>
         <field name="report_type">qweb-pdf</field>
         <field name="print_report_name">object.name</field>
-        <field name="binding_model_id" ref="base.model_res_partner" />
-        <field name="binding_type">report</field>
     </record>
 
     <!-- Demo PDF form configuration -->
@@ -29,6 +27,8 @@
         <field name="report_id" ref="demo_partner_report" />
         <field name="pdf_attachment_id" ref="demo_pdf_attachment" />
         <field name="model_id" ref="base.model_res_partner" />
+        <field name="binding_model_id" ref="base.model_res_partner" />
+        <field name="binding_type">report</field>
     </record>
 
     <!-- Demo field mappings -->

report_pdf_form/models/report_pdf_form.py

@@ -51,6 +51,17 @@ def create(self, vals_list):
         required=True,
     )
     model_id = fields.Many2one("ir.model", ondelete="cascade", required=True)
+
+    @api.onchange("report_id")
+    def _onchange_report_id(self):
+        """Auto-set model_id based on report_id's model."""
+        if self.report_id and self.report_id.model:
+            model = self.env["ir.model"].search(
+                [("model", "=", self.report_id.model)], limit=1
+            )
+            if model:
+                self.model_id = model.id
+
     # TODO:
     field_mapping_ids = fields.One2many(
         "report.pdf.form.field",
@@ -74,8 +85,8 @@ def action_preview_pdf(self):
         sample_record = self.env[model_name].search([], limit=1)
         if not sample_record:
             message = self.env._(
-                "No records found for model {model}. Cannot generate preview."
-            ).format(model=model_name)
+                "No records found for model %(model_name)s. Cannot generate preview."
+            ) % {"model_name": model_name}
             raise UserError(message)
 
         # Generate the PDF using the same logic as the report
@@ -150,7 +161,7 @@ def action_preview_pdf(self):
                 "target": "new",
             }
         except Exception as e:
-            message = self.env._("Could not generate PDF preview: {error}").format(
-                error=str(e)
-            )
+            message = self.env._("Could not generate PDF preview: %(error)s") % {
+                "error": str(e)
+            }
             raise UserError(message) from e

report_pdf_form/models/report_pdf_form_field.py

@@ -56,17 +56,21 @@ def _validate_dotted_path(self):
             return True  # Not a dotted path or empty, considered valid
 
         # Get the model from the parent report form
+        if (
+            not self.report_form_id
+            or not self.report_form_id.model_id
+            or not self.report_form_id.model_id.model
+        ):
+            return True  # Model not available yet, skip validation during creation
         model_name = self.report_form_id.model_id.model
-        if not model_name:
-            return False
+        if not model_name or model_name not in self.env:
+            return True  # Model not set or not in registry, skip validation
 
         # Split the dotted path
         path_parts = self.odoo_field_value.split(".")
 
         # Start with the base model
         current_model = self.env[model_name]
-        if not current_model:
-            return False
 
         # Traverse the path
         for i, field_name in enumerate(path_parts):
@@ -78,9 +82,9 @@ def _validate_dotted_path(self):
                 if field.type not in ["many2one", "one2many", "many2many"]:
                     return False  # Can't traverse further on non-relation field
                 # Move to the related model
+                if not field.comodel_name or field.comodel_name not in self.env:
+                    return False  # comodel not found
                 current_model = self.env[field.comodel_name]
-                if not current_model:
-                    return False
 
         return True
 
@@ -94,18 +98,19 @@ def action_validate_field(self):
                 "tag": "display_notification",
                 "params": {
                     "title": "Success",
-                    "message": f'The dotted path "{self.odoo_field_value}" is valid.',
+                    "message": self.env._('The dotted path "%(path)s" is valid.')
+                    % {"path": self.odoo_field_value},
                     "type": "success",
                     "sticky": False,
                 },
             }
         else:
             message = self.env._(
-                'The dotted path "{path}" is invalid for model "{model}".'
-            ).format(
-                path=self.odoo_field_value,
-                model=self.report_form_id.model_id.name,
-            )
+                'The dotted path "%(path)s" is invalid for model "%(model)s".'
+            ) % {
+                "path": self.odoo_field_value,
+                "model": self.report_form_id.model_id.name,
+            }
             return {
                 "type": "ir.actions.client",
                 "tag": "display_notification",
@@ -120,11 +125,20 @@ def action_validate_field(self):
     @api.constrains("odoo_field_evaluation", "odoo_field_value", "report_form_id")
     def _check_dotted_path(self):
         for record in self:
+            # Skip validation if model is not available (during creation/updates)
+            if (
+                not record.report_form_id
+                or not record.report_form_id.model_id
+                or not record.report_form_id.model_id.model
+            ):
+                continue  # Skip validation when model is not yet available
             if not record._validate_dotted_path():
-                message = self.env._(
-                    "The dotted path '{path}' is not valid for model '{model}'."
-                ).format(
-                    path=record.odoo_field_value,
-                    model=record.report_form_id.model_id.name,
+                model_name = (
+                    record.report_form_id.model_id.name
+                    if record.report_form_id.model_id
+                    else "Unknown"
                 )
+                message = self.env._(
+                    "The dotted path '%(path)s' is not valid for model '%(model)s'."
+                ) % {"path": record.odoo_field_value, "model": model_name}
                 raise ValidationError(message)

report_pdf_form/tests/test_report_pdf_form.py

@@ -42,6 +42,7 @@ def setUpClass(cls):
                 "name": "PDF Form Example",
                 "report_id": cls.empty_report.id,
                 "pdf_attachment_id": cls.pdf_attachment.id,
+                "model_id": cls.env.ref("base.model_res_partner").id,
                 "field_mapping_ids": [
                     Command.create(
                         {

report_pdf_form/views/report_pdf_form.xml

@@ -39,7 +39,7 @@
                                             type="object"
                                             icon="fa-check-circle"
                                             invisible="odoo_field_evaluation != 'dotted_path'"
-                                            help="Validate field mapping"
+                                            title="Validate field mapping"
                                         />
                                     </list>
                                 </field>