[MIG] sale_product_pack: Migration to 19.0 and code review

Author: FrancoMaxime

sale_product_pack/models/product_pack_line.py

@@ -24,18 +24,13 @@ def get_sale_order_line_vals(self, line, order):
             "pack_modifiable": line.product_id.pack_modifiable,
             "product_uom_qty": quantity,
         }
-        sol = line.new(line_vals)
-        vals = sol._convert_to_write(sol._cache)
         pack_price_types = {"totalized", "ignored"}
         if (
             line.product_id.pack_type == "detailed"
             and line.product_id.pack_component_price in pack_price_types
         ):
-            vals["price_unit"] = 0.0
-
-        vals["name"] = f"{'> ' * (line.pack_depth + 1)}{sol.name}"
-
-        return vals
+            line_vals["price_unit"] = 0.0
+        return line_vals
 
     def _get_pack_line_price(self, pricelist, quantity, uom=None, date=False, **kwargs):
         return super()._get_pack_line_price(

sale_product_pack/models/sale_order.py

@@ -7,16 +7,12 @@
 class SaleOrder(models.Model):
     _inherit = "sale.order"
 
-    def copy(self, default=None):
-        sale_copy = super().copy(default)
-        for record in self:
-            # we unlink pack lines that should not be copied
-            pack_copied_lines = sale_copy.order_line.filtered(
-                lambda x, order=record: x.pack_parent_line_id.order_id == order
-            )
-            if pack_copied_lines:
-                pack_copied_lines.unlink()
-        return sale_copy
+    def _get_copiable_order_lines(self):
+        self.ensure_one()
+        res = super()._get_copiable_order_lines()
+        return res.filtered(
+            lambda x, order=self: x.pack_parent_line_id.order_id != order
+        )
 
     @api.onchange("order_line")
     def check_pack_line_unlink(self):
@@ -58,6 +54,23 @@ def write(self, vals):
                         subpacks_to_delete_ids.remove(cmd[1])
                 for to_delete_id in subpacks_to_delete_ids:
                     vals["order_line"].append([2, to_delete_id, False])
+            if to_delete_ids:
+                # In the case of you modify the list of order lines
+                # Then you switch the tab of your browser
+                # That will trigger an invisible write operation
+                # even if the onchange triggered a raise
+                line_to_check = self.env["sale.order.line"].search(
+                    [("pack_child_line_ids", "in", to_delete_ids)]
+                )
+                for line in line_to_check:
+                    if not line.product_id.pack_modifiable:
+                        raise UserError(
+                            self.env._(
+                                "You cannot delete this line because is part of a pack"
+                                " in this sale order. In order to delete this line you"
+                                " need to delete the pack itself"
+                            )
+                        )
         return super().write(vals)
 
     def _get_update_prices_lines(self):

sale_product_pack/models/sale_order_line.py

@@ -166,3 +166,11 @@ def _compute_discount(self):
         for pack_line in self.filtered("pack_parent_line_id"):
             pack_line.discount = pack_line._get_pack_line_discount()
         return res
+
+    def _compute_name(self):
+        res = super()._compute_name()
+        for line in self:
+            parent = line.pack_parent_line_id
+            if parent.product_id.pack_ok and parent.pack_type == "detailed":
+                line.name = f"{'> ' * (parent.pack_depth + 1)}{line.name}"
+        return res

sale_product_pack/pyproject.toml

@@ -1,9 +1,3 @@
 [build-system]
 requires = ["whool"]
-
-[project]
-name = "odoo-addons-oca-product-pak"
-version = "19.0.20251027.0"
-dependencies = [
-    "odoo-addon-product_pack @ git+https://github.com/OCA/product-pack.git@refs/pull/223/head#subdirectory=product_pack",
-]
+build-backend = "whool.buildapi"