Merge pull request #406 from Tecnativa/fix-convert_field_to_html

pedrobaeza · web-flow · commit c8fbf2c565f1 · 2025-03-13T21:12:45.000+01:00
[FIX] convert_field_to_html: don't consider NULL values
diff --git a/openupgradelib/openupgrade.py b/openupgradelib/openupgrade.py
@@ -2498,7 +2498,7 @@ def convert_field_to_html(
         if version_info[0] < 16:
             do_raise("Translatable fields are only managed in version 16.0 or higher")
         cr.execute(  # pylint: disable=E8103
-            "SELECT id, {field_name} FROM {table};".format(
+            "SELECT id, {field_name} FROM {table} WHERE {field_name} IS NOT NULL".format(
                 field_name=field_name, table=table
             )
         )

Original file line number	Diff line number	Diff line change
`@@ -2498,7 +2498,7 @@ def convert_field_to_html(`
`2498`	`2498`	`if version_info[0] < 16:`
`2499`	`2499`	`do_raise("Translatable fields are only managed in version 16.0 or higher")`
`2500`	`2500`	`cr.execute( # pylint: disable=E8103`
`2501`		`- "SELECT id, {field_name} FROM {table};".format(`
	`2501`	`+ "SELECT id, {field_name} FROM {table} WHERE {field_name} IS NOT NULL".format(`
`2502`	`2502`	`field_name=field_name, table=table`
`2503`	`2503`	`)`
`2504`	`2504`	`)`