wip

Author: damdam-s

product_creation_dynamic_wizard/__manifest__.py

@@ -4,7 +4,7 @@
 
 {
     "name": "Product creation dynamic wizard",
-    "version": "14.0.0.1.2",
+    "version": "17.0.1.0.0",
     "license": "AGPL-3",
     "author": "Pierre Verkest <pierre@verkest.fr>, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/odoo-pim",

product_creation_dynamic_wizard/models/product_creation_question.py

@@ -36,7 +36,7 @@ class ProductCreationQuestion(models.Model):
         translate=True, tracking=True, help="The question displayed to the end user"
     )
     complete_name = fields.Char(
-        "Complete Name", compute="_compute_complete_name", store=True, recursive=True
+        compute="_compute_complete_name", store=True, recursive=True
     )
     parent_id = fields.Many2one(
         "product.creation.question",

product_creation_dynamic_wizard/tests/fake_product.py

@@ -2,6 +2,6 @@
 
 
 class FakeProduct(models.Model):
-    _inherit = "product.product"
+    _inherit = "product.product"  # pylint: disable=consider-merging-classes-inherited
 
     product_attribute = fields.Char()

product_creation_dynamic_wizard/views/product_creation_question.xml

@@ -4,7 +4,7 @@
         <field name="name">product.creation.question.tree</field>
         <field name="model">product.creation.question</field>
         <field name="arch" type="xml">
-            <tree string="Product creation question">
+            <tree>
                 <field name="sequence" widget="handle" />
                 <field name="parent_id" optional="show" />
                 <field name="name" optional="show" />

product_creation_dynamic_wizard/wizards/product_creation_dynamic_wizard.py

@@ -2,7 +2,7 @@
 # @author Pierre Verkest <pierre@verkest.fr>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 import json
-from typing import Optional
+import logging
 from uuid import uuid4
 
 from lxml import etree
@@ -11,6 +11,8 @@
 
 from odoo.addons.base_sparse_field.models.fields import Serialized
 
+logger = logging.getLogger(__name__)
+
 
 class WizardStep:
     record_id: int
@@ -20,15 +22,15 @@ class WizardStep:
     parent_index: int = -1
     """parent position in the current question tree"""
 
-    answer_id: Optional[int] = None
+    answer_id: int | None = None
     """in case of custom question this will save the user
     answer"""
 
     def __init__(
         self,
         record_id: int,
         parent_index: int,
-        answer_id: Optional[int] = None,
+        answer_id: int | None = None,
         odoo_env=None,
     ):
         self.record_id = record_id
@@ -129,8 +131,8 @@ def _populate_wizard_steps(self, wizard: Wizard, question, parent_index=-1):
                 odoo_env=self.env,
             )
         )
-        for question in question.child_ids:
-            self._populate_wizard_steps(wizard, question, parent_index=index)
+        for child_question in question.child_ids:
+            self._populate_wizard_steps(wizard, child_question, parent_index=index)
 
     def _default_wizard_steps(self):
         wizard = Wizard()
@@ -189,7 +191,8 @@ def _apply_step_custom(self, current_step, node, result):
                 name="answer_id",
                 attrib={
                     "domain": f'[("question_id", "=", {current_step.record_id})]',
-                    "options": "{'no_create': True, 'no_create_edit': True, 'no_open': True}",
+                    "options": "{'no_create': True, 'no_create_edit': True, "
+                    "'no_open': True}",
                     "nolabel": "1",
                     "required": "1" if current_step.answer_required else "0",
                 },
@@ -340,7 +343,8 @@ def _prepare_product_data(self):
             try:
                 # useful for m2m with value such as [(0,0,{...})]
                 field_value = json.loads(field_value)
-            except Exception:
+            except Exception as exc:
+                logger.warning(exception=exc)
                 pass
             return {self.step.field_id.name: field_value}
 

product_creation_dynamic_wizard/wizards/product_creation_dynamic_wizard.xml

@@ -23,7 +23,7 @@
                         string="Previous"
                         type="object"
                         name="action_open_previous"
-                        attrs="{'invisible': [('current_step', '=', 0)]}"
+                        invisible="current_step == 0"
                     />
                     <button
                         string="Next"