[IMP] website_attribute_set: add test cases

kobros-tech · kobros-tech · commit 2f2e2594a8a4 · 2025-05-26T20:21:05.000+03:00
diff --git a/test-requirements.txt b/test-requirements.txt
@@ -1,3 +1,4 @@
+odoo_test_helper
 odoo-addon-attribute_set @ git+https://github.com/OCA/odoo-pim.git@refs/pull/192/head#subdirectory=attribute_set
 odoo-addon-product_attribute_set @ git+https://github.com/OCA/odoo-pim.git@refs/pull/196/head#subdirectory=product_attribute_set
 odoo-addon-pim @ git+https://github.com/OCA/odoo-pim.git@refs/pull/197/head#subdirectory=pim
diff --git a/website_attribute_set/__init__.py b/website_attribute_set/__init__.py
@@ -1,4 +1,4 @@
-# Copyright 2011 Kencove (http://www.kencove.com).
+# Copyright 2025 Kencove (http://www.kencove.com).
 # @author Mohamed Alkobrosli <malkobrosly@kencove.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
diff --git a/website_attribute_set/__manifest__.py b/website_attribute_set/__manifest__.py
@@ -1,4 +1,4 @@
-# Copyright 2011 Kencove (http://www.kencove.com).
+# Copyright 2025 Kencove (http://www.kencove.com).
 # @author Mohamed Alkobrosli <malkobrosly@kencove.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
diff --git a/website_attribute_set/controllers/__init__.py b/website_attribute_set/controllers/__init__.py
@@ -1,4 +1,4 @@
-# Copyright 2011 Kencove (http://www.kencove.com).
+# Copyright 2025 Kencove (http://www.kencove.com).
 # @author Mohamed Alkobrosli <malkobrosly@kencove.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
diff --git a/website_attribute_set/controllers/main.py b/website_attribute_set/controllers/main.py
@@ -1,4 +1,4 @@
-# Copyright 2011 Kencove (http://www.kencove.com).
+# Copyright 2025 Kencove (http://www.kencove.com).
 # @author Mohamed Alkobrosli <malkobrosly@kencove.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
diff --git a/website_attribute_set/models/__init__.py b/website_attribute_set/models/__init__.py
@@ -1,4 +1,4 @@
-# Copyright 2011 Kencove (http://www.kencove.com).
+# Copyright 2025 Kencove (http://www.kencove.com).
 # @author Mohamed Alkobrosli <malkobrosly@kencove.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
diff --git a/website_attribute_set/models/attribute_attribute.py b/website_attribute_set/models/attribute_attribute.py
@@ -1,4 +1,4 @@
-# Copyright 2011 Kencove (http://www.kencove.com).
+# Copyright 2025 Kencove (http://www.kencove.com).
 # @author Mohamed Alkobrosli <malkobrosly@kencove.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
diff --git a/website_attribute_set/models/attribute_set_owner.py b/website_attribute_set/models/attribute_set_owner.py
@@ -1,4 +1,4 @@
-# Copyright 2011 Kencove (http://www.kencove.com).
+# Copyright 2025 Kencove (http://www.kencove.com).
 # @author Mohamed Alkobrosli <malkobrosly@kencove.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
diff --git a/website_attribute_set/models/mixins.py b/website_attribute_set/models/mixins.py
@@ -1,4 +1,4 @@
-# Copyright 2011 Kencove (http://www.kencove.com).
+# Copyright 2025 Kencove (http://www.kencove.com).
 # @author Mohamed Alkobrosli <malkobrosly@kencove.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
@@ -44,7 +44,6 @@ def search_extra(env, search_term):
             if similarity > 80:
                 extra_domain = [(attribute.name, "!=", False)]
                 extra_domains.append(extra_domain)
-
     return expression.OR(extra_domains)
 
 
@@ -67,5 +66,4 @@ def _search_fetch(self, search_detail, search, limit, order):
                 domain, limit=limit, order=search_detail.get("order", order)
             )
             count = model.search_count(domain)
-
         return results, count
diff --git a/website_attribute_set/models/product_product.py b/website_attribute_set/models/product_product.py
@@ -1,4 +1,4 @@
-# Copyright 2011 Kencove (http://www.kencove.com).
+# Copyright 2025 Kencove (http://www.kencove.com).
 # @author Mohamed Alkobrosli <malkobrosly@kencove.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
@@ -48,5 +48,4 @@ def _prepare_additional_attributes_for_display(self):
                         groups[attribute.attribute_group_id][attribute][product] = (
                             values.mapped("name")
                         )
-
         return groups
diff --git a/website_attribute_set/models/product_template.py b/website_attribute_set/models/product_template.py
@@ -1,4 +1,4 @@
-# Copyright 2011 Kencove (http://www.kencove.com).
+# Copyright 2025 Kencove (http://www.kencove.com).
 # @author Mohamed Alkobrosli <malkobrosly@kencove.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
@@ -10,10 +10,6 @@ class ProductTemplate(models.Model):
 
     def get_extra_attribute_values(self, extra_attribute=None):
         self.ensure_one()
-        extra_attribute_values = None
         if extra_attribute:
-            rec_value = getattr(self, extra_attribute.name)
-            if rec_value:
-                extra_attribute_values = rec_value
-
-        return extra_attribute_values
+            return self[extra_attribute.name] if self[extra_attribute.name] else None
+        return None
diff --git a/website_attribute_set/models/website.py b/website_attribute_set/models/website.py
@@ -1,4 +1,4 @@
-# Copyright 2011 Kencove (http://www.kencove.com).
+# Copyright 2025 Kencove (http://www.kencove.com).
 # @author Mohamed Alkobrosli <malkobrosly@kencove.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
@@ -13,7 +13,6 @@ class Website(models.Model):
     @api.model
     def _search_get_details(self, search_type, order, options):
         additional_attrib_values = options.get("additional_attrib_values")
-
         values = super()._search_get_details(
             search_type=search_type, order=order, options=options
         )
@@ -44,5 +43,4 @@ def _search_get_details(self, search_type, order, options):
                             (attribute_field, "=", additional_attrib_value)
                         ]
                         base_domain.append(additional_attrib_domain)
-
         return values
diff --git a/website_attribute_set/tests/__init__.py b/website_attribute_set/tests/__init__.py
@@ -0,0 +1,5 @@
+# Copyright 2025 Kencove (http://www.kencove.com).
+# @author Mohamed Alkobrosli <malkobrosly@kencove.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from . import test_website_attr_set
diff --git a/website_attribute_set/tests/test_website_attr_set.py b/website_attribute_set/tests/test_website_attr_set.py
@@ -0,0 +1,184 @@
+# Copyright 2025 Kencove (http://www.kencove.com).
+# @author Mohamed Alkobrosli <malkobrosly@kencove.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo.exceptions import ValidationError
+
+from odoo.addons.attribute_set.tests.test_build_view import BuildViewCase
+from odoo.addons.website_attribute_set.models.mixins import search_extra
+
+
+class TestAttributeSetSearchable(BuildViewCase):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.product_model = cls.env.ref("product.model_product_template")
+        cls.attr_set_1 = cls.env.ref("product_attribute_set.computer_attribute_set")
+        cls.attr_1 = cls.env.ref("product_attribute_set.computer_processor_attribute")
+        cls.attr_2 = cls.env.ref(
+            "product_attribute_set.computer_tech_description_attribute"
+        )
+        cls.attr_3 = cls.env["attribute.attribute"].create(
+            {
+                "nature": "custom",
+                "field_description": "Hard Disk",
+                "name": "x_hard_disk",
+                "attribute_type": "select",
+                "attribute_group_id": cls.env.ref(
+                    "product_attribute_set.computer_technical_attribute_group"
+                ).id,
+                "attribute_set_ids": [
+                    (
+                        4,
+                        cls.env.ref("product_attribute_set.computer_attribute_set").id,
+                        0,
+                    )
+                ],
+                "model_id": cls.env.ref("product.model_product_template").id,
+                "relation_model_id": cls.product_model.id,
+            }
+        )
+        cls.product_1 = cls.env["product.template"].create(
+            {
+                "name": "Test Smart Product",
+                "type": "consu",
+                "attribute_set_id": cls.attr_set_1.id,
+            }
+        )
+
+    def test__validate_domain(self):
+        with self.assertRaisesRegex(ValueError, r"name 'foo' is not defined"):
+            self.attr_select.domain = "foo"
+        self.attr_select.domain = ["|", ["name", "!=", "foo"], ["name", "!=", "foo"]]
+        with self.assertRaisesRegex(ValidationError, r"Invalid domain: "):
+            # Displace the "|" to the second position which is not correct
+            self.attr_select.domain = [
+                ["name", "!=", "foo"],
+                "|",
+                ["name", "!=", "foo"],
+            ]
+        self.attr_select.domain = [("name", "!=", "foo")]
+        self.attr_select.domain = []
+
+    def test_get_extra_attributes(self):
+        # Assert the method returns no attributes if they are not visible in e-com app
+        extra_attrs = self.product_1.get_extra_attributes()
+        self.assertFalse(extra_attrs)
+        # Assert the method returns only the attributes that are visible in e-com app
+        self.product_1.x_processor = self.env.ref(
+            "product_attribute_set.computer_processor_attribute_option_1"
+        )
+        self.product_1.write({"x_technical_description": "Fast processor"})
+        self.attr_1.write({"e_com_visibility": True})
+        extra_attrs = self.product_1.get_extra_attributes()
+        self.assertTrue(
+            len(extra_attrs) == 1 and extra_attrs.mapped("name") == ["x_processor"]
+        )
+        self.attr_2.write({"e_com_visibility": True})
+        extra_attrs = self.product_1.get_extra_attributes()
+        self.assertTrue(
+            len(extra_attrs) == 2
+            and extra_attrs.mapped("name") == ["x_processor", "x_technical_description"]
+        )
+
+    def test_search_extra(self):
+        # attributes are not visible in e-com
+        domain = search_extra(self.env, "Fast processor")
+        self.assertEqual(domain, [(0, "=", 1)])
+        # attributes are visible in e-com but
+        # if they are select or multi-select then
+        # they need relation_model_id value
+        self.attr_1.write({"e_com_visibility": True})
+        domain = search_extra(self.env, "Fast processor")
+        self.assertEqual(domain, [(0, "=", 1)])
+        # attributes are visible in e-com
+        self.attr_2.write({"e_com_visibility": True})
+        domain = search_extra(self.env, "Fast processor")
+        self.assertEqual(
+            domain, [("x_technical_description", "ilike", "Fast processor")]
+        )
+        # select, multi-select attributes are visible in e-com as
+        # they have relation_model_id value
+        self.attr_3.write({"e_com_visibility": True})
+        domain = search_extra(self.env, "Fast processor")
+        self.assertEqual(
+            domain,
+            [
+                "|",
+                ("x_hard_disk.name", "ilike", "Fast processor"),
+                ("x_technical_description", "ilike", "Fast processor"),
+            ],
+        )
+
+    def test__search_fetch(self):
+        self.product_1.write({"x_technical_description": "Fast processor"})
+        custom_domain = [
+            "&",
+            "&",
+            ("sale_ok", "=", True),
+            ("website_id", "in", (False, 1)),
+            "|",
+            "|",
+            "|",
+            ("name", "ilike", "Fast"),
+            ("default_code", "ilike", "Fast"),
+            ("product_variant_ids.default_code", "ilike", "Fast"),
+            "|",
+            ("x_hard_disk.name", "ilike", "Fast"),
+            ("x_technical_description", "ilike", "Fast"),
+        ]
+        result = self.env["product.template"].search(custom_domain)
+        # custom attributes don't appear in e-com search of we don't set visibility
+        results = (
+            self.env["website"]
+            .browse(1)
+            ._search_with_fuzzy(
+                "all",
+                "Fast",
+                limit=5,
+                order="name asc, website_id desc, id",
+                options={
+                    "displayDescription": False,
+                    "displayDetail": False,
+                    "displayExtraDetail": False,
+                    "displayExtraLink": False,
+                    "displayImage": False,
+                    "allowFuzzy": True,
+                },
+            )
+        )
+        for i in results[1]:
+            self.assertEqual(i["count"], 0)
+        # custom attributes appear in e-com search of we set visibility
+        self.attr_2.write({"e_com_visibility": True})
+        self.attr_3.write({"e_com_visibility": True})
+        results = (
+            self.env["website"]
+            .browse(1)
+            ._search_with_fuzzy(
+                "all",
+                "Fast",
+                limit=5,
+                order="name asc, website_id desc, id",
+                options={
+                    "displayDescription": False,
+                    "displayDetail": False,
+                    "displayExtraDetail": False,
+                    "displayExtraLink": False,
+                    "displayImage": False,
+                    "allowFuzzy": True,
+                },
+            )
+        )
+        for i in results[1]:
+            if i["count"] > 0:
+                self.assertEqual(i["count"], 1)
+                self.assertEqual(i["results"].mapped("name"), ["Test Smart Product"])
+                self.assertEqual(i["results"], result)
+
+    def test_get_extra_attribute_values(self):
+        extra_attribute_values = self.product_1.get_extra_attribute_values(self.attr_2)
+        self.assertEqual(extra_attribute_values, None)
+        self.product_1.write({"x_technical_description": "Fast processor"})
+        extra_attribute_values = self.product_1.get_extra_attribute_values(self.attr_2)
+        self.assertEqual(extra_attribute_values, "Fast processor")

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# Copyright 2011 Kencove (http://www.kencove.com).`
	`1`	`+# Copyright 2025 Kencove (http://www.kencove.com).`
`2`	`2`	`# @author Mohamed Alkobrosli <[email protected]>`
`3`	`3`	`# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).`
`4`	`4`