From c1f7b2e08662a126a5d5621d92e78e02af44b333 Mon Sep 17 00:00:00 2001
From: anusrinps96 <aprakhasam@nps100.com>
Date: Wed, 8 Oct 2025 08:41:00 +0200
Subject: [PATCH] [16.0][IMP] base_geoengine: Fix Vector Layer related Error

    Notifying user to define selected attribute_field_id of
supported type from vector layer as part of geoengine view
xml defintion which avoids observed JS error.
---
 .../geoengine_renderer.esm.js                 | 40 ++++++++++++++++---
 1 file changed, 35 insertions(+), 5 deletions(-)

diff --git a/base_geoengine/static/src/js/views/geoengine/geoengine_renderer/geoengine_renderer.esm.js b/base_geoengine/static/src/js/views/geoengine/geoengine_renderer/geoengine_renderer.esm.js
index 57b5156c4..b4c50249d 100644
--- a/base_geoengine/static/src/js/views/geoengine/geoengine_renderer/geoengine_renderer.esm.js
+++ b/base_geoengine/static/src/js/views/geoengine/geoengine_renderer/geoengine_renderer.esm.js
@@ -53,6 +53,7 @@ export class GeoengineRenderer extends Component {
         this.orm = useService("orm");
         this.view = useService("view");
         this.user = useService("user");
+        this.notification = useService("notification");
 
         // For related model we need to load all the service needed by RelationalModel
         this.services = {};
@@ -757,8 +758,12 @@ export class GeoengineRenderer extends Component {
         const fields_to_read = this.getFieldsToRead(vector);
         const data = await this.getModelData(vector, fields_to_read);
         this.useRelatedModel(vector, layer, data);
-        const styleInfo = this.styleVectorLayer(vector, data);
-        this.initLegend(styleInfo, vector);
+        if (this.checkAttributeFieldUsage(vector, data)) {
+            const styleInfo = this.styleVectorLayer(vector, data);
+            if (styleInfo) {
+                this.initLegend(styleInfo, vector);
+            }
+        }
     }
 
     async renderVectorLayers() {
@@ -852,9 +857,13 @@ export class GeoengineRenderer extends Component {
     }
 
     styleVectorLayerAndLegend(cfg, data, lv) {
-        const styleInfo = this.styleVectorLayer(cfg, data);
-        this.initLegend(styleInfo, cfg);
-        lv.setStyle(styleInfo.style);
+        if (this.checkAttributeFieldUsage(cfg, data)) {
+            const styleInfo = this.styleVectorLayer(cfg, data);
+            if (styleInfo) {
+                this.initLegend(styleInfo, cfg);
+                lv.setStyle(styleInfo.style);
+            }
+        }
     }
 
     initLegend(styleInfo, cfg) {
@@ -1256,6 +1265,27 @@ export class GeoengineRenderer extends Component {
         var indicator = cfg.attribute_field_id[1];
         return data.map((item) => item._values[indicator]);
     }
+
+    /**
+     * Check vector Layer Attribute Field is defined
+     * by view to display proper legends
+     */
+    checkAttributeFieldUsage(cfg, data) {
+        const indicator_values = this.extractLayerValues(cfg, data);
+        if (indicator_values.some((item) => typeof item === "undefined")) {
+            this.notification.add(
+                this.env._t(
+                    "Customize view to use Attribute Field: " +
+                        cfg.attribute_field_id[1]
+                ),
+                {
+                    type: "warning",
+                }
+            );
+            return false;
+        }
+        return true;
+    }
 }
 
 GeoengineRenderer.template = "base_geoengine.GeoengineRenderer";