[16.0][IMP] fieldservice_geoengie: Fix vector Layer related Errors

   Notifying user to define selected attribute_field_id of
supported type from vector layer in infoBox template to avoid
JS error. Addressed JS Error when supported data type even
defined in geoengine view as well.
   When a field from attribute_field_id values selected from
vector layer is not suitable for "custom" classification, it
is notified to the user to avoid JS Error.Similarly for interval
classification is also taken care.
   Domain for attribute_field_id is filter based on classification
selection in vector layer to avoid JS Error.

Author: anusriNPS

fieldservice_geoengine/models/vector_layer.py

@@ -7,6 +7,18 @@
 from odoo.exceptions import ValidationError
 
 NUMBER_ATT = ["float", "integer", "integer_big"]
+SUPPORTED_ATT = [
+    "float",
+    "integer",
+    "integer_big",
+    "related",
+    "function",
+    "date",
+    "datetime",
+    "char",
+    "text",
+    "selection",
+]
 
 
 class GeoVectorLayer(models.Model):
@@ -31,3 +43,27 @@ def _check_geo_repr(self):
                             "You need to select a numeric field",
                         )
                     )
+
+    @api.depends("geo_field_id", "classification", "geo_repr")
+    def _compute_attribute_field_id_domain(self):
+        for rec in self:
+            if rec.geo_field_id:
+                if (
+                    rec.geo_repr == "colored"
+                    and (
+                        rec.classification != "unique"
+                        and rec.classification != "custom"
+                    )
+                    or rec.geo_repr == "proportion"
+                ):
+                    rec.attribute_field_id_domain = [
+                        ("ttype", "in", NUMBER_ATT),
+                        ("model", "=", rec.geo_field_id.model_id.model),
+                    ]
+                else:
+                    rec.attribute_field_id_domain = [
+                        ("ttype", "in", SUPPORTED_ATT),
+                        ("model", "=", rec.geo_field_id.model_id.model),
+                    ]
+            else:
+                rec.attribute_field_id_domain = [("ttype", "in", SUPPORTED_ATT)]

fieldservice_geoengine/oca_dependencies.txt

@@ -0,0 +1 @@
+geospatial https://github.com/OCA/geospatial refs/pull/417/head 9825f67d128918294b67b74d324d1e6d3259399b

fieldservice_geoengine/static/src/js/views/geoengine/geoengine_renderer/geoengine_renderer.esm.js

@@ -34,6 +34,23 @@ patch(GeoengineRenderer.prototype, "geoengine_renderer_view_patch", {
             case "unique":
             case "custom":
                 vals = serie.getClassUniqueValues();
+                if (
+                    cfg.classification === "custom" &&
+                    vals.some((item) => item === 0)
+                ) {
+                    this.notification.add(
+                        this.env._t(
+                            "Could not generate " +
+                                cfg.classification +
+                                " range for selected Attribute Field: " +
+                                indicator
+                        ),
+                        {
+                            type: "warning",
+                        }
+                    );
+                    return false;
+                }
                 // "RdYlBu" is a set of colors
                 scale = chroma.scale("RdYlBu").domain([0, vals.length], vals.length);
                 break;
@@ -45,6 +62,18 @@ patch(GeoengineRenderer.prototype, "geoengine_renderer_view_patch", {
             case "interval":
                 serie.getClassEqInterval(nb_class);
                 vals = serie.getRanges();
+                if (vals.some((item) => item === "0 - 0")) {
+                    this.notification.add(
+                        this.env._t(
+                            "Could not generate interval range for selected Attribute Field: " +
+                                indicator
+                        ),
+                        {
+                            type: "warning",
+                        }
+                    );
+                    return false;
+                }
                 scale = scale.domain([0, vals.length], vals.length);
                 break;
         }
@@ -81,7 +110,13 @@ patch(GeoengineRenderer.prototype, "geoengine_renderer_view_patch", {
                 } else if (label_text !== "") {
                     label_text = feature.values_.attributes.stage_name;
                 }
-                styles_map[colors[color_idx]][0].text_.text_ = label_text.toString();
+                try {
+                    styles_map[colors[color_idx]][0].text_.text_ =
+                        label_text.toString();
+                } catch (error) {
+                    // Do nothing to restore history
+                    return;
+                }
                 return styles_map[colors[color_idx]];
             },
             legend,
@@ -134,8 +169,42 @@ patch(GeoengineRenderer.prototype, "geoengine_renderer_view_patch", {
             }
             aux.push(data[i]);
         }
-        const styleInfo = this.styleVectorLayer(cfg, aux);
-        this.initLegend(styleInfo, cfg);
-        lv.setStyle(styleInfo.style);
+        if (this.checkAttributeFieldUsage(cfg, aux)) {
+            const styleInfo = this.styleVectorLayer(cfg, aux);
+            if (styleInfo) {
+                this.initLegend(styleInfo, cfg);
+                lv.setStyle(styleInfo.style);
+            }
+        }
+    },
+    /**
+     * Allows you to find the index of the color to be used according to its value.
+     * @param {*} val
+     * @param {*} a
+     * @returns {Number}
+     */
+    getClass(val, a) {
+        if (a.some((item) => item === 0)) {
+            return false;
+        }
+        // Classification uniqueValues
+        var idx = a.indexOf(val);
+        if (idx > -1) {
+            return idx;
+        }
+        // Range classification
+        var separator = " - ";
+        for (var i = 0; i < a.length; i++) {
+            // All classification except uniqueValues
+            if (typeof val !== "object" && a[i].indexOf(separator) !== -1) {
+                var item = a[i].split(separator);
+                if (val <= parseFloat(item[1])) {
+                    return i;
+                }
+            } else if (val === a[i]) {
+                // Classification uniqueValues
+                return i;
+            }
+        }
     },
 });