Skip to content

[18.0][IMP] contract: Adding optional fields on tree view#1386

Closed
noah-lemarinel wants to merge 0 commit intoOCA:18.0from
noah-lemarinel:18.0
Closed

[18.0][IMP] contract: Adding optional fields on tree view#1386
noah-lemarinel wants to merge 0 commit intoOCA:18.0from
noah-lemarinel:18.0

Conversation

@noah-lemarinel
Copy link
Copy Markdown

  • code
  • date_start
  • date_end
  • recurring_next_date
  • invoice_partner_id
  • commercial_partner_id
  • invoice_count

refs #1385

@pedrobaeza
Copy link
Copy Markdown
Member

At least invoice_count shouldn't be added, as it's not stored, and it will require a lot of computations for showing it up. Some of the rest of the fields are not shown because they may not be valid if the recurrence is set by line.

@pedrobaeza pedrobaeza added this to the 18.0 milestone Feb 3, 2026
@pedrobaeza pedrobaeza changed the title [IMP] contract: Adding optional fields on tree view [18.0][IMP] contract: Adding optional fields on tree view Feb 3, 2026
options="{'color_field': 'color'}"
/>
<field name="company_id" groups="base.group_multi_company" />
<field name="code" optional="hide" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is showed in:
https://github.com/OCA/contract/pull/1386/changes#diff-824d27cca50c885b1fb2a66f39e66227a4ea197d6be188550c503be3c1e9e75dR419
Add optional="show" in existing field if you want hide:

Comment on lines +431 to +432
<field name="invoice_partner_id" optional="hide" />
<field name="commercial_partner_id" optional="hide" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is best to add these fields after partner_id to keep all related fields together.

Copy link
Copy Markdown
Contributor

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix pre-commit issues and squash commits into a single one commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants