[MIG] agreement: Migration to 19.0

Author: Vang-NguyenPhu

agreement/README.rst

@@ -21,13 +21,13 @@ Agreement
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fagreement-lightgray.png?logo=github
-    :target: https://github.com/OCA/agreement/tree/18.0/agreement
+    :target: https://github.com/OCA/agreement/tree/19.0/agreement
     :alt: OCA/agreement
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement
+    :target: https://translation.odoo-community.org/projects/agreement-19-0/agreement-19-0-agreement
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/agreement&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/agreement&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -57,7 +57,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/agreement/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/agreement/issues/new?body=module:%20agreement%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/agreement/issues/new?body=module:%20agreement%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -93,6 +93,10 @@ Contributors
 
   - Nhan Tran <[email protected]>
 
+- `Komit <https://komit-consulting.com>`__:
+
+  - Vang Nguyen Phu
+
 Other credits
 -------------
 
@@ -123,6 +127,6 @@ Current `maintainers <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-ygol| |maintainer-alexis-via| 
 
-This module is part of the `OCA/agreement <https://github.com/OCA/agreement/tree/18.0/agreement>`_ project on GitHub.
+This module is part of the `OCA/agreement <https://github.com/OCA/agreement/tree/19.0/agreement>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

agreement/__manifest__.py

@@ -4,7 +4,7 @@
 {
     "name": "Agreement",
     "summary": "Adds an agreement object",
-    "version": "18.0.1.2.0",
+    "version": "19.0.1.0.0",
     "category": "Contract",
     "author": "Akretion, "
     "Yves Goldberg (Ygol Internetwork), "

agreement/migrations/18.0.1.1.0/post-mig.py

@@ -10,6 +10,11 @@ class Agreement(models.Model):
     _description = "Agreement"
     _inherit = ["mail.thread", "mail.activity.mixin"]
 
+    _code_uniq = models.Constraint(
+        "unique(code, commercial_partner_id, company_id)",
+        "This agreement code already exists for this commercial entity!",
+    )
+
     code = fields.Char(required=True, tracking=True)
     name = fields.Char(required=True, tracking=True)
     partner_id = fields.Many2one(
@@ -74,18 +79,11 @@ def _compute_domain(self):
             else:
                 rec.domain = "sale"
 
+    @api.depends("code", "name")
     def _compute_display_name(self):
         for rec in self:
             rec.display_name = f"[{rec.code}] {rec.name}"
 
-    _sql_constraints = [
-        (
-            "code_partner_company_unique",
-            "unique(code, commercial_partner_id, company_id)",
-            "This agreement code already exists for this commercial entity!",
-        )
-    ]
-
     def copy(self, default=None):
         """Always assign a value for code because is required"""
         default = dict(default or {})

agreement/models/agreement.py

@@ -12,18 +12,23 @@ class Partner(models.Model):
 
     @api.depends("agreement_ids")
     def _compute_agreements_count(self):
-        domain = [("partner_id", "in", self.ids)]
-        res = self.env["agreement"].read_group(
-            domain=domain, fields=["partner_id"], groupby=["partner_id"]
+        results = self.env["agreement"]._read_group(
+            [("partner_id", "in", self.ids)],
+            ["partner_id"],
+            ["__count"],
         )
-        agreement_dict = {x["partner_id"][0]: x["partner_id_count"] for x in res}
+        agreement_dict = {partner.id: count for partner, count in results}
         for rec in self:
             rec.agreements_count = agreement_dict.get(rec.id, 0)
 
     def action_open_agreement(self):
         self.ensure_one()
         action = self.env.ref("agreement.agreement_action")
         result = action.read()[0]
-        result["domain"] = [("partner_id", "=", self.id)]
-        result["context"] = {"default_partner_id": self.id}
+        result.update(
+            {
+                "domain": [("partner_id", "=", self.id)],
+                "context": {"default_partner_id": self.id},
+            }
+        )
         return result

agreement/models/res_partner.py

@@ -16,3 +16,5 @@
 - [Trobz](https://www.trobz.com/):
 
   - Nhan Tran \<<[email protected]>\>
+- [Komit](https://komit-consulting.com):
+  - Vang Nguyen Phu

agreement/readme/CONTRIBUTORS.md

@@ -13,9 +13,8 @@
     </record>
     <record id="group_use_agreement_type" model="res.groups">
         <field name="name">Use agreement type</field>
-        <field name="category_id" ref="base.module_category_hidden" />
         <field
-            name="users"
+            name="user_ids"
             eval="[
               Command.link(ref('base.user_root')),
               Command.link(ref('base.user_admin'))
@@ -24,9 +23,8 @@
     </record>
     <record id="group_use_agreement_template" model="res.groups">
         <field name="name">Use agreement template</field>
-        <field name="category_id" ref="base.module_category_hidden" />
         <field
-            name="users"
+            name="user_ids"
             eval="[
               Command.link(ref('base.user_root')),
               Command.link(ref('base.user_admin'))

agreement/security/agreement_security.xml

@@ -374,7 +374,7 @@ <h1>Agreement</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:49b0d0253a7a24a76a3715048d575129b75d07ce3204fd364c7bff9222429526
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/agreement/tree/18.0/agreement"><img alt="OCA/agreement" src="https://img.shields.io/badge/github-OCA%2Fagreement-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/agreement&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/agreement/tree/19.0/agreement"><img alt="OCA/agreement" src="https://img.shields.io/badge/github-OCA%2Fagreement-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/agreement-19-0/agreement-19-0-agreement"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/agreement&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module adds an <em>Agreement</em> object with the following properties:</p>
 <ul class="simple">
 <li>code,</li>
@@ -405,7 +405,7 @@ <h2><a class="toc-backref" href="#toc-entry-1">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/agreement/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/agreement/issues/new?body=module:%20agreement%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/agreement/issues/new?body=module:%20agreement%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -445,6 +445,11 @@ <h3><a class="toc-backref" href="#toc-entry-4">Contributors</a></h3>
 <li>Nhan Tran &lt;<a class="reference external" href="mailto:nhant&#64;trobz.com">nhant&#64;trobz.com</a>&gt;</li>
 </ul>
 </li>
+<li><p class="first"><a class="reference external" href="https://komit-consulting.com">Komit</a>:</p>
+<ul class="simple">
+<li>Vang Nguyen Phu</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="other-credits">
@@ -463,7 +468,7 @@ <h3><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h3>
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainers</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/ygol"><img alt="ygol" src="https://github.com/ygol.png?size=40px" /></a> <a class="reference external image-reference" href="https://github.com/alexis-via"><img alt="alexis-via" src="https://github.com/alexis-via.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/agreement/tree/18.0/agreement">OCA/agreement</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/agreement/tree/19.0/agreement">OCA/agreement</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>