chore: make the code more straightforward (#31)

Author: zherner

action.yaml

@@ -44,6 +44,7 @@ runs:
         HELPER__LINEAR__TOKEN: ${{ inputs.linear-token }}
         HELPER__SLACK__BOT_TOKEN: ${{ inputs.slack-bot-token }}
         HELPER__SLACK__DEPLOY_CHANNEL: ${{ inputs.slack-channel-name }}
+        HELPER__DEPLOY: ${{ inputs.enable-deploy }}
 
 branding:
   color: 'blue'

ruff.toml

@@ -64,6 +64,7 @@ ignore = [# https://docs.astral.sh/ruff/settings/#lint_ignore
     "D106", # Missing docstring in public nested class
     "D107", # Missing docstring in __init__
     "RET504", # Missing return type annotation
+    "PLR0913",
 ]
 
 [lint.per-file-ignores]

src/release_helper/main.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from typing import TYPE_CHECKING
 
 from loguru import logger
@@ -25,52 +27,83 @@ def process_potential_release() -> None:
     try:
         release_draft: GitRelease = github.get_draft_release()
     except ReleaseHelperError as e:
-        slack.send_errors(channel=settings.helper.slack.deploy_channel, errors=[e])
-        logger.info("No draft release found. Exiting.")
+        handle_no_draft_release(slack, settings, e)
         return
 
     issue_names = github.get_issues_from_release(release_draft)
-
     issues, errors = linear.get_issues(issue_names)
 
     if settings.helper.deploy:
-        if len(errors) == 0:
-            if all(issue.state.type == "completed" for issue in issues):
-                github.deploy(release_draft)
-                linear.set_issues_to_deployed(issues)
-                slack.send_deploy_message(
-                    channel=settings.helper.slack.deploy_channel,
-                    release_title=release_draft.title,
-                )
-                logger.info("Release deployed.")
-            else:
-                slack.send_release_message(
-                    channel=settings.helper.slack.deploy_channel,
-                    release_draft=release_draft,
-                    issues=issues,
-                    repository=settings.github_repository,
-                )
-                slack.send_not_deploy_message(
-                    channel=settings.helper.slack.deploy_channel,
-                    release_title=release_draft.title,
-                )
-                logger.info("Not all issues are completed.")
-        else:
-            slack.send_errors(
-                channel=settings.helper.slack.deploy_channel, errors=errors
-            )
-            logger.info("Errors found. Not deploying.")
+        handle_deploy(settings, slack, github, linear, release_draft, issues, errors)
+    else:
+        handle_non_deploy(settings, slack, issues, release_draft)
+
+
+def handle_no_draft_release(
+    error: ReleaseHelperError,
+    settings: Settings,
+    slack: MessagingSlack,
+) -> None:
+    slack.send_errors(channel=settings.helper.slack.deploy_channel, errors=[error])
+    logger.info("No draft release found. Exiting.")
+
+
+def handle_deploy(
+    errors: list[Exception],
+    github: SourceControlGithub,
+    issues: list[IssueManagementLinear.Issue],
+    linear: IssueManagementLinear,
+    release_draft: GitRelease,
+    settings: Settings,
+    slack: MessagingSlack,
+) -> None:
+    if errors:
+        slack.send_errors(channel=settings.helper.slack.deploy_channel, errors=errors)
+        logger.info("Errors found. Not deploying. %s", errors)
         return
 
+    if all(issue.state.type == "completed" for issue in issues):
+        github.deploy(release_draft)
+        linear.set_issues_to_deployed(issues)
+        slack.send_deploy_message(
+            channel=settings.helper.slack.deploy_channel,
+            release_title=release_draft.title,
+        )
+        logger.info("Release deployed.")
+    else:
+        slack.send_release_message(
+            channel=settings.helper.slack.deploy_channel,
+            release_draft=release_draft,
+            issues=issues,
+            repository=settings.github_repository,
+        )
+        slack.send_not_deploy_message(
+            channel=settings.helper.slack.deploy_channel,
+            release_title=release_draft.title,
+        )
+        logger.info("Not all issues are completed. Not deploying.")
+
+
+def handle_non_deploy(
+    issues: list[IssueManagementLinear.Issue],
+    release_draft: GitRelease,
+    settings: Settings,
+    slack: MessagingSlack,
+) -> None:
     for issue in issues:
         if issue.state.type != "completed":
             block = slack.generate_user_message(issue)
             channel = settings.helper.slack.channels.get(
                 issue.team.key.casefold(), settings.helper.slack.deploy_channel
             )
             slack.send_blocks(channel=channel, blocks=[block], text="")
+            logger.info("Ticket Status messages sent.")
 
-        logger.info("Ticket Status messages sent.")
+    slack.send_not_deploy_message(
+        channel=settings.helper.slack.deploy_channel,
+        release_title=release_draft.title,
+    )
+    logger.info("The deploy setting is '%s'. Not deploying.", settings.helper.deploy)
 
 
 if __name__ == "__main__":