From ba925fabfcf5ca2ecf216725b8fbdab851d772bc Mon Sep 17 00:00:00 2001 From: "khadar.yonis" Date: Wed, 15 Jun 2022 15:56:21 +0200 Subject: [PATCH 1/2] minor --- resources/views/site/product.blade.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/resources/views/site/product.blade.php b/resources/views/site/product.blade.php index 779e9bfea..b7e9ad993 100644 --- a/resources/views/site/product.blade.php +++ b/resources/views/site/product.blade.php @@ -21,9 +21,7 @@ - - - +
From 3f5bdbde09b0073cba4396bcf62ae37c3623a8dc Mon Sep 17 00:00:00 2001 From: khadar-yonis Date: Wed, 15 Jun 2022 16:47:41 +0200 Subject: [PATCH 2/2] (front react) : added placeholder image --- package.json | 1 + .../js/Collection/CollectionGridItem.jsx | 23 +++++++++------ resources/assets/js/Detail/MainImage.jsx | 28 +++++++++++-------- 3 files changed, 31 insertions(+), 21 deletions(-) diff --git a/package.json b/package.json index 534e8eb97..c7b018d24 100644 --- a/package.json +++ b/package.json @@ -54,6 +54,7 @@ "react-loading-image": "^0.5.0", "react-modal2": "^5.0.0", "react-nl2br": "^0.4.0", + "react-placeholder-image": "^0.1.8", "react-router-dom": "^4.3.1", "react-router-scroll-memory": "^2.0.3", "react-textarea-autosize": "^7.1.0", diff --git a/resources/assets/js/Collection/CollectionGridItem.jsx b/resources/assets/js/Collection/CollectionGridItem.jsx index 4b1cd1131..08093a6ce 100644 --- a/resources/assets/js/Collection/CollectionGridItem.jsx +++ b/resources/assets/js/Collection/CollectionGridItem.jsx @@ -5,6 +5,8 @@ import classNames from "classnames"; import Heart from "../icons/Heart"; import RemoveButton from "../ui/RemoveButton"; +import { CustomPlaceholder } from "react-placeholder-image" + export default function CollectionGridItem({ onObjectClick, onSelectionClick, @@ -58,15 +60,18 @@ export default function CollectionGridItem({ "--aspect-ratio": datum.images[0].width / datum.images[0].height }} > - + {/**/} + + + {/* {this.props.image ? (
- ( - - - - )} - loading={() => } - error={() =>
Error
} - className="DetailMainImage__img" - /> + {/* (*/} + {/* */} + {/* */} + {/* */} + {/* )}*/} + {/* loading={() => }*/} + {/* error={() =>
Error
}*/} + {/* className="DetailMainImage__img"*/} + {/*/>*/} {this.props.onSelectionClick && (
+ +