UserManager: we only update email if its actually changed

dpslwk · dpslwk · commit 1f88fcda9342 · 2019-05-26T07:39:04.000+01:00
Was getting UserEmailChanged event
diff --git a/app/HMS/User/UserManager.php b/app/HMS/User/UserManager.php
@@ -94,7 +94,7 @@ public function updateFromRequest(User $user, Request $request): User
             $user->setLastname($request['lastname']);
         }
 
-        if ($request['email']) {
+        if ($request['email'] && $request['email'] != $user->getEmail()) {
             $oldEmail = $user->getEmail();
             $user->setEmail($request['email']);
             if ($user instanceof MustVerifyEmail) {

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ public function updateFromRequest(User $user, Request $request): User`
`94`	`94`	`$user->setLastname($request['lastname']);`
`95`	`95`	`}`
`96`	`96`
`97`		`- if ($request['email']) {`
	`97`	`+ if ($request['email'] && $request['email'] != $user->getEmail()) {`
`98`	`98`	`$oldEmail = $user->getEmail();`
`99`	`99`	`$user->setEmail($request['email']);`
`100`	`100`	`if ($user instanceof MustVerifyEmail) {`