Merge branch 'main' into filer-smart-duplicate

Author: jgclark

.babelrc

@@ -0,0 +1,4 @@
+# Add directories or file patterns to ignore during indexing (e.g. foo/ or *.csv)
+node_modules/
+.history/
+.git/

.cursorignore

@@ -2,13 +2,15 @@
   "extends": [
     "eslint:recommended",
     "plugin:import/recommended",
+    // "plugin:prettier/recommended",
     "plugin:import/errors",
     "plugin:import/warnings",
     "plugin:flowtype/recommended",
     "prettier",
     "plugin:react/recommended"
   ],
   "plugins": [
+    // "prettier",
     "import",
     "flowtype",
     "unused-imports",
@@ -36,7 +38,7 @@
       1,
       {
         "args": "all",
-        "varsIgnorePattern": "^_|^clo$|^timer$|^log|^JSP$|^clof$|^res$",
+        "varsIgnorePattern": "^_|^clo$|^clvt$|^timer$|^log|^JSP$|^clof$|^res$|^describe$|^test$|^expect$|^beforeAll$|customConsole$|simpleFormatter$|Note$|^Paragraph$|^NotePlan$|^Editor$|^DataStore$|^CommandBar$|^Calendar$|^CalendarItem$|^Clipboard$|^HTMLView$|^globalThis$",
         "argsIgnorePattern": "^_"
       }
     ],
@@ -68,17 +70,18 @@
     ],
     "new-cap": "off",
     "no-case-declarations": "error",
+    "no-console": "off",
     "no-floating-promise/no-floating-promise": 2,
+    "no-prototype-builtins": "off",
+    // "no-return-in-foreach": "error",
+    "no-useless-escape": "off",
     "no-var": "error",
     "prefer-const": "warn",
-    "no-prototype-builtins": "off",
     "import/order": "warn",
-    "no-useless-escape": "off",
+    "react/react-in-jsx-scope": 0,
     "require-await": "error",
     "unused-imports/no-unused-imports": "off",
-    "unused-imports/no-unused-vars": "off",
-    "react/react-in-jsx-scope": 0,
-    "no-console": "off"
+    "unused-imports/no-unused-vars": "off"
   },
   "env": {
     "node": true,

.eslintrc

@@ -16,11 +16,13 @@
 flow-typed
 
 [lints]
-# warn on all sketchy-null checks
-sketchy-null=warn
-sketchy-number=warn
-unnecessary-optional-chain=warn
-# unused-promise=warn  # needs v0.201.0, but is not working for @jgclark
+# FIXME: all of the below seem to crash flow in VSCode
+#all=warn # warn on everything, except those specified. I don't see why this isn't working.
+#sketchy-null=warn
+#sketchy-number=warn
+#invalid-computed-prop=off
+#unnecessary-optional-chain=warn
+#unused-promise=warn  # was not working for @jgclark at v0.202
 
 [options]
 autoimports=false

.flowconfig

@@ -1,3 +1,5 @@
+# Disable/enable this script at: https://github.com/NotePlan/plugins/actions/workflows/node.js.yml
+
 # Run tests on push or pull_request
 # per: https://joelhooks.com/jest-and-github-actions/
 # also uses github-actions-reporter.js for reporting
@@ -27,8 +29,8 @@ jobs:
     runs-on: macos-latest
     strategy:
       matrix:
-        # node-version: [14.x, 16.x, 18.x, 19.x]
-        node-version: [20.x,22.x]
+        # node-version: [14.x, 16.x, 18.x, 19.x, 20.x]
+        node-version: [22.x]
         # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
 
     steps:
@@ -38,9 +40,11 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
           cache: 'npm'
+      - name: Disable optional dependencies # work around git bug on macos arm64 dependencies
+        run: export NPM_CONFIG_OPTIONAL=false
       # shoulde eventually be a clean install using: - run: npm ci --legacy-peer-deps
       # - run: npm i -g node-gyp@latest && npm config set node_gyp "/usr/local/lib/node_modules/node-gyp/bin/node-gyp.js"
-      - run: npm ci # clean install (deletes node_modules)
+      - run: npm ci --legacy-peer-deps # clean install (deletes node_modules)
       - run: npm link # necessary for some reason specific to NP dev setup
       # note: when upgrade to node 16+, add this to the following --max-old-space-size=8192 
       - run: NODE_OPTIONS=--max-old-space-size=8192 npm run test:ci # run Jest CI version and stop if errors
@@ -88,7 +92,7 @@ jobs:
           cache: 'npm'
       # shoulde eventually be a clean install using: - run: npm ci --legacy-peer-deps
       # - run: npm i -g node-gyp@latest && npm config set node_gyp "/usr/local/lib/node_modules/node-gyp/bin/node-gyp.js"
-      - run: npm ci # clean install (deletes node_modules)
+      - run: npm ci --legacy-peer-deps # clean install (deletes node_modules)
       - run: npm link # necessary for some reason specific to NP dev setup
       # note: when upgrade to node 16+, add this to the following --max-old-space-size=8192 
       - run: NODE_OPTIONS=--max-old-space-size=8192 node scripts/rollup.js -b -ci # build all plugins and stop if errors
@@ -119,4 +123,4 @@ jobs:
             "state": "failure",
             "description": "Plugins Build failed",
             "target_url": "https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
-          }'
+          }'

.github/workflows/node.js.yml

@@ -1,5 +1,5 @@
 .DS_Store
-node_modules/
+node_modules*
 dist/
 .cache/
 */ts-template/*.*
@@ -21,5 +21,5 @@ coverage/
 docs/assets/
 docs/index.html
 Documentation-Helpers
-**/*.bundle.dev.js
-**/*.bundle.min.js
+**/react.*.dev.js
+**/react.*.min.js

.gitignore

@@ -1 +0,0 @@
-jgclark.*

.prettierignore

@@ -0,0 +1,3 @@
+{
+    "semi": false
+}

.prettierrc

@@ -0,0 +1,36 @@
+# NOTEPLAN PLUGINS DEVELOPMENT GUIDE
+
+## Build/Test Commands
+- Build plugin: `npm run build <plugin-name>` or `npm run build:minified`
+- Lint code: `npm run lint` or fix issues with `npm run lint-fix`
+- Type check: `npm run typecheck`
+- Run a test: `jest <test-file> --no-watch`
+
+## Code Style Guidelines
+- Use Flow for static typing
+- No semicolons (enforced by ESLint/Prettier)
+- Single quotes for strings
+- Max line length: 180 characters
+- Use template literals instead of string concatenation
+- Use ES6+ features (const/let, arrow functions)
+- Use async/await and handle promises properly (no floating promises)
+- Follow existing naming patterns in the codebase
+- Proper error handling with try/catch blocks
+- Follow import order: external libs -> internal libs -> local files
+- Keep code DRY and modular with clear function responsibilities
+- Use JSDoc comments for public functions
+
+## Common Helper Functions
+The most frequently used functions in the codebase are:
+- Logging: logDebug, logError, clo, logInfo, logWarn
+- Note utilities: findNote, getParagraphs, getSelectedParagraphs, getTasksFromNote
+- Date handling: getTodaysDateHyphenated, getDateStringFromCalendarFilename
+- Configuration: getSettings, updateSettingsForPlugin
+- UI interaction: showMessage, showMessageYesNo, displayTitle
+
+When developing, check the helpers/ directory for existing utility functions before writing your own.
+
+For JS/TS, please provide Flow (as appropriate) and JSDOC with all responses. If you are rewriting a full file, make sure to include all import statements also. Do not remove any console.logs or comments (or logDebug, clo, logInfo, logError statements).
+
+**DO NOT EVER HARD-CODE JEST WORKAROUNDS INTO FUNCTIONS WE ARE TESTING**
+When you run jest tests, always include the flag --no-watch at the end because my jest config by default watches

.windsurfrules

@@ -0,0 +1,34 @@
+# NOTEPLAN PLUGINS DEVELOPMENT GUIDE
+
+## Build/Test Commands
+- Build plugin: `npm run build <plugin-name>` or `npm run build:minified`
+- Lint code: `npm run lint` or fix issues with `npm run lint-fix`
+- Type check: `npm run typecheck`
+- Run all tests: `npm run test`
+- Run single test: `npx jest path/to/file.test.js -t "test name"`
+- Watch tests: `npm run test:watch`
+- Development mode: `npm run dev`
+
+## Code Style Guidelines
+- Use Flow for static typing
+- No semicolons (enforced by ESLint/Prettier)
+- Single quotes for strings
+- Max line length: 180 characters
+- Use template literals instead of string concatenation
+- Use ES6+ features (const/let, arrow functions)
+- Use async/await and handle promises properly (no floating promises)
+- Follow existing naming patterns in the codebase
+- Proper error handling with try/catch blocks
+- Follow import order: external libs -> internal libs -> local files
+- Keep code DRY and modular with clear function responsibilities
+- Use JSDoc comments for public functions
+
+## Common Helper Functions
+The most frequently used functions in the codebase are:
+- Logging: logDebug, logError, clo, logInfo, logWarn
+- Note utilities: findNote, getParagraphs, getSelectedParagraphs, getTasksFromNote
+- Date handling: getTodaysDateHyphenated, getDateStringFromCalendarFilename
+- Configuration: getSettings, updateSettingsForPlugin
+- UI interaction: showMessage, showMessageYesNo, displayTitle
+
+When developing, check the helpers/ directory for existing utility functions before writing your own.