Hook up addTaskToNote()

Author: jgclark

.cursor/rules/np-programming-general.mdc

@@ -16,7 +16,7 @@ CRITICAL: Never use dynamic imports. Rollup will not process them correctly. Alw
 - Use async/await and handle promises properly (no floating promises)
 - Follow existing naming patterns in the codebase
 - Proper error handling with try/catch blocks
-- Follow import order: external libs -> internal libs -> local files
+- Follow import order: external libs -> internal libs -> local files. Within that put in alphabetical order of source filename.
 - Keep code DRY and modular with clear function responsibilities
 - Add JSDoc comments for all functions
 - Always research the `helpers/` folder before writing new code

jgclark.Dashboard/CHANGELOG.md

@@ -9,6 +9,10 @@ For more details see the [plugin's documentation](https://github.com/NotePlan/pl
 - TODO: fix isNoteFromAllowedFolder() for teamspace or possibly 2025-W21.md
 -->
 
+## [2.4.0.b19] 2026-01-25
+- finish hooking up addTaskToNote
+- dev: refactor getOpenItemParasForTimePeriod() and add tests to the new smaller functions.
+
 ## [2.4.0.b18] 2026-01-24
 ### New
 - New Section "Active Projects", which shows a list of all the currently-active projects from the separate Project & Reviews plugin. This includes any currently open projects (i.e. not completed, cancelled or paused) that match its settings, or are included in the current Perspective, if that option is set.  It's designed to complement the existing Projects Section. It also shows the first of any 'Next Actions' as defined by the settings in the Projects plugin.

jgclark.Dashboard/plugin.json

@@ -8,7 +8,7 @@
   "plugin.description": "A Dashboard for NotePlan, that in one place shows:\n- a compact list of open tasks and checklists from today's note\n- scheduled open tasks and checklists from other notes.\n- similarly for yesterday's note, tomorrow's note, and the weekly, monthly and quarterly notes too (if used)\n- all overdue tasks\n- all open tasks and checklists that contain particular @tags or #mentions of your choosing\n- the next notes ready to review (if you use the 'Projects and Reviews' plugin).\nIt includes many other ways of speeding up managing your tasks: see the website for more details.",
   "plugin.author": "@jgclark",
   "plugin.comment": "TODO: On full release, change minAppVersion down to 3.7?",
-  "plugin.version": "2.4.0.b18",
+  "plugin.version": "2.4.0.b19",
   "plugin.releaseStatus": "beta",
   "plugin.hidden": false,
   "plugin.lastUpdateInfo": "2.4.0: new 'Spaces to Include' setting which controls which (Team)Spaces you wish to include, plus whether or not to include the Private 'Space' (all notes not in a Space)\n2.3.3: new 'Year' section available.\n2.3.2: fix display when there are no priority items shown.\n2.3.1: fix for possible loss of settings error when upgrading.\n2.3.0: Support for NotePlan (Team)Spaces. Can re-order display of Sections.New '/backupSettings' command. Added 'noteTags' feature. Speeded up Tag/Mention sections. Layout improvements. Lots of other small fixes and improvements.\n2.2.1: Add new sorting option for Tag and Overdue sections.\n2.2.0: Add 'Search' section. New keyboard shortcuts. Plus many small improvements, bug fixes and performance improvements. See documentation for details.\n2.1.10: More move-under-heading options. Bug fixes and performance improvements.\n2.1.9: performance improvements and better UI for iPhone users.\n2.1.8: various fixes and small improvements.\n2.1.7: various fixes and small improvements.\n2.1.6: allow all current timeblocks to be shown, not just the first. Add new @repeat()s if using the extended syntax from the Repeat Extensions plugin. Bug fixes.\n2.1.5: fixes to time blocks and scheduling items.\n2.1.4: fix to Interactive Processing, and Edit All Perspectives dialog now shows unsaved changes.",

jgclark.Dashboard/src/react/components/Header/AddToAnyNote.jsx

@@ -5,10 +5,10 @@
 
 import React, { useState, useCallback, useMemo, useEffect, useRef } from 'react'
 import { useAppContext } from '../AppContext.jsx'
+import { logTimer } from '@helpers/dev'
 import DynamicDialog, { type TSettingItem } from '@helpers/react/DynamicDialog/DynamicDialog'
 import type { NoteOption } from '@helpers/react/DynamicDialog/NoteChooser'
 import { logDebug, logError } from '@helpers/react/reactDev.js'
-import { logTimer } from '@helpers/dev'
 import { getElementCoordinates } from '@helpers/react/reactUtils.js'
 import './AddToAnyNote.css' // Import CSS for dialog positioning
 
@@ -23,8 +23,7 @@ type Props = {
  * @param {Props} props
  * @returns {React$Node}
  */
-const AddToAnyNote = React.memo(
-  ({ sendActionToPlugin }: Props): React$Node => {
+const AddToAnyNoteComponent = ({ sendActionToPlugin }: Props): React$Node => {
     const { dispatch } = useAppContext()
     // ----------------------------------------------------------------------
     // State
@@ -105,7 +104,14 @@ const AddToAnyNote = React.memo(
               pendingRequestsRef.current.delete(correlationId)
               clearTimeout(pending.timeoutId)
               if (success) {
-                pending.resolve(data)
+                // Resolve with full payload so caller can access success, message (via error field), and data
+                // Note: The payload structure is { correlationId, success, data, error }
+                // We reconstruct the RequestResponse object for the caller
+                pending.resolve({
+                  success: true,
+                  message: error || undefined, // error field contains the message when success=true
+                  data: data,
+                })
               } else {
                 pending.reject(new Error(error || 'Request failed'))
               }
@@ -647,13 +653,17 @@ const AddToAnyNote = React.memo(
         )}
       </>
     )
-  },
-  (prevProps, nextProps) => {
-    // Custom comparison: only re-render if sendActionToPlugin reference changes
-    // This prevents re-renders when parent re-renders but props haven't changed
-    return prevProps.sendActionToPlugin === nextProps.sendActionToPlugin
-  },
-)
+}
+
+// Custom comparison function for memoization
+const arePropsEqual = (prevProps: Props, nextProps: Props): boolean => {
+  // Only re-render if sendActionToPlugin reference changes
+  // This prevents re-renders when parent re-renders but props haven't changed
+  return prevProps.sendActionToPlugin === nextProps.sendActionToPlugin
+}
+
+// Memoize the component with custom comparison function
+const AddToAnyNote: React$ComponentType<Props> = React.memo(AddToAnyNoteComponent, arePropsEqual)
 
 AddToAnyNote.displayName = 'AddToAnyNote'
 

jgclark.Dashboard/src/requestHandlers/addTaskToNote.js

@@ -2,10 +2,15 @@
 //--------------------------------------------------------------------------
 // Request Handler: addTaskToNote
 // Adds a task to a specified note
+// Last updated 2026-01-25 for v2.4.0.b19 by @jgclark
 //--------------------------------------------------------------------------
 
-import pluginJson from '../../plugin.json'
+import { getDashboardSettings } from '../dashboardHelpers'
+import { isValidCalendarNoteFilename, convertISOToYYYYMMDD, isDailyDateStr } from '@helpers/dateTime'
 import { logDebug, logError } from '@helpers/dev'
+import { coreAddTaskToNoteHeading } from '@helpers/NPAddItems'
+import { getNoteFromFilename } from '@helpers/NPnote'
+import { processChosenHeading } from '@helpers/userInput'
 
 // RequestResponse type definition
 export type RequestResponse = {
@@ -16,43 +21,108 @@ export type RequestResponse = {
 
 /**
  * Add a task to a specified note
- * TODO(@jgclark): Implement actual task adding logic here
- * This could call doAddItem or similar function from clickHandlers
- *
  * @param {Object} params - Request parameters
  * @param {string} params.filename - Filename of the note to add the task to
  * @param {string} params.taskText - The task text to add
  * @param {string?} params.heading - Optional heading to add the task under
- * @param {string?} params.space - Optional space ID (for teamspace notes)
+ * @param {string?} params.space - Optional space ID (empty string for Private, teamspace ID for teamspace notes)
  * @param {Object} pluginJson - Plugin JSON object for logging
  * @returns {RequestResponse}
  */
-export function addTaskToNote(params: { filename: string, taskText: string, heading?: ?string, space?: ?string }, pluginJson: any): RequestResponse {
+export async function addTaskToNote(params: { filename: string, taskText: string, heading?: ?string, space?: ?string }, pluginJson: any): Promise<RequestResponse> {
   try {
     const { filename, taskText, heading, space } = params
     logDebug('Dashboard/requestHandlers] addTaskToNote', `Starting with filename="${filename}", taskText="${taskText}", heading="${heading || 'none'}", space="${space || 'private'}"`)
 
-    // TODO(@jgclark): Implement actual task adding logic here
-    // This could call doAddItem or similar function from clickHandlers
-    // Or import some code from /qath or something else -- you know best
+    // Validate inputs
+    if (!filename || !taskText || !taskText.trim()) {
+      return {
+        success: false,
+        message: 'Filename and task text are required',
+        data: null,
+      }
+    }
+
+    // Normalize filename: convert ISO date format (YYYY-MM-DD) to NotePlan format (YYYYMMDD) if needed
+    // Check if filename (without extension) is a daily date string in ISO format
+    const filenameWithoutExt = filename.replace(/\.(md|txt)$/, '')
+    let normalizedFilename = filename
+    if (isDailyDateStr(filenameWithoutExt)) {
+      // Convert ISO format to NotePlan format for calendar notes
+      const convertedDate = convertISOToYYYYMMDD(filenameWithoutExt)
+      if (convertedDate !== filenameWithoutExt) {
+        // Conversion happened - reconstruct filename with NotePlan format
+        const ext = filename.match(/\.(md|txt)$/)?.[0] || '.md'
+        normalizedFilename = `${convertedDate}${ext}`
+        logDebug('[Dashboard/requestHandlers] addTaskToNote', `Converted ISO date filename "${filename}" to NotePlan format "${normalizedFilename}"`)
+      }
+    }
+
+    // Get dashboard settings for heading configuration
+    const config = await getDashboardSettings()
+    if (!config) {
+      return {
+        success: false,
+        message: 'Failed to load dashboard settings',
+        data: null,
+      }
+    }
+
+    // Get the note - handle teamspace notes if space is provided
+    let destNote = null
+    if (space && space !== '' && space !== 'Private') {
+      // Teamspace note - use DataStore APIs with teamspace ID
+      const isCalendarNote = isValidCalendarNoteFilename(normalizedFilename)
+      if (isCalendarNote) {
+        // Extract date string from normalized filename (without extension) for calendarNoteByDateString
+        const dateStr = normalizedFilename.replace(/\.(md|txt)$/, '')
+        // calendarNoteByDateString accepts both ISO (YYYY-MM-DD) and NotePlan (YYYYMMDD) formats,
+        // but we've normalized to NotePlan format, so use that
+        destNote = DataStore.calendarNoteByDateString(dateStr, space)
+      } else {
+        destNote = DataStore.noteByFilename(normalizedFilename, 'Notes', space)
+      }
+    } else {
+      // Private note - use getNoteFromFilename helper which handles both regular and calendar notes
+      // getNoteFromFilename should handle ISO format conversion internally, but we'll use normalized filename for consistency
+      destNote = getNoteFromFilename(normalizedFilename)
+    }
+
+    if (!destNote) {
+      return {
+        success: false,
+        message: `Unable to locate note: ${filename}${space && space !== '' && space !== 'Private' ? ` in teamspace ${space}` : ''}`,
+        data: null,
+      }
+    }
+
+    // Process heading if provided, otherwise use default from config
+    const newHeadingLevel = config.newTaskSectionHeadingLevel || 2
+    const headingToUse = heading
+      ? await processChosenHeading(destNote, heading, newHeadingLevel)
+      : config.newTaskSectionHeading || ''
 
-    // you may want to trigger a refresh of the appropriate section before returning a value
+    // Add the task to the note
+    // logDebug('[Dashboard/requestHandlers] addTaskToNote', `Adding task to note: "${destNote?.title || '?'}" with heading: "${headingToUse}"`)
+    const resultingPara = coreAddTaskToNoteHeading(destNote, headingToUse, taskText.trim(), newHeadingLevel, true)
+    // logDebug('[Dashboard/requestHandlers] addTaskToNote', `Resulting paragraph: "${resultingPara?.rawContent || '?'}"`)
+
+    if (!resultingPara) {
+      return {
+        success: false,
+        message: 'Failed to add task to note',
+        data: null,
+      }
+    }
 
-    // For now, returning a message indicating it's not implemented yet, with the data so @jgclark knows what to implement
+    logDebug('Dashboard/requestHandlers] addTaskToNote', `Successfully added task "${taskText}" to note "${filename}" under heading "${headingToUse || 'default'}"`)
     return {
-      success: false,
-      message: `⚠️ This request was sent to the backend but needs @jgclark to implement it in the new addTaskToNote() request handler. Data received:\n${JSON.stringify({
-        filename,
-        taskText,
-        heading: heading || null,
-        space: space || null,
-      })}`,
-      // Sending the data field back may not be strictly necessary unless you want to do an optomistic update
-      // Just here as an example
+      success: true,
+      message: `Task added successfully to ${destNote.title || filename}`,
       data: {
         filename,
         taskText,
-        heading: heading || null,
+        heading: headingToUse || null,
         space: space || null,
       },
     }