Skip to content

Commit 4925d29

Browse files
committed
Add warnings if usersVersionHas() fails, or called with unsupported check string
1 parent 8a11efa commit 4925d29

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

helpers/NPVersions.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// Version-related helper functions for NotePlan plugins
44
//-------------------------------------------------------------------------------
55

6-
import { clo, JSP, logError, logDebug } from './dev'
6+
import { clo, JSP, logError, logDebug, logWarn } from './dev'
77
import { semverVersionToNumber } from './utils'
88

99
/**
@@ -14,7 +14,7 @@ import { semverVersionToNumber } from './utils'
1414
export function usersVersionHas(feature: string): boolean {
1515
logDebug('usersVersionHas', `NotePlan v${NotePlan.environment.version}`)
1616
// Note: this ignores any non-numeric, non-period characters (e.g., "-beta3")
17-
const userVersionNumber:number = semverVersionToNumber(NotePlan.environment.version) || 0
17+
const userVersionNumber: number = semverVersionToNumber(NotePlan.environment.version) || 0
1818
// logDebug('usersVersionHas', `userVersionNumber: ${String(userVersionNumber)}`)
1919

2020
function v(input: string): number { return semverVersionToNumber(input) }
@@ -34,6 +34,10 @@ export function usersVersionHas(feature: string): boolean {
3434
mainSidebarControl: userVersionNumber >= v("3.19.2"), // Nov 2025
3535
contentDeduplicator: userVersionNumber >= v("3.19.2"), // Nov 2025
3636
}
37-
// logDebug('usersVersionHas', `-> ${String(versionHas[feature] ?? false)} for ${feature}`)
37+
!versionHas[feature] &&
38+
logWarn(
39+
'usersVersionHas',
40+
`NotePlan version ${NotePlan.environment.version} (${String(userVersionNumber)}) does not have requested feature: "${feature}"; ${versionHas.hasOwnProperty(feature) ? `feature *is* listed in function usersVersionHas()` : 'feature *is not* listed in function usersVersionHas()'
41+
}. Returning false.`)
3842
return versionHas[feature] ?? false
3943
}

0 commit comments

Comments
 (0)