Stop Project List generating when its window isn't open. Added more logging around this.

Author: jgclark

helpers/NPnote.js

@@ -1097,7 +1097,6 @@ export function findNotesMatchingHashtagOrMentionFromList(
       })
     }
     if (projectNotesWithItem.length > 0) {
-      // logDebug('NPnote/findNotesMatchingHashtagOrMentionFromList',`In folder '${folder ?? '<all>'}' found ${projectNotesWithItem.length} notes matching '${tag}': [${String(projectNotesWithItem.map((a) => a.title ?? a.filename ?? '?'))}]`)
       logDebug('NPnote/findNotesMatchingHashtagOrMentionFromList', `In folder '${folder ?? '<all>'}' found ${projectNotesWithItem.length} notes matching '${item}'`)
     }
 

jgclark.Dashboard/CHANGELOG.md

@@ -10,10 +10,15 @@ For more details see the [plugin's documentation](https://github.com/NotePlan/pl
 - TODO: enlarged default window size on iPads
 -->
 
-## [2.3.0.b9] 2025-08-???
-- Added tagCache age to section info (if 'comparison' is turned on)
+## [2.3.0.b9] 2025-09-01
+- Added tagCache age to section info (if 'Comparison' FFlag is turned on)
 - Add another check to regenerate or update tagMentionCache after 24 and 1 hour respectively
 - Make 'Show folder name in note link?' setting indented under 'Show note link for tasks?'
+- I have stopped some of the unnecessary generation of Project List. Let me know how it goes, @dwertheimer. (Will require rebuilding jgclark.Reviews plugin as well (to v1.2.4).)
+- Also added some logging to track down when Project list generation is happening when it shouldn't be. If 'Show Section Timings' Flag is on, then it will also write a log to note "@Meta/Project Generation Log".
+- Fix color of blockID marker in light mode themes
+- Further fix to display of calendar events in tasks
+- Tweak some TaskDialog button labels
 
 ## [2.3.0.b8] 2025-08-27
 - Add temporary workaround for error in DataStore.listOverdueParagraphs() for regular Teamspace notes

jgclark.Dashboard/src/dataGeneration.js

@@ -79,7 +79,7 @@ export async function getSomeSectionsData(
   useEditorWherePossible: boolean,
 ): Promise<Array<TSection>> {
   try {
-    logDebug('getSomeSectionsData', `🔹Starting with ${sectionCodesToGet.toString()} ...`)
+    logDebug('getSomeSectionsData', `🔹 Starting with ${sectionCodesToGet.toString()} ...`)
     const config: TDashboardSettings = await getDashboardSettings()
 
     const sections: Array<TSection> = []
@@ -94,6 +94,7 @@ export async function getSomeSectionsData(
     if (sectionCodesToGet.includes('Q') && config.showQuarterSection) sections.push(...getThisQuarterSectionData(config, useDemoData, useEditorWherePossible))
     // moderately quick to generate
     if (sectionCodesToGet.includes('PROJ') && config.showProjectSection) {
+      logInfo('getSomeSectionsData', `🔹 Getting Project section data as part of ${sectionCodesToGet.toString()}`)
       const projectSection = await getProjectSectionData(config, useDemoData)
       if (projectSection) sections.push(projectSection)
     }

jgclark.Dashboard/src/dataGenerationProjects.js

@@ -1,7 +1,7 @@
 // @flow
 //-----------------------------------------------------------------------------
 // Generate Project section data
-// Last updated 2025-05-16 for v2.3.0
+// Last updated 2025-09-01 for v2.3.0
 //-----------------------------------------------------------------------------
 
 import { getNextProjectsToReview } from '../../jgclark.Reviews/src/allProjectsListHelpers'
@@ -13,6 +13,8 @@ import type { TDashboardSettings, TSection, TSectionItem } from './types'
 import { logDebug, logTimer, timer } from '@helpers/dev'
 import { getFolderFromFilename } from '@helpers/folders'
 import { pluginIsInstalled } from '@helpers/NPConfiguration'
+import { getOrMakeRegularNoteInFolder } from '@helpers/NPnote'
+import { smartPrependPara } from '@helpers/paragraph'
 
 /**
  * Make a Section for all projects ready for review, using data written by the Projects + Reviews plugin: getNextProjectsToReview().
@@ -67,17 +69,8 @@ export async function getProjectSectionData(config: TDashboardSettings, useDemoD
       return null
     }
     // Get all projects to review (and apply maxProjectsToShow limit later)
-    // nextProjectsToReview = await getNextProjectsToReview(maxProjectsToShow)
+    // Note: Perspective filtering is done in P+R (since it was added in v1.1)
     nextProjectsToReview = await getNextProjectsToReview()
-
-    // add basic filtering by folder for the current Perspective
-    // const filteredProjects = nextProjectsToReview.filter((p) => {
-    //   const folder = getFolderFromFilename(p.filename)
-    //   return allowedFolders.includes(folder)
-    // })
-    // For P+R v1.1 and later, Perspectives can be used, so this filtering is not needed.
-    // if (filteredProjects) {
-    //   filteredProjects.map((p) => {
     if (nextProjectsToReview) {
       nextProjectsToReview.map((p) => {
         const thisID = `${sectionNumStr}-${itemCount}`
@@ -130,5 +123,13 @@ export async function getProjectSectionData(config: TDashboardSettings, useDemoD
   }
   // console.log(JSON.stringify(section))
   logTimer('getProjectSectionData', thisStartTime, `found ${itemCount} items for ${thisSectionCode}`, 1000)
+
+  // Log the start of the generation to a special log note, if we're running. TODO: remove this later.
+  if (config?.FFlag_ShowSectionTimings) {
+    const logNote: TNote = await getOrMakeRegularNoteInFolder('Project Generation Log', '@Meta')
+    const newLogLine = `${new Date().toLocaleString()}: Dashboard -> ${nextProjectsToReview.length} Project(s) ready to review, in ${timer(thisStartTime)}`
+    smartPrependPara(logNote, newLogLine, 'list')
+  }
+
   return section
 }

jgclark.Dashboard/src/perspectiveHelpers.js

@@ -6,7 +6,7 @@
 //-----------------------------------------------------------------------------
 
 import pluginJson from '../plugin.json'
-// import { generateProjectListsAndRenderIfOpen } from '../../jgclark.Reviews/src/reviews.js'
+// import { generateProjectListsAndRenderIfOpen, renderProjectListsIfOpen } from '../../jgclark.Reviews/src/reviews.js' // produces circular dependency
 import { getDashboardSettings, getOpenItemParasForTimePeriod, setPluginData } from './dashboardHelpers.js'
 import { dashboardSettingsDefaults } from './react/support/settingsHelpers'
 import { getTagSectionDetails, showSectionSettingItems } from './react/components/Section/sectionHelpers'
@@ -17,14 +17,14 @@ import { updateTagMentionCacheDefinitionsFromAllPerspectives } from './tagMentio
 import type { TDashboardSettings, TDashboardPluginSettings, TPerspectiveDef } from './types'
 import { stringListOrArrayToArray } from '@helpers/dataManipulation'
 import { getPeriodOfNPDateStr } from '@helpers/dateTime'
-import { clo, clof, clvt, JSP, logDebug, logError, logInfo, logWarn } from '@helpers/dev'
+import { clo, clof, clvt, JSP, logDebug, logError, logInfo, logTimer, logWarn } from '@helpers/dev'
 import { getFolderFromFilename, getFoldersMatching } from '@helpers/folders'
 import { displayTitle } from '@helpers/general'
 import { allNotesSortedByChanged, getNoteByFilename } from '@helpers/note'
 import { chooseNoteV2 } from '@helpers/NPnote'
 import { getSettings, saveSettings } from '@helpers/NPConfiguration'
+import { isHTMLWindowOpen } from '@helpers/NPWindows'
 import { chooseOption, getInputTrimmed, showMessage } from '@helpers/userInput'
-
 export type TPerspectiveOptionObject = { isModified?: boolean, label: string, value: string }
 
 /* -----------------------------------------------------------------------------
@@ -469,6 +469,7 @@ export async function logPerspectiveFiltering(filenameArg?: string): Promise<voi
  */
 export async function switchToPerspective(name: string, allDefs: Array<TPerspectiveDef>): Promise<Array<TPerspectiveDef> | false> {
   try {
+    const startTime = new Date()
     // Check if perspective exists
     logDebug('switchToPerspective', `Starting looking for name ${name} in ...`)
     // logPerspectives(allDefs)
@@ -507,10 +508,20 @@ export async function switchToPerspective(name: string, allDefs: Array<TPerspect
     // )
 
     // Send message to Reviews (if that window is open) to re-generate the Projects list and render it
-    // TEST: Now not await-ing this, because it can take a long time and we don't want to block the main thread. FIXME: still taking a long time, and appears to be blocking the main thread.
-    logDebug('switchToPerspective', `Sending message to Reviews to regenerate the Projects List and render it`)
-    const _promise = DataStore.invokePluginCommandByName('generateProjectListsAndRenderIfOpen', 'jgclark.Reviews', [])
+    // TEST: Now not await-ing this, because it can take a long time and we don't want to block the main thread.
+    // FIXME: Even so, is still taking a long time, and appears to be blocking the main thread.
+    // logTimer('switchToPerspective', startTime, `Sending message to Reviews to regenerate the Projects List and render it.`)
+    // const _promise = DataStore.invokePluginCommandByName('generateProjectListsAndRenderIfOpen', 'jgclark.Reviews', [])
     // const _promise = generateProjectListsAndRenderIfOpen()
+    // logTimer('switchToPerspective', startTime, `Sending message to Reviews to regenerate the Projects List and render it.`)
+
+    // v3: Work out whether Project list window is open, and if so, re-render it
+    if (isHTMLWindowOpen('jgclark.Reviews.rich-review-list')) {
+      // TEST: still not convinced that this is firing and forgetting. At least we're not doing anything if the Project List window is not open.
+      logTimer('switchToPerspective', startTime, `Sending message to Reviews to render project list as it is open.`)
+      const _promise = DataStore.invokePluginCommandByName('renderProjectListsIfOpen', 'jgclark.Reviews', [])
+      logTimer('switchToPerspective', startTime, `Sent message to Reviews`) // Note: never seems to get here
+    }
 
     return newPerspectiveSettings
   } catch (error) {

jgclark.Reviews/plugin.json

@@ -8,8 +8,8 @@
   "plugin.author": "Jonathan Clark",
   "plugin.url": "https://github.com/NotePlan/plugins/tree/main/jgclark.Reviews",
   "plugin.changelog": "https://github.com/NotePlan/plugins/blob/main/jgclark.Reviews/CHANGELOG.md",
-  "plugin.version": "1.2.3",
-  "plugin.lastUpdateInfo": "1.2.3: bug fixes.\n.1.2.2: fix bug with 'Finish + Next' review.\n1.2.1: small improvements and bug fixes and under-the-hood changes for integration with Dashboard plugin.\n1.2.0: new settings that affect how plugin calculates % completion for a project.\n1.1.2: fix bug with 'next action' setting.\n1.1.1: turn off background refresh of Dashboard plugin after every change to Project List, as it was causing problems.\n1.1.0: new option to use current 'Perspective' from the Dashboard plugin. New simpler top bar. Other small improvements and fixes.\n1.0.2: theme font size can now be overriden by user setting in NP.\n1.0.1: fix bug with 'next action' setting.\n1.0.0: new 'next action' functionality. New display toggles, and keyboard shortcuts. Much faster. Bug fixes. Lots of under-the-hood changes.\n0.14.1: new 'Remove due dates when pausing a project?' option. Other small improvements and fixes.\n0.14.0: add edit buttons to Rich output. Other small improvements and fixes.\n0.13.2: clarified the 'include' and 'exclude' folder settings. Fixed bug about project notes in root folder always displaying.\n0.13.1: change review list to show 'due' not just 'overdue' (i.e. include items ready to review today.)",
+  "plugin.version": "1.2.4",
+  "plugin.lastUpdateInfo": "1.2.4: TEST: to try and fix things in Dashboard.\n1.2.3: bug fixes.\n.1.2.2: fix bug with 'Finish + Next' review.\n1.2.1: small improvements and bug fixes and under-the-hood changes for integration with Dashboard plugin.\n1.2.0: new settings that affect how plugin calculates % completion for a project.\n1.1.2: fix bug with 'next action' setting.\n1.1.1: turn off background refresh of Dashboard plugin after every change to Project List, as it was causing problems.\n1.1.0: new option to use current 'Perspective' from the Dashboard plugin. New simpler top bar. Other small improvements and fixes.\n1.0.2: theme font size can now be overriden by user setting in NP.\n1.0.1: fix bug with 'next action' setting.\n1.0.0: new 'next action' functionality. New display toggles, and keyboard shortcuts. Much faster. Bug fixes. Lots of under-the-hood changes.\n0.14.1: new 'Remove due dates when pausing a project?' option. Other small improvements and fixes.\n0.14.0: add edit buttons to Rich output. Other small improvements and fixes.\n0.13.2: clarified the 'include' and 'exclude' folder settings. Fixed bug about project notes in root folder always displaying.\n0.13.1: change review list to show 'due' not just 'overdue' (i.e. include items ready to review today.)",
   "plugin.dependsOn": [
     {
       "id": "np.Shared",
@@ -208,9 +208,20 @@
     },
     {
       "hidden": true,
-      "name": "test:renderProjectLists",
+      "name": "renderProjectLists",
       "description": "render current allProjects list in current style(s)",
-      "jsFunction": "renderProjectLists"
+      "jsFunction": "renderProjectLists",
+      "arguments": [
+        "config",
+        "shouldOpen window/note if not already open? (optional, default: true)",
+        "scroll position to set (pixels) for HTML display (optional, default: 0)"
+      ]
+    },
+    {
+      "hidden": true,
+      "name": "renderProjectListsIfOpen",
+      "description": "render current allProjects list in current style(s) if already open",
+      "jsFunction": "renderProjectListsIfOpen"
     }
   ],
   "plugin.inactiveCommands": [