Remove joker lap-related itempolicy stuff

Author: Nomagno

data/gui/dialogs/online/item_policy_dialog.stkgui

@@ -208,17 +208,6 @@
                         <label word_wrap="true" id="forbid-nitro-label" proportion="3" text="Forbid nitro?" text_align="left" />
                         <checkbox id="forbid-nitro-checkbox" proportion="1" />
                     </div>
-
-                    <div width="100%" height="fit" layout="horizontal-row">
-                        <label word_wrap="true" id="joker-laps-override-label" proportion="9" text="Joker laps override" text_align="left" />
-                        <checkbox id="joker-laps-override-checkbox" proportion="1" />
-                    </div>
-
-                    <div width="100%" height="fit" layout="horizontal-row">
-                        <label word_wrap="true" id="joker-laps-min-max-label" proportion="3" text="Joker laps min/max (WIP USELESS)" text_align="left" />
-                        <spinner id="joker-laps-min-spinner" proportion="3" wrap_around="false" />
-                        <spinner id="joker-laps-max-spinner" proportion="3" wrap_around="false" />
-                    </div>
             </div>
 
 

src/race/item_policy.hpp

@@ -78,8 +78,7 @@ enum ItemPolicyRules {
     // The "virtual pace car" procedure will let all karts fully unlap.
     IPT_UNLAPPING  =  1 << 11,
 
-    // Joker laps (min and mass passes of all volumes) will be overridden from default lap-multiplied integer.
-    IPT_JOKER_OVERRIDE  =  1 << 12,
+    IPT_UNUSED  =  1 << 12,
 
     // Bonus boxes will instead have their powerup pool draw from the item policy section's current one, rather than the one in powerup.xml.
     IPT_BONUS_BOX_OVERRIDE  =  1 << 13,

src/states_screens/dialogs/item_policy_dialog.cpp

@@ -328,7 +328,6 @@ void ItemPolicyDialog::computePolicyFromGUI() {
     SETRULE(CHECKBOX("forbid-bananas")->getState(), IPT_FORBID_BANANA);
     SETRULE(CHECKBOX("forbid-gifts")->getState(), IPT_FORBID_BONUSBOX);
     SETRULE(CHECKBOX("forbid-nitro")->getState(), IPT_FORBID_NITRO);
-    SETRULE(CHECKBOX("joker-laps-override")->getState(), IPT_JOKER_OVERRIDE);
 
     READ_TEXTBOX_FLOAT(cs->m_virtual_pace_gaps, "pace-car-intervals");
 
@@ -438,8 +437,6 @@ void ItemPolicyDialog::setGUIFromPolicy(){
     SET_CHECKBOX_RULE("forbid-bananas", IPT_FORBID_BANANA);
     SET_CHECKBOX_RULE("forbid-gifts", IPT_FORBID_BONUSBOX);
     SET_CHECKBOX_RULE("forbid-nitro", IPT_FORBID_NITRO);
-    SET_CHECKBOX_RULE("joker-laps-override", IPT_JOKER_OVERRIDE);
-    //TODO: joker laps override min and max spinners are useless rn
 
     SET_TEXTBOX_FLOAT(cs->m_virtual_pace_gaps, "pace-car-intervals");
 
@@ -545,13 +542,6 @@ void ItemPolicyDialog::setVisibilityOfRulesTab(bool visible) {
 
     LABEL("forbid-nitro")->setVisible(visible);
     CHECKBOX("forbid-nitro")->setVisible(visible);
-
-    LABEL("joker-laps-override")->setVisible(visible);
-    CHECKBOX("joker-laps-override")->setVisible(visible);
-
-    LABEL("joker-laps-min-max")->setVisible(visible);
-    SPINNER("joker-laps-min")->setVisible(visible);
-    SPINNER("joker-laps-max")->setVisible(visible);
 }
 
 void ItemPolicyDialog::setVisibilityOfFuelAndTyresTab(bool visible) {