Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: python3Packages.hikari #353691

Closed
Shawn8901 opened this issue Nov 4, 2024 · 3 comments
Closed

Build failure: python3Packages.hikari #353691

Shawn8901 opened this issue Nov 4, 2024 · 3 comments
Labels

Comments

@Shawn8901
Copy link
Contributor

Shawn8901 commented Nov 4, 2024

Steps To Reproduce

Steps to reproduce the behavior:

  1. get a recent master
  2. nix build .#python3Packages.hikari

Build log

See https://hydra.nixos.org/build/276680955

[...]
============================= test session starts ==============================
platform linux -- Python 3.11.10, pytest-8.3.3, pluggy-1.5.0
Using --randomly-seed=2222187566
rootdir: /build/source
configfile: pyproject.toml
plugins: asyncio-0.23.8, cov-nixpkgs-stub-1.0.0, pytest_randomly-3.13.0
asyncio: mode=Mode.STRICT
collected 3563 items                                                           
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/nix/store/bbvmyfhblj6ilf2yiik2cch5ark4imry-python3.11-pytest-8.3.3/lib/python3.11/site-packages/_pytest/main.py", line 283, in wrap_session
INTERNALERROR>     session.exitstatus = doit(config, session) or 0
INTERNALERROR>                          ^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/nix/store/bbvmyfhblj6ilf2yiik2cch5ark4imry-python3.11-pytest-8.3.3/lib/python3.11/site-packages/_pytest/main.py", line 336, in _main
INTERNALERROR>     config.hook.pytest_collection(session=session)
INTERNALERROR>   File "/nix/store/4salglmd2wxr0giw6f48qrqm15srrkzj-python3.11-pluggy-1.5.0/lib/python3.11/site-packages/pluggy/_hooks.py", line 513, in __call__
INTERNALERROR>     return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/nix/store/4salglmd2wxr0giw6f48qrqm15srrkzj-python3.11-pluggy-1.5.0/lib/python3.11/site-packages/pluggy/_manager.py", line 120, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/nix/store/4salglmd2wxr0giw6f48qrqm15srrkzj-python3.11-pluggy-1.5.0/lib/python3.11/site-packages/pluggy/_callers.py", line 139, in _multicall
INTERNALERROR>     raise exception.with_traceback(exception.__traceback__)
INTERNALERROR>   File "/nix/store/4salglmd2wxr0giw6f48qrqm15srrkzj-python3.11-pluggy-1.5.0/lib/python3.11/site-packages/pluggy/_callers.py", line 122, in _multicall
INTERNALERROR>     teardown.throw(exception)  # type: ignore[union-attr]
INTERNALERROR>     ^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/nix/store/bbvmyfhblj6ilf2yiik2cch5ark4imry-python3.11-pytest-8.3.3/lib/python3.11/site-packages/_pytest/logging.py", line 790, in pytest_collection
INTERNALERROR>     return (yield)
INTERNALERROR>             ^^^^^
INTERNALERROR>   File "/nix/store/4salglmd2wxr0giw6f48qrqm15srrkzj-python3.11-pluggy-1.5.0/lib/python3.11/site-packages/pluggy/_callers.py", line 122, in _multicall
INTERNALERROR>     teardown.throw(exception)  # type: ignore[union-attr]
INTERNALERROR>     ^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/nix/store/bbvmyfhblj6ilf2yiik2cch5ark4imry-python3.11-pytest-8.3.3/lib/python3.11/site-packages/_pytest/warnings.py", line 121, in pytest_collection
INTERNALERROR>     return (yield)
INTERNALERROR>             ^^^^^
INTERNALERROR>   File "/nix/store/4salglmd2wxr0giw6f48qrqm15srrkzj-python3.11-pluggy-1.5.0/lib/python3.11/site-packages/pluggy/_callers.py", line 124, in _multicall
INTERNALERROR>     teardown.send(result)  # type: ignore[union-attr]
INTERNALERROR>     ^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/nix/store/bbvmyfhblj6ilf2yiik2cch5ark4imry-python3.11-pytest-8.3.3/lib/python3.11/site-packages/_pytest/config/__init__.py", line 1419, in pytest_collection
INTERNALERROR>     self._validate_config_options()
INTERNALERROR>   File "/nix/store/bbvmyfhblj6ilf2yiik2cch5ark4imry-python3.11-pytest-8.3.3/lib/python3.11/site-packages/_pytest/config/__init__.py", line 1441, in _validate_config_options
INTERNALERROR>     self._warn_or_fail_if_strict(f"Unknown config option: {key}\n")
INTERNALERROR>   File "/nix/store/bbvmyfhblj6ilf2yiik2cch5ark4imry-python3.11-pytest-8.3.3/lib/python3.11/site-packages/_pytest/config/__init__.py", line 1480, in _warn_or_fail_if_strict
INTERNALERROR>     self.issue_config_time_warning(PytestConfigWarning(message), stacklevel=3)
INTERNALERROR>   File "/nix/store/bbvmyfhblj6ilf2yiik2cch5ark4imry-python3.11-pytest-8.3.3/lib/python3.11/site-packages/_pytest/config/__init__.py", line 1532, in issue_config_time_warning
INTERNALERROR>     warnings.warn(warning, stacklevel=stacklevel)
INTERNALERROR>   File "/build/source/tests/hikari/__init__.py", line 80, in warn
INTERNALERROR>     _warn(*args, **kwargs)
INTERNALERROR> pytest.PytestConfigWarning: Unknown config option: asyncio_default_fixture_loop_scope

Additional context

Add any other context about the problem here.

Notify maintainers

@tomodachi94 @Sigmanificient

Metadata


Add a 👍 reaction to issues you find important.

@Shawn8901 Shawn8901 added the 0.kind: build failure A package fails to build label Nov 4, 2024
@Shawn8901
Copy link
Contributor Author

FYI: As workaround i applied Shawn8901@4c492aa on my fork, tho that is not new and i am absolutely not sure why it now break.

@Shawn8901
Copy link
Contributor Author

i noticed that it never built since it was bumped from 2.0.0-dev to 2.1.0 (which is the tag that included the commit adding the option). As no one else was willing to dig deeper or raise a PR, i stepped now into place, as ZH fail time windows will end soon and i would like not having hikari marked as broken.

@tomodachi94
Copy link
Member

Fixed by #355886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants