Skip to content

Commit f91f34a

Browse files
committed
bdwgc 8.2.4 has sp_corrector
> Support client-defined stack pointer adjustment before thread stack push -- https://github.com/ivmai/bdwgc/releases/tag/v8.2.4 This fixes an inaccuracy in cc6f315, in the update to Nixpkgs 24.05 #10835 After this fixup, the build log won't ask for an upgrade, and we'll be able to collect when a coroutine exists, e.g. during filterSource.
1 parent 0a09597 commit f91f34a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/libexpr/eval.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ void initGC()
354354
// TODO: Remove __APPLE__ condition.
355355
// Comment suggests an implementation that works on darwin and windows
356356
// https://github.com/ivmai/bdwgc/issues/362#issuecomment-1936672196
357-
#if GC_VERSION_MAJOR >= 8 && GC_VERSION_MINOR >= 4 && !defined(__APPLE__)
357+
#if GC_VERSION_MAJOR >= 8 && GC_VERSION_MINOR >= 2 && GC_VERSION_MICRO >= 4 && !defined(__APPLE__)
358358
GC_set_sp_corrector(&fixupBoehmStackPointer);
359359

360360
if (!GC_get_sp_corrector()) {
@@ -365,7 +365,7 @@ void initGC()
365365
};
366366
}
367367
#else
368-
#warning "BoehmGC version does not support GC while coroutine exists. GC will be disabled inside coroutines. Consider updating bdw-gc to 8.4 or later."
368+
#warning "BoehmGC version does not support GC while coroutine exists. GC will be disabled inside coroutines. Consider updating bdw-gc to 8.2.4 or later."
369369
#endif
370370

371371

0 commit comments

Comments
 (0)