From 690a6314dfff40e30048fe1b1cf6389b95774b82 Mon Sep 17 00:00:00 2001 From: Bjarne Fyrstenborg Date: Wed, 11 Aug 2021 08:20:54 +0200 Subject: [PATCH] Remove requirement to specify icon class in umb-icon directive (#10805) * Wrap legacy font icon so we can inherit font from parent element * Remove icon name from class attributes * Add back class as color is part of icon * Replace icon classes * Replace icon class * Use umb-icon * Remove icon classes * Remove icon classes * Update color for SVG icons * Inherit animation * Add icon add class to SVG as well * Update umb-icon inner wrapper * Fix issue with search icon styling in property editors dialog * Formatting * Adjust umb-icon with transclude * Change back to original back icon from font awesome * Adjust styling for font icon * Replace with umb-icon * Use umb-icon in packager * Use umb-icon in help drawer * Use umb-icon in treesource prevalue editor * Update font size * Replace with umb-icon * Replace icons with umb-icon * div isn't valid inside label element * Replace more icons * Use umb-search-filter component * Update to use umb-icon * Use end-closing tag for custom HTML element * Use umb-icon component * Use umb-icon component to replace icons * Replace with umb-icon * Replace icons with umb-icon * Replace more icons * Custom HTML element should have end-closing tag * Replace icons with umb-icon * Replace icons * Remove unused variable * Replace icon * Replace icons * Revert to `` element as it was causing issues with isolated scopes * Adjust umb-checkmark to work with umb-icon * Adjust lightbox styling * Remove unused helper class and it is already available as "self-center" in _flexbox.less * remove unused class from icon, shift margin to parent element Co-authored-by: Nathan Woulfe --- .../components/umbconfirmaction.directive.js | 2 +- .../components/umbicon.directive.js | 6 +- .../src/less/components/umb-icon.less | 31 +++-- .../src/less/components/umb-lightbox.less | 118 +++++++++--------- .../components/umb-package-local-install.less | 15 +-- .../src/less/components/umb-packages.less | 51 ++++---- .../src/less/components/umb-panel-group.less | 2 +- .../less/components/umb-search-filter.less | 2 +- .../src/less/dashboards/healthcheck.less | 20 +-- src/Umbraco.Web.UI.Client/src/less/navs.less | 17 +-- .../src/views/common/drawers/help/help.html | 13 +- .../compositions/compositions.html | 12 +- .../datatypeconfigurationpicker.html | 4 +- .../datatypepicker/datatypepicker.html | 6 +- .../datatypesettings/datatypesettings.html | 2 +- .../iconpicker/iconpicker.html | 2 +- .../itempicker/itempicker.html | 23 ++-- .../macroparameterpicker.html | 4 +- .../macropicker/macropicker.html | 2 +- .../mediaentryeditor/mediaentryeditor.html | 14 ++- .../mediapicker/mediapicker.html | 2 +- .../propertysettings/propertysettings.html | 16 +-- .../querybuilder/querybuilder.html | 6 +- .../sectionpicker/sectionpicker.html | 5 +- .../templatesections/templatesections.html | 34 ++--- .../treepicker/treepicker.html | 2 +- .../usergrouppicker/usergrouppicker.html | 2 +- .../overlays/itempicker/itempicker.html | 8 +- .../src/views/common/overlays/user/user.html | 7 +- .../application/umb-app-header.html | 4 +- .../application/umb-contextmenu.html | 6 +- .../components/application/umb-login.html | 2 +- .../application/umb-navigation.html | 2 +- .../components/application/umb-search.html | 4 +- .../application/umbtour/umb-tour-step.html | 2 +- .../components/blockcard/umb-block-card.html | 1 - .../views/components/buttons/umb-button.html | 10 +- .../views/components/buttons/umb-toggle.html | 4 +- .../content/umb-content-node-info.html | 4 +- .../content/umb-variant-content.html | 2 +- .../editor/umb-editor-content-header.html | 17 ++- .../components/editor/umb-editor-header.html | 10 +- .../components/editor/umb-editor-menu.html | 2 +- .../editor/umb-editor-navigation-item.html | 2 +- .../views/components/forms/umb-checkbox.html | 4 +- .../components/forms/umb-radiobutton.html | 2 +- .../components/forms/umb-search-filter.html | 2 +- .../components/imaging/umb-image-crop.html | 6 +- .../components/media/umb-media-node-info.html | 8 +- .../components/mediacard/umb-media-card.html | 4 +- .../components/overlays/umb-overlay.html | 14 ++- .../property/umb-property-actions.html | 2 +- .../components/tags/umb-tags-editor.html | 6 +- .../views/components/tree/umb-tree-item.html | 2 +- .../components/tree/umb-tree-search-box.html | 2 +- .../tree/umb-tree-search-results.html | 2 +- .../src/views/components/tree/umb-tree.html | 4 +- .../src/views/components/umb-checkmark.html | 4 +- .../views/components/umb-child-selector.html | 6 +- .../views/components/umb-color-swatches.html | 6 +- .../views/components/umb-confirm-action.html | 24 ++-- .../views/components/umb-content-grid.html | 2 +- .../components/umb-date-time-picker.html | 4 +- .../src/views/components/umb-file-icon.html | 2 +- .../src/views/components/umb-folder-grid.html | 2 +- .../views/components/umb-grid-selector.html | 8 +- .../views/components/umb-groups-builder.html | 32 ++--- .../src/views/components/umb-icon.html | 8 +- .../views/components/umb-layout-selector.html | 4 +- .../src/views/components/umb-lightbox.html | 7 +- .../components/umb-list-view-settings.html | 4 +- .../views/components/umb-locked-field.html | 4 +- .../src/views/components/umb-media-grid.html | 14 ++- .../views/components/umb-mini-list-view.html | 10 +- .../src/views/components/umb-mini-search.html | 2 +- .../views/components/umb-node-preview.html | 2 +- .../src/views/components/umb-table.html | 4 +- .../components/upload/umb-file-dropzone.html | 10 +- .../upload/umb-property-file-upload.html | 4 +- .../users/umb-user-group-preview.html | 2 +- .../src/views/content/create.html | 8 +- .../src/views/content/overlays/schedule.html | 8 +- .../src/views/content/rights.html | 2 +- .../src/views/content/sort.html | 16 +-- .../src/views/contentblueprints/create.html | 6 +- .../views/dashboard/content/redirecturls.html | 2 +- .../dashboard/forms/formsdashboardintro.html | 2 +- .../dashboard/settings/examinemanagement.html | 9 +- .../views/dashboard/settings/healthcheck.html | 16 +-- .../src/views/datatypes/create.html | 4 +- .../datatypes/datatype.delete.controller.js | 1 - .../src/views/datatypes/delete.html | 42 ++++++- .../views/datatypes/views/datatype.info.html | 6 +- .../src/views/dictionary/list.html | 5 +- .../src/views/documenttypes/create.html | 10 +- .../src/views/documenttypes/delete.html | 2 +- .../src/views/documenttypes/property.html | 4 +- .../src/views/languages/overview.html | 2 +- .../src/views/logviewer/overview.html | 4 +- .../src/views/logviewer/search.html | 22 ++-- .../macros/infiniteeditors/parameter.html | 2 +- .../src/views/macros/views/parameters.html | 2 +- .../src/views/media/create.html | 2 +- .../src/views/media/sort.html | 16 +-- .../src/views/mediatypes/create.html | 4 +- .../src/views/mediatypes/delete.html | 2 +- .../src/views/member/create.html | 2 +- .../src/views/membertypes/create.html | 7 +- .../src/views/membertypes/delete.html | 2 +- .../src/views/packages/edit.html | 6 +- .../src/views/packages/views/created.html | 2 +- .../views/packages/views/install-local.html | 12 +- .../src/views/packages/views/installed.html | 6 +- .../src/views/packages/views/repo.html | 12 +- .../src/views/partialviewmacros/create.html | 10 +- .../src/views/partialviews/create.html | 8 +- .../views/prevalueeditors/imagepicker.html | 4 +- .../prevalueeditors/mediafolderpicker.html | 6 +- .../views/prevalueeditors/multivalues.html | 2 +- .../src/views/prevalueeditors/treesource.html | 6 +- .../inlineblock/inlineblock.editor.html | 2 +- .../labelblock/labelblock.editor.html | 2 +- .../unsupportedblock.editor.html | 2 +- .../blocklist.blockconfiguration.html | 13 +- .../blocklist.blockconfiguration.overlay.html | 12 +- .../umb-block-list-property-editor.html | 19 ++- .../blocklist/umb-block-list-row.html | 6 +- .../colorpicker/colorpicker.prevalues.html | 2 +- .../datepicker/datepicker.html | 4 +- .../grid/dialogs/layoutconfig.html | 15 ++- .../grid/dialogs/rowconfig.html | 18 +-- .../propertyeditors/grid/editors/embed.html | 2 +- .../propertyeditors/grid/editors/macro.html | 2 +- .../propertyeditors/grid/editors/media.html | 2 +- .../src/views/propertyeditors/grid/grid.html | 27 ++-- .../propertyeditors/grid/grid.prevalues.html | 20 +-- .../imagecropper/imagecropper.html | 2 +- .../imagecropper/imagecropper.prevalues.html | 2 +- .../listview/includeproperties.prevalues.html | 4 +- .../listview/layouts.prevalues.html | 6 +- .../propertyeditors/listview/listview.html | 12 +- .../mediapicker/mediapicker.html | 8 +- .../umb-media-picker3-property-editor.html | 8 +- .../multipletextbox/multipletextbox.html | 4 +- .../nestedcontent.propertyeditor.html | 11 +- .../relatedlinks/relatedlinks.html | 8 +- .../propertyeditors/urllist/urllist.html | 2 +- .../src/views/scripts/create.html | 4 +- .../src/views/stylesheets/create.html | 6 +- .../views/stylesheets/views/rules/rules.html | 2 +- .../src/views/templates/edit.html | 2 +- .../src/views/users/views/groups/groups.html | 4 +- .../src/views/users/views/users/users.html | 2 +- 153 files changed, 651 insertions(+), 591 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/common/directives/components/umbconfirmaction.directive.js b/src/Umbraco.Web.UI.Client/src/common/directives/components/umbconfirmaction.directive.js index 1dcccda481c6..665b8379461a 100644 --- a/src/Umbraco.Web.UI.Client/src/common/directives/components/umbconfirmaction.directive.js +++ b/src/Umbraco.Web.UI.Client/src/common/directives/components/umbconfirmaction.directive.js @@ -14,7 +14,7 @@ The prompt can be opened in four direction up, down, left or right.
Select one of the options to edit the node.
- {{a11yMessage}} -
{{a11yMessage}}
- +
{{ model.itemDetails.description }}
{{model.itemDetails.description}}
{{ model.confirmSubmit.description }}
{{model.confirmSubmit.description}}
Click to upload
{{::property.name}}
+ {{::property.name}} +
- + All Documents diff --git a/src/Umbraco.Web.UI.Client/src/views/documenttypes/property.html b/src/Umbraco.Web.UI.Client/src/views/documenttypes/property.html index ccd632246cac..659e52b7b639 100644 --- a/src/Umbraco.Web.UI.Client/src/views/documenttypes/property.html +++ b/src/Umbraco.Web.UI.Client/src/views/documenttypes/property.html @@ -1,4 +1,4 @@
- + All media items diff --git a/src/Umbraco.Web.UI.Client/src/views/member/create.html b/src/Umbraco.Web.UI.Client/src/views/member/create.html index 1762308a2cb0..b25856d9bae9 100644 --- a/src/Umbraco.Web.UI.Client/src/views/member/create.html +++ b/src/Umbraco.Web.UI.Client/src/views/member/create.html @@ -7,7 +7,7 @@
- + All members using this member type will be deleted permanently, please confirm you want to delete these as well.
This content is not allowed here
This content is allowed here
{{template.name}}
{{layout.label || layout.name}}
{{item.alias}} ({{item.width}}px × {{item.height}}px)