_⚠️ Potential issue_ | _🟡 Minor_

[Neuro-Rift]

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if there's any webhook receiver or callback handler elsewhere
rg -n "approval|approve|callback" --type py integrations/
rg -n "APPROVE|DENY" --type py

Repository: demonking369/NeuroRift

Length of output: 2150

---

🏁 Script executed:

#!/bin/bash
# Search for the configuration mentioned in the review
rg -n "defaultAction" --type py
rg -n "defaultAction" --type yaml
rg -n "defaultAction" --type toml
rg -n "defaultAction" --type json

Repository: demonking369/NeuroRift

Length of output: 48

---

🏁 Script executed:

#!/bin/bash
# Let's examine the actual file to understand the full context
wc -l integrations/openclaw/openclaw_gateway_adapter.py

Repository: demonking369/NeuroRift

Length of output: 119

---

🏁 Script executed:

#!/bin/bash
# Read the ExecutionApprovalForwarder class (lines ~150-195)
sed -n '150,200p' integrations/openclaw/openclaw_gateway_adapter.py

Repository: demonking369/NeuroRift

Length of output: 1844

---

🏁 Script executed:

#!/bin/bash
# Check if there's any message handler or callback receiver for Discord/Telegram
rg -n "message|reply|response|webhook" --type py integrations/openclaw/

Repository: demonking369/NeuroRift

Length of output: 1949

---

🏁 Script executed:

#!/bin/bash
# Look for the full class to understand the approval flow
sed -n '1,50p' integrations/openclaw/openclaw_gateway_adapter.py

Repository: demonking369/NeuroRift

Length of output: 1230

---

🏁 Script executed:

#!/bin/bash
# Look for configuration files
fd -t f -e py -e yaml -e json -e toml -e env config
fd -t f -e py -e yaml -e json -e toml settings
rg -n "default.*action|action.*default" -i --type py --type yaml --type json

Repository: demonking369/NeuroRift

Length of output: 229

---

🏁 Script executed:

#!/bin/bash
# Check git history or comments about the approval mechanism
rg -n "callback|hook" --type py integrations/openclaw/

Repository: demonking369/NeuroRift

Length of output: 739

---

🏁 Script executed:

#!/bin/bash
# Check the main config files
cat configs/neurorift_config.json
cat configs/scan_config.json

Repository: demonking369/NeuroRift

Length of output: 5762

---

🏁 Script executed:

#!/bin/bash
# Check the config manager
rg -n "defaultAction|approval|deny" --type py modules/config/ utils/config_manager.py

Repository: demonking369/NeuroRift

Length of output: 48

---

Approval workflow doesn't process responses—notifications are sent but immediately denied.

The evaluate method in ExecutionApprovalForwarder sends notifications to Discord/Telegram telling users to "Reply with APPROVE or DENY," but immediately returns approved=False without processing responses. The code comment acknowledges this: "Human callback hook should flip result in external controller"—indicating the callback mechanism is not implemented.

The behavior aligns with the configured default_on_timeout: "deny" setting (with a 300-second timeout), but this timeout mechanism isn't actually invoked. The approval result is returned immediately via await asyncio.sleep(0), bypassing any potential approval response.

Verify whether this incomplete approval flow is intentional for the initial release or if a callback receiver needs to be implemented.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@integrations/openclaw/openclaw_gateway_adapter.py` around lines 183 - 195,
The evaluate method in ExecutionApprovalForwarder currently emits notifications
but immediately returns an ApprovalResult(approved=False); instead register the
pending approval and await an external callback or timeout instead of returning
right away. Concretely: in ExecutionApprovalForwarder.evaluate, create/insert a
pending entry (keyed by session_id or correlation_id) into a shared
pending-approvals store with an asyncio.Event or Future, emit the notification
via self.logger.emit as you do now, then await that Event/Future with a timeout
driven by default_on_timeout; when the webhook/callback handler (e.g., an
ApprovalCallbackHandler or similar) receives a user response it should set the
result into the pending store and set the Event/Future so evaluate can return an
ApprovalResult(approved=True/False, reason=...) accordingly, and on timeout
return the denial ApprovalResult and emit the final "approval.result" event.

Originally posted by @coderabbitai in #27 (comment)