Hotfix/cms template div wrapper#467
Open
readeral wants to merge 1 commit intoNetoECommerce:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok so this is my second crack, after #456 didn't meet requirements.
What I propose is a second include on every cms template of 'wrapper' which includes the single line
<div class="col-12 col-md-9">.This solves the DRY problem requiring an update of the wrapping div on multiple pages, but also decouples the templates from a dependency on 'sidebar' for their wrapping div.
It doesn't feel all that elegant however - a better solution as noted in #456 would be to have a layout template that itself imports the cms templates within a wrapping div.
This may cause breaking changes for anyone who has created an additional template (templates\cms\example.template.html) which imports the current sidebar.template.html