refactor(ns8-join): query list-modules action each time bind is triggered

Author: stephdl

root/usr/sbin/ns8-join

@@ -287,15 +287,6 @@ else:
     account_provider_domain = ""
     account_provider_external = ""
 
-# call list-modules to update the list of modules ans save it as a file
-list_modules_response = call(api_endpoint, "list-modules", payload['token'], None, False)
-if list_modules_response['data']['exit_code'] != 0:
-    print("Task list-modules has failed:", list_modules_response, file=sys.stderr)
-    subprocess.run(['/usr/sbin/ns8-leave']) # leave the cluster, we failed to connect to the external domain
-    sys.exit(1)
-with open('/var/lib/nethserver/nethserver-ns8-migration/list-modules.json', 'w') as fp:
-    json.dump(list_modules_response['data']['output'], fp)
-
 with open('/var/lib/nethserver/nethserver-ns8-migration/environment', 'a') as fp:
     fp.write(f"USER_DOMAIN={account_provider_domain}\n")
     fp.write(f"ACCOUNT_PROVIDER_EXTERNAL={account_provider_external}\n")

root/usr/share/nethesis/nethserver-ns8-migration/apps/nethserver-nethvoice14/bind

@@ -22,17 +22,9 @@
 
 set -e
 
-# read list-modules.json
-JSON_FILE="/var/lib/nethserver/nethserver-ns8-migration/list-modules.json"
-
-# Check if nethvoice-proxy > 0 on the node
-is_installed=$(jq -r --argjson node_id "$MODULE_NODE_ID" '
-  .[] | select(.id == "nethvoice-proxy") | .install_destinations[] | select(.node_id == $node_id) | .instances > 0
-' "$JSON_FILE")
-
-# if not installed in the node, install first nethvoice-proxy
-if [[ "$is_installed" == "false" ]]; then
-     ns8-action --attach cluster add-module "$(printf '{"image": "nethvoice-proxy", "node": %d}' "${MODULE_NODE_ID}")"
+if ns8-action --attach cluster list-modules | jq -e --arg node_id "$MODULE_NODE_ID" '.[] | select(.id == "nethvoice-proxy") | .install_destinations[] | select(.node_id == ($node_id | tonumber) and .eligible == true)' > /dev/null; then
+    echo "Collabora has at least one eligible destination"
+    ns8-action --attach cluster add-module "$(printf '{"image": "nethvoice-proxy", "node": %d}' "${MODULE_NODE_ID}")"
 fi
 
 ns8-bind-app nethserver-nethvoice14