Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser page refresh leads to Start migration button again #7239

Closed
DavidePrincipi opened this issue Jan 7, 2025 · 10 comments
Closed

Browser page refresh leads to Start migration button again #7239

DavidePrincipi opened this issue Jan 7, 2025 · 10 comments
Assignees
Labels
verified All test cases were verified successfully

Comments

@DavidePrincipi
Copy link
Member

Hitting the browser page refresh on the NS7 migration tool page leads to an inconsistent UI state where a background app installation job continues to run unexpectedly.

Steps to reproduce

  • Connect to a NS8 cluster.
  • Push the Start migration of some app. It should require some time to install.
  • Immediately press browser F5, to reload the page.

Expected behavior

The application list should display a spinner, indicating that a background job is running, preventing the user from starting further actions. For example

Image

Actual behavior

The Start migration button is available again and it is possible to begin the migration of the same app multiple times. This might lead to migration errors due to background jobs concurrency.

Components

  • nethserver-migration-tool 1.1.0

See also

Discussion https://mattermost.nethesis.it/nethesis/pl/qoy4xqcx47bxjkrcamgkrjpx3c

@nethbot
Copy link
Member

nethbot commented Jan 8, 2025

in 7.9.2009/testing:

  • nethserver-ns8-migration-1.1.0-1.8.g6b8e1bc.ns7.x86_64.rpm x86_64

@DavidePrincipi
Copy link
Member Author

Test case

Start the migration of some application (e.g. Nethvoice which is quite heavy to download -- refer to QA of #7221) and immediately reload the page. Check this bug is not reproducible.

@DavidePrincipi DavidePrincipi removed their assignment Jan 8, 2025
@DavidePrincipi DavidePrincipi added the testing Packages are available from testing repositories label Jan 8, 2025
@nethbot nethbot moved this from In Progress to Testing in NethServer Jan 8, 2025
@nethbot
Copy link
Member

nethbot commented Jan 8, 2025

in 7.9.2009/testing:

  • nethserver-ns8-migration-1.1.0-1.16.g2e34a2b.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Jan 9, 2025

in 7.9.2009/testing:

  • nethserver-ns8-migration-1.1.0-1.26.gabccde7.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Jan 9, 2025

in 7.9.2009/testing:

  • nethserver-ns8-migration-1.1.0-1.28.g92ade93.ns7.x86_64.rpm x86_64

@nrauso nrauso self-assigned this Jan 10, 2025
@nrauso
Copy link

nrauso commented Jan 14, 2025

test case: VERIFIED

@nrauso nrauso added the verified All test cases were verified successfully label Jan 14, 2025
@github-actions github-actions bot removed the testing Packages are available from testing repositories label Jan 14, 2025
@nethbot nethbot moved this from Testing to Verified in NethServer Jan 14, 2025
@nethbot
Copy link
Member

nethbot commented Jan 17, 2025

in 7.9.2009/testing:

  • nethserver-ns8-migration-1.1.0-1.35.g97bb9ed.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Jan 20, 2025

in 7.9.2009/testing:

  • nethserver-ns8-migration-1.1.0-1.36.g21b37b5.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Jan 22, 2025

in 7.9.2009/updates:

  • nethserver-ns8-migration-1.2.0-1.ns7.x86_64.rpm x86_64

@DavidePrincipi
Copy link
Member Author

Released as 1.2.0

@github-project-automation github-project-automation bot moved this from Verified to Done in NethServer Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified All test cases were verified successfully
Projects
Status: Done
Development

No branches or pull requests

3 participants