From c00f1d8fff57f5d38da6354adb00baddf313e9e3 Mon Sep 17 00:00:00 2001 From: Test User Date: Fri, 10 Apr 2026 11:12:16 +0800 Subject: [PATCH] Fix typo, replace exec(), and improve bare except clauses - Fix typo: temproal_multidiffusion_stride -> temporal_multidiffusion_stride in config/quadmask_cogvideox.py (consistent with default_cogvideox.py) - Replace unsafe exec(open(...).read()) with direct subprocess call in convert_all_scenarios_for_characters.py - Replace bare except: with specific exception types: - ImportError for module imports (train.py, train_warped_noise.py, api_multi_nodes.py) - Exception for Blender/PyBullet cleanup (kubric_variable_objects.py) - (AttributeError, TypeError) for Blender node attribute copying (render_paired_videos_blender_quadmask.py) - Fix extra whitespace in ray = None assignment (api_multi_nodes.py) Co-Authored-By: Claude Opus 4.6 --- config/quadmask_cogvideox.py | 2 +- data_generation/convert_all_scenarios_for_characters.py | 6 +----- data_generation/kubric_variable_objects.py | 4 ++-- data_generation/render_paired_videos_blender_quadmask.py | 2 +- scripts/cogvideox_fun/train.py | 2 +- scripts/cogvideox_fun/train_warped_noise.py | 2 +- videox_fun/api/api_multi_nodes.py | 4 ++-- 7 files changed, 9 insertions(+), 13 deletions(-) diff --git a/config/quadmask_cogvideox.py b/config/quadmask_cogvideox.py index b0aaf0c..223f043 100644 --- a/config/quadmask_cogvideox.py +++ b/config/quadmask_cogvideox.py @@ -49,7 +49,7 @@ def get_video_model_config(): config.num_inference_steps = 50 config.lora_weight = 0.55 config.temporal_window_size = 85 - config.temproal_multidiffusion_stride = 16 + config.temporal_multidiffusion_stride = 16 config.use_vae_mask = True config.stack_mask = False return config diff --git a/data_generation/convert_all_scenarios_for_characters.py b/data_generation/convert_all_scenarios_for_characters.py index 03dd8ab..66381a9 100644 --- a/data_generation/convert_all_scenarios_for_characters.py +++ b/data_generation/convert_all_scenarios_for_characters.py @@ -59,11 +59,7 @@ def run_blender_script(script_path, args): # Check if blender command exists, if not use python directly with bpy if subprocess.run(["which", "blender"], capture_output=True).returncode != 0: # Use python with bpy import instead - cmd = ["python", "-c", f""" -import sys -sys.argv = {['script'] + args} -exec(open('{script_path}').read()) -"""] + cmd = ["python", script_path] + args result = subprocess.run(cmd, capture_output=True, text=True) return result.returncode == 0, result.stdout, result.stderr diff --git a/data_generation/kubric_variable_objects.py b/data_generation/kubric_variable_objects.py index 8bfd3b1..a35e54f 100644 --- a/data_generation/kubric_variable_objects.py +++ b/data_generation/kubric_variable_objects.py @@ -47,12 +47,12 @@ def cleanup_scene(): """Clean up Blender and PyBullet to prevent memory leaks""" try: pb.disconnect() - except: + except Exception: pass gc.collect() try: bpy.ops.wm.read_factory_settings(use_empty=True) - except: + except Exception: pass def apply_camera_motion(camera, motion_type, cam_distance, cam_angle, cam_height, diff --git a/data_generation/render_paired_videos_blender_quadmask.py b/data_generation/render_paired_videos_blender_quadmask.py index 45894e7..ad03c2a 100644 --- a/data_generation/render_paired_videos_blender_quadmask.py +++ b/data_generation/render_paired_videos_blender_quadmask.py @@ -2082,7 +2082,7 @@ def process_sequence(sequence_path, output_dir, args): if not attr.startswith('_') and attr not in ['location', 'width', 'height']: try: setattr(new_node, attr, getattr(node, attr)) - except: + except (AttributeError, TypeError): pass scene.view_settings.view_transform = orig_view_transform diff --git a/scripts/cogvideox_fun/train.py b/scripts/cogvideox_fun/train.py index 54eb774..8743750 100644 --- a/scripts/cogvideox_fun/train.py +++ b/scripts/cogvideox_fun/train.py @@ -1016,7 +1016,7 @@ def load_model_hook(models, input_dir): elif args.use_came: try: from came_pytorch import CAME - except: + except ImportError: raise ImportError( "Please install came_pytorch to use CAME. You can do so by running `pip install came_pytorch`" ) diff --git a/scripts/cogvideox_fun/train_warped_noise.py b/scripts/cogvideox_fun/train_warped_noise.py index 2de13a4..dbc0fcd 100644 --- a/scripts/cogvideox_fun/train_warped_noise.py +++ b/scripts/cogvideox_fun/train_warped_noise.py @@ -1034,7 +1034,7 @@ def load_model_hook(models, input_dir): elif args.use_came: try: from came_pytorch import CAME - except: + except ImportError: raise ImportError( "Please install came_pytorch to use CAME. You can do so by running `pip install came_pytorch`" ) diff --git a/videox_fun/api/api_multi_nodes.py b/videox_fun/api/api_multi_nodes.py index 66e8d59..74b0291 100644 --- a/videox_fun/api/api_multi_nodes.py +++ b/videox_fun/api/api_multi_nodes.py @@ -14,9 +14,9 @@ try: import ray -except: +except ImportError: print("Ray is not installed. If you want to use multi gpus api. Please install it by running 'pip install ray'.") - ray = None + ray = None if ray is not None: @ray.remote(num_gpus=1)