Skip to content

Commit e806756

Browse files
committed
fix
1 parent cb77b0b commit e806756

File tree

4 files changed

+3
-8
lines changed

4 files changed

+3
-8
lines changed

metaflow/plugins/argo/argo_workflows.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3483,8 +3483,8 @@ def ephemeral_volume_claims(self, claims=None):
34833483
"ephemeral": {
34843484
"volumeClaimTemplate": {
34853485
"spec": {
3486-
**values.get("spec", {}),
34873486
**VOLUME_CLAIM_TEMPLATE_DEFAULTS,
3487+
**values.get("spec", {}),
34883488
},
34893489
}
34903490
},

metaflow/plugins/kubernetes/kubernetes.py

-5
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,6 @@
6767
"{METAFLOW_PARALLEL_STEP_CLI_OPTIONS_TEMPLATE}"
6868
)
6969

70-
VOLUME_CLAIM_TEMPLATE_DEFAULTS = {
71-
"accessModes": ["ReadWriteOnce"],
72-
"resources": {"requests": {"storage": "1Gi"}},
73-
}
74-
7570

7671
class KubernetesException(MetaflowException):
7772
headline = "Kubernetes error"

metaflow/plugins/kubernetes/kubernetes_job.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -281,8 +281,8 @@ def create_job_spec(self):
281281
ephemeral=client.V1EphemeralVolumeSource(
282282
volume_claim_template=client.V1PersistentVolumeClaimTemplate(
283283
spec={
284-
**vals.get("spec", {}),
285284
**VOLUME_CLAIM_TEMPLATE_DEFAULTS,
285+
**vals.get("spec", {}),
286286
},
287287
)
288288
),

metaflow/plugins/kubernetes/kubernetes_jobsets.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -779,8 +779,8 @@ def dump(self):
779779
ephemeral=client.V1EphemeralVolumeSource(
780780
volume_claim_template=client.V1PersistentVolumeClaimTemplate(
781781
spec={
782-
**vals.get("spec", {}),
783782
**VOLUME_CLAIM_TEMPLATE_DEFAULTS,
783+
**vals.get("spec", {}),
784784
},
785785
)
786786
),

0 commit comments

Comments
 (0)