From e16dcc0c5adcf4402d48d374285780332dd495d0 Mon Sep 17 00:00:00 2001 From: Jose Fernandez Date: Sun, 28 Jul 2024 15:07:19 -0600 Subject: [PATCH] Use clonde_from() instead of clone() in app.rs This change is to fix the clippy warning: warning: assigning the result of `Clone::clone()` may be inefficient --> src/app.rs:279:9 | 279 | *self.graphs_bpf_program.lock().unwrap() = self.selected_program().clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.graphs_bpf_program.lock().unwrap().clone_from(&self.selected_program())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default Signed-off-by: Jose Fernandez --- src/app.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/app.rs b/src/app.rs index 54f619a..0d8ddbc 100755 --- a/src/app.rs +++ b/src/app.rs @@ -276,8 +276,7 @@ impl App { self.max_eps = 0; self.max_runtime = 0; self.mode = Mode::Graph; - *self.graphs_bpf_program.lock().unwrap() = self.selected_program().clone(); - + self.graphs_bpf_program.lock().unwrap().clone_from(&self.selected_program()); } pub fn show_table(&mut self) {