Skip to content

fix: Improve hardcode images test #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gravelord wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Improve hardcode images test #120

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f44408
fix: Improve hardcode images test
Gravelord Sep 23, 2025
5ec9195
fix: Improve hardcode images test
Gravelord Oct 21, 2025
54a6808
fix: Improve hardcode images test
Gravelord Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 35 additions & 18 deletions tests/robot/image_tests/image_tests.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,45 @@
*** Settings ***
Library String
Library Collections
Resource ../Lib/lib.robot
Library String
Library Collections
Resource ../Lib/lib.robot

*** Variables ***
${PG_NAMESPACE} %{OPENSHIFT_WORKSPACE_WA}

*** Keywords ***
Get Image Tag
[Arguments] ${image}
${parts}= Split String ${image} :
${length}= Get Length ${parts}
Run Keyword If ${length} > 1 Return From Keyword ${parts[2]}
Run Keywords
... Log To Console \n[ERROR] Image ${parts} has no tag: ${image}\nMonitored images list: ${dd_images}
... AND Fail Some images were not found, please check your .helpers template and description.yaml in the repository

Compare Images From Resources With Dd
[Arguments] ${dd_images}
${stripped_resources}= Strip String ${dd_images} characters=, mode=right
@{list_resources} = Split String ${stripped_resources} ,
FOR ${resource} IN @{list_resources}
${type} ${name} ${container_name} ${image}= Split String ${resource}
${resource_image}= Get Image From Resource ${type} ${name} ${container_name}
Should Be Equal ${resource_image} ${image}
[Arguments] ${dd_images}
${stripped_resources}= Strip String ${dd_images} characters=, mode=right
@{list_resources}= Split String ${stripped_resources} ,
FOR ${resource} IN @{list_resources}
${type} ${name} ${container_name} ${image}= Split String ${resource}
${resource_image}= Get Image From Resource ${type} ${name} ${container_name}

${expected_tag}= Get Image Tag ${image}
${actual_tag}= Get Image Tag ${resource_image}

Log To Console \n[COMPARE] ${resource}: Expected tag = ${expected_tag}, Actual tag = ${actual_tag}
Run Keyword And Continue On Failure Should Be Equal ${actual_tag} ${expected_tag}
END

*** Test Cases ***
Test Hardcoded Images For Core Services
[Tags] patroni basic check_pg_images
${dd_images}= Get Dd Images From Config Map patroni-tests-config
Skip If '${dd_images}' == '${None}' There is no dd, not possible to check case!
Compare Images From Resources With Dd ${dd_images}
[Tags] patroni basic check_pg_images
${dd_images}= Get Dd Images From Config Map patroni-tests-config
Skip If '${dd_images}' == '${None}' There is no dd, not possible to check case!
Compare Images From Resources With Dd ${dd_images}

Test Hardcoded Images For Supplementary Services
[Tags] backup basic check_pg_images
${dd_images}= Get Dd Images From Config Map supplementary-tests-config
Skip If '${dd_images}' == '${None}' There is no dd, not possible to check case!
Compare Images From Resources With Dd ${dd_images}
[Tags] backup basic check_pg_images
${dd_images}= Get Dd Images From Config Map supplementary-tests-config
Skip If '${dd_images}' == '${None}' There is no dd, not possible to check case!
Compare Images From Resources With Dd ${dd_images}