fix: golangci lint editorconfig lints (#100)

* fix: editorconfig-checker lint

* fix: golangci-lint check

* fix: refactor corev1.Endpoints depricated

* fix: new golangci-lint need ver 2

* fix: upd super-linter

* fix: super-linter ver v8

* fix: upd and fix super-linter

* fix: disable trivy check

* fix: super-linter

* fix: bash_exec sqlfluff

* fix: tabs instead of spaces

* fix: sqlfluff and bash lint

* fix: lint editorconfig shfmt

* Mnual resolution

* fix: linter

* fix: lint

* fix: lint

* fix: lint

---------

Co-authored-by: Tvion <snakersu@gmail.com>

Author: mchekalov

.editorconfig

@@ -33,3 +33,10 @@ profile = black
 
 [*.sh]
 indent_size = 4
+indent_style = tab
+
+[Makefile]
+indent_style = tab
+
+[*entrypoint*]
+indent_style = tab

.github/linters/.golangci.yml

@@ -1,2 +1,3 @@
+version: "2"
 run:
   timeout: 10m

.github/super-linter.env

@@ -8,6 +8,7 @@ VALIDATE_JAVASCRIPT_STANDARD=false
 VALIDATE_JSCPD=false
 VALIDATE_JSON_PRETTIER=false
 VALIDATE_KUBERNETES_KUBECONFORM=false
+VALIDATE_MARKDOWN=false
 VALIDATE_MARKDOWN_PRETTIER=false
 VALIDATE_YAML=false
 VALIDATE_YAML_PRETTIER=false
@@ -19,4 +20,7 @@ VALIDATE_PYTHON_MYPY=false
 VALIDATE_PYTHON_PYINK=false
 VALIDATE_PYTHON_PYLINT=false
 
+VALIDATE_DOCKERFILE_TRIVY=false
+VALIDATE_TRIVY=false
+
 VALIDATE_GO=false

.github/workflows/build.yaml

@@ -23,6 +23,10 @@ env:
 
 jobs:
   multiplatform_build:
+    permissions:
+      contents: read
+      packages: write
+      actions: read
     strategy:
       fail-fast: false
       matrix:
@@ -39,35 +43,40 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
       - name: Validate
+        env:
+          EVENT_NAME: ${{ github.event_name }}
+          GITHUB_REF: ${{ github.ref }}
         run: |
-          if [[ "${{ github.event_name }}" == "workflow_dispatch" && "${{ github.ref }}" == refs/tags* ]]; then
+          if [[ "$EVENT_NAME" == "workflow_dispatch" && "$GITHUB_REF" == refs/tags/* ]]; then
             echo -e "\033[91mManual workflow run on tags is not allowed!\033[0m"
             exit 1
           fi
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        with:
+          persist-credentials: false
       - name: Set up QEMU
-        uses: docker/setup-qemu-action@v3
+        uses: docker/setup-qemu-action@49b3bc8e6bdd4a60e6116a5414239cba5943d3cf # v3.2.0
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@988b5a0280414f521da01fcc63a27aeeb4b104db # v3.6.1
       - name: Login to Docker Hub
-        uses: docker/login-action@v3
+        uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0
         with:
           registry: ghcr.io
           username: ${GITHUB_ACTOR}
           password: ${{secrets.GITHUB_TOKEN}}
       - name: Prepare Tag
         run: echo "TAG_NAME=$(echo ${TAG_NAME} | sed 's@refs/tags/@@;s@refs/heads/@@;s@/@_@g')" >> $GITHUB_ENV
-      - name: Get package IDs for delete 
+      - name: Get package IDs for delete
         id: get-ids-for-delete
-        uses: Netcracker/get-package-ids@v0.0.1
+        uses: Netcracker/get-package-ids@84bc8eb8bed50218be76e671b3a24c35a1300979
         with:
           component-name: ${{ matrix.component.name }}
           component-tag: ${{ env.TAG_NAME }}
-          access-token: ${{secrets.GITHUB_TOKEN}} 
+          access-token: ${{secrets.GITHUB_TOKEN}}
         if: ${{ env.PUSH }}
       - name: Build and push
-        uses: docker/build-push-action@v6
+        uses: docker/build-push-action@16ebe778df0e7752d2cfcbd924afdbbd89c1a755 # v6.6.1
         with:
           no-cache: true
           context: ${{ matrix.component.context }}
@@ -76,8 +85,8 @@ jobs:
           push: ${{ env.PUSH }}
           tags: ghcr.io/netcracker/${{ matrix.component.name }}:${{ env.TAG_NAME }}
           provenance: false
-      - uses: actions/delete-package-versions@v5
-        with: 
+      - uses: actions/delete-package-versions@e5bc658cc4c965c472efe991f8beea3981499c55 # v5.0.0
+        with:
           package-name: ${{ matrix.component.name }}
           package-type: 'container'
           package-version-ids: ${{ steps.get-ids-for-delete.outputs.ids-for-delete }}

.github/workflows/clean.yaml

@@ -8,6 +8,8 @@ env:
 jobs:
   delete:
     if: github.event.ref_type == 'branch'
+    permissions:
+      packages: write
     runs-on: ubuntu-24.04
     strategy:
       fail-fast: false
@@ -23,20 +25,20 @@ jobs:
       - name: Prepare Tag
         run: echo "TAG_NAME=$(echo ${TAG_NAME} | sed 's@refs/heads/@@;s@/@_@g')" >> $GITHUB_ENV
       - name: Login to Docker Hub
-        uses: docker/login-action@v3
+        uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0
         with:
           registry: ghcr.io
           username: ${GITHUB_ACTOR}
           password: ${{secrets.GITHUB_TOKEN}}
-      - name: Get package IDs for delete 
+      - name: Get package IDs for delete
         id: get-ids-for-delete
-        uses: Netcracker/get-package-ids@v0.0.1
+        uses: Netcracker/get-package-ids@84bc8eb8bed50218be76e671b3a24c35a1300979
         with:
           component-name: ${{ matrix.component.name }}
           component-tag: ${{ env.TAG_NAME }}
           access-token: ${{secrets.GITHUB_TOKEN}}
-      - uses: actions/delete-package-versions@v5
-        with: 
+      - uses: actions/delete-package-versions@e5bc658cc4c965c472aba07bbc604b8e78b0e8e5 # v5.0.0
+        with:
           package-name: ${{ matrix.component.name }}
           package-type: 'container'
           package-version-ids: ${{ steps.get-ids-for-delete.outputs.ids-for-delete }}

.github/workflows/license.yaml

@@ -8,15 +8,24 @@ env:
    COPYRIGHT_YEAR: '2024-2025'
 jobs:
   license:
+    permissions:
+      contents: write
+      pull-requests: write
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@v4
-      - run: docker run -v "${PWD}:/src" -i ghcr.io/google/addlicense -v -c "${{ env.COPYRIGHT_COMPANY }}" -y "${{ env.COPYRIGHT_YEAR }}" $(find . -type f -name "*.go" -o -type f -name "*.sh" -o -type f -name "*.py" | xargs echo)
+      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        with:
+          persist-credentials: false
+          token: ${{ secrets.GITHUB_TOKEN }}
+      - run: |
+          find . -type f \( -name "*.go" -o -name "*.sh" -o -name "*.py" \) -print0 | \
+          xargs -0 docker run -v "${PWD}:/src" -i ghcr.io/google/addlicense \
+          -v -c "${{ env.COPYRIGHT_COMPANY }}" -y "${{ env.COPYRIGHT_YEAR }}"
       - name: Create Pull Request
-        uses: peter-evans/create-pull-request@v7
+        uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # v7.0.5
         with:
           commit-message: Auto-update license header
           branch: license-update
           title: Add License Header
           body: Automated license header update
-          delete-branch: true
+          delete-branch: true

.github/workflows/super-linter.yaml

@@ -37,6 +37,7 @@ jobs:
         with:
           # Full git history is needed to get a proper list of changed files within `super-linter`
           fetch-depth: 0
+          persist-credentials: false
 
       - name: "Load super-linter environment file"
         run: |
@@ -47,7 +48,7 @@ jobs:
           fi
 
       - name: Lint Code Base
-        uses: super-linter/super-linter@v7
+        uses: super-linter/super-linter@ffde3b2b33b745cb612d787f669ef9442b1339a6
         env:
           VALIDATE_ALL_CODEBASE: ${{ inputs.full_scan || false }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.gitignore

@@ -3,4 +3,4 @@ build/_output
 extras/target/*
 deployments
 target/*
-charts/**/*.gz
+charts/**/*.gz

.sqlfluff

@@ -0,0 +1,3 @@
+[sqlfluff]
+# Specify the SQL dialect to use for linting
+dialect = postgres

Makefile

@@ -50,7 +50,7 @@ vet:
 
 compile:
 	CGO_ENABLED=0 go build -o ./build/_output/bin/postgres-operator \
- 				-gcflags all=-trimpath=${GOPATH} -asmflags all=-trimpath=${GOPATH} ./cmd/pgskipper-operator
+				-gcflags all=-trimpath=${GOPATH} -asmflags all=-trimpath=${GOPATH} ./cmd/pgskipper-operator
 
 docker-build:
 	$(foreach docker_tag,$(DOCKER_NAMES),docker build --file="${DOCKER_FILE}" --pull -t $(docker_tag) ./;)
@@ -67,18 +67,18 @@ clean:
 # Generate code
 generate: controller-gen
 	$(CONTROLLER_GEN) crd:crdVersions={v1} \
-					  object:headerFile="generator/boilerplate.go.txt" \
-					  paths="./api/common/v1"
+					object:headerFile="generator/boilerplate.go.txt" \
+					paths="./api/common/v1"
 
 	$(CONTROLLER_GEN) crd:crdVersions={v1} \
-					  object:headerFile="generator/boilerplate.go.txt" \
-					  paths="./api/apps/v1" \
-					  output:crd:artifacts:config=charts/patroni-services/crds/
+					object:headerFile="generator/boilerplate.go.txt" \
+					paths="./api/apps/v1" \
+					output:crd:artifacts:config=charts/patroni-services/crds/
 
 	$(CONTROLLER_GEN) crd:crdVersions={v1} \
-					  object:headerFile="generator/boilerplate.go.txt" \
-					  paths="./api/patroni/v1" \
-					  output:crd:artifacts:config=charts/patroni-core/crds/
+					object:headerFile="generator/boilerplate.go.txt" \
+					paths="./api/patroni/v1" \
+					output:crd:artifacts:config=charts/patroni-core/crds/
 # Find or download controller-gen
 # download controller-gen if necessary
 controller-gen: