Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TinyWkbWriter: set emitZ / emitM true by default, instead of false #6

Open
airbreather opened this issue Mar 28, 2020 · 1 comment
Open

TinyWkbWriter: set emitZ / emitM true by default, instead of false #6

airbreather opened this issue Mar 28, 2020 · 1 comment

Comments

@airbreather
Copy link
Member

Because the emitZ and emitM constructor arguments only control whether or not we emit those values when present in the input geometry, I feel like a user with XYZ / XYM / XYZM geometries would expect us to emit them by default, rather than having to opt-in.
@FObermaier
Copy link
Member

👍 I'm ok with that

FObermaier added a commit that referenced this issue Apr 3, 2020
@FObermaier
Clean up solution by ...
030495b 
* adding missing code documentation
* removing unused properies
* fix readme
* adding more unit tests

resolves #1, #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FObermaier @airbreather