You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
helm: tridentAutosupportImageTag not considered when .Values.tridentAutosupportImage is set #992
Describe the bug
A clear and concise description of what the bug is.
Environment
Provide accurate information about the environment to help us reproduce the issue.
Trident version: v25.02.1
Trident installation flags used: trident-operator
Container runtime: containerd v2
Kubernetes version: v1.32
Kubernetes orchestrator: Rancher v2.10.3
Kubernetes enabled feature gates: n/a
OS: Rocky Linux 9.5
To Reproduce
Apply the following yaml (I'm using fluxcd in this example, but it does not matter):
apiVersion: v1kind: Namespacemetadata:
name: tridentlabels:
toolkit.fluxcd.io/tenant: sre-teampod-security.kubernetes.io/enforce: privilegedpod-security.kubernetes.io/enforce-version: latestpod-security.kubernetes.io/warn: privilegedpod-security.kubernetes.io/warn-version: latest
---
apiVersion: source.toolkit.fluxcd.io/v1kind: HelmRepositorymetadata:
name: trident-operatornamespace: tridentspec:
interval: 15m0surl: https://netapp.github.io/trident-helm-chart
---
apiVersion: helm.toolkit.fluxcd.io/v2kind: HelmReleasemetadata:
name: tridentnamespace: tridentspec:
interval: 15m0schart:
spec:
# https://artifacthub.io/packages/helm/netapp-trident/trident-operatorchart: trident-operatorversion: 100.2502.1sourceRef:
kind: HelmRepositoryname: trident-operatorinterval: 15m0svalues:
tridentAutosupportImage: docker.io/netapp/trident-autosupport # one would use a custom docker hub proxy or therelike, but it illustrates the issue quite nicely
Note that I'm setting a custom tridentAutosupportImage, but no tridentAutosupportImageTag.
The trident-controller deployment does NOT come up though, due to the wrong latest tag used for this custom tridentAutosupportImage.
using this setup:
good (=w/o setting any custom values):
Expected behavior
container trident-autosupport in deployment/trident/controller uses tridentAutosupportImageTag:
{{ .Values.tridentAutosupportImageTag | default .Chart.AppVersion | trunc 5}} is respected
Is there anything speaking against utilizing tridentImageTag/tridentAutosupportImageTag for tridentImage/tridentAutosupportImage?
upside: no manual fiddling with helm tag values on upgrades, unless desired; I'd say that's arguably the more natural/expected way since every upgrade requires manually updating the image tags, too
downside: this might break some people's helm deployments in case they are using the image as it's currently intended
Activity
Close NetApp#992: Add tag support for .Values.tridentAutosupportImage
hwo-wd commentedon Mar 18, 2025
I've just noticed, that the same applies to
tridentImageandoperatorImage: https://github1s.com/NetApp/trident/blob/master/helm/trident-operator/templates/_helpers.tpl#L190-L191, but these do NOT suffer from image pull errors due to the fact that there is alatesttag set and published.Is there anything speaking against utilizing
tridentImageTag/tridentAutosupportImageTagfortridentImage/tridentAutosupportImage?Close NetApp#992: Add tag support for .Values.tridentAutosupportImage…