Skip to content

Commit 594558f

Browse files
authored
CSTACKEX-309: enabling resize volume Api validation notification to s… (#103)
…how up in UI ### Description When resizing a volume, backend API validation errors (e.g. invalid size value) are silently swallowed and never shown to the user. This PR... <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> File: ui/src/views/storage/ResizeVolume.vue, lines 147–151 The .catch() handler uses this.$notification.error() with a hardcoded path error.response.data.errorresponse.errortext. However, the CloudStack API only uses errorresponse as the response key for unknown commands. For known commands like resizeVolume, it uses the command's own response name (resizevolumeresponse) as the key. So error.response.data.errorresponse is always undefined, causing a silent TypeError that swallows the error entirely. $notifyError avoids this by using _.findKey() to find errortext regardless of what the key is named — which is why the same validation error shows correctly in UpdatePrimaryStorage.vue (which uses $notifyError) but not in ResizeVolume.vue. <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [X] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <img width="1470" height="760" alt="Screenshot 2026-09-16 at 12 30 24 PM" src="https://github.com/user-attachments/assets/f1d993a9-0a5d-4273-9e43-a0ac4838f355" /> <img width="1473" height="827" alt="Screenshot 2026-09-16 at 1 07 53 PM" src="https://github.com/user-attachments/assets/1c900a1d-4978-43ec-ba9d-62fce2f0aac3" /> <img width="1470" height="771" alt="Screenshot 2026-09-16 at 1 08 07 PM" src="https://github.com/user-attachments/assets/8bcf3fac-5b35-427b-ad26-6fe7588d5a72" /> <img width="1473" height="799" alt="Screenshot 2026-09-16 at 1 08 24 PM" src="https://github.com/user-attachments/assets/d0aea139-8d4d-4620-a7d7-ef294a5335c9" /> <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
1 parent 61a5282 commit 594558f

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

‎ui/src/views/storage/ResizeVolume.vue‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,7 @@ export default {
144144
})
145145
this.closeModal()
146146
}).catch(error => {
147-
this.$notification.error({
148-
message: `${this.$t('label.error')} ${error.response.status}`,
149-
description: error.response.data.errorresponse.errortext,
150-
duration: 0
151-
})
147+
this.$notifyError(error)
152148
}).finally(() => {
153149
this.loading = false
154150
})

0 commit comments

Comments
 (0)