Repository navigation
Commit 42b3d88
authored
Refactor code to choose aggregate, network interface and creating storage volume; Also, the corresponding UT changes (#89)
### Description
This PR has changes to refactor choosing an aggregate and its
corresponding network interface and also creation of storage volume.
Also, with this, volume creation would be done at the end, avoiding
volume creation cleanup if in case there's a chance of failure during
aggregate or network interface selection.
<!---
*******************************************************************************
-->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*******************************************************************************
-->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [X] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
=================================================================
LATEST:
[iSCSI]
<img width="1052" height="361" alt="Screenshot 2026-10-07 at 11 47
36 PM"
src="https://github.com/user-attachments/assets/7e24be99-c0bf-450e-8ef0-de9390a20e76"
/>
<img width="575" height="663" alt="Screenshot 2026-10-07 at 11 48 39 PM"
src="https://github.com/user-attachments/assets/7af15681-9fbd-4f85-8b6a-f683701062c1"
/>
<img width="575" height="389" alt="Screenshot 2026-10-07 at 11 48 59 PM"
src="https://github.com/user-attachments/assets/bf8ca9f6-f245-4530-a172-0fdbd45b9796"
/>
<img width="451" height="666" alt="Screenshot 2026-10-07 at 11 49 25 PM"
src="https://github.com/user-attachments/assets/ca53cddb-1626-481e-acb3-226d74e42352"
/>
<img width="1306" height="71" alt="Screenshot 2026-10-07 at 11 51 14 PM"
src="https://github.com/user-attachments/assets/11609207-fc4b-4b9b-a6f2-aee2b049730c"
/>
[NFS3]
<img width="1042" height="418" alt="Screenshot 2026-10-07 at 11 53
41 PM"
src="https://github.com/user-attachments/assets/632bc4a5-c1fa-4476-b063-66b3221f4640"
/>
<img width="1103" height="354" alt="Screenshot 2026-10-07 at 11 53
57 PM"
src="https://github.com/user-attachments/assets/ff5ba193-2dd2-4a7a-a4ac-791abfc72548"
/>
<img width="580" height="658" alt="Screenshot 2026-10-07 at 11 54 23 PM"
src="https://github.com/user-attachments/assets/2eada67e-a835-4c3a-803c-614e4f7e0a72"
/>
<img width="580" height="373" alt="Screenshot 2026-10-07 at 11 54 39 PM"
src="https://github.com/user-attachments/assets/bada67dd-4c55-4c1d-a7d1-739928c40b80"
/>
<img width="1306" height="39" alt="Screenshot 2026-10-07 at 11 53 22 PM"
src="https://github.com/user-attachments/assets/8650c275-d7e0-4bb3-94d7-4d5fe3e93eba"
/>
=================================================================
<img width="1042" height="359" alt="Screenshot 2026-08-10 at 7 23 42 AM"
src="https://github.com/user-attachments/assets/c7f08ec8-b84e-471c-af39-5e701973ecf3"
/>
<img width="1098" height="550" alt="Screenshot 2026-08-10 at 7 24 42 AM"
src="https://github.com/user-attachments/assets/be0d77de-be40-4415-b9b0-0870db557b46"
/>
<img width="1098" height="550" alt="Screenshot 2026-08-10 at 7 25 06 AM"
src="https://github.com/user-attachments/assets/347aeb2d-5127-4105-8972-ddc1a029458f"
/>
<img width="1306" height="250" alt="Screenshot 2026-08-10 at 7 27 30 AM"
src="https://github.com/user-attachments/assets/db1c04ba-ede3-4c1e-915b-a7b098040b68"
/>
[ChoosingAggregateRefactorLogs_iSCSi.rtf](https://github.com/user-attachments/files/30884333/ChoosingAggregateRefactorLogs_iSCSi.rtf)
<img width="1035" height="315" alt="Screenshot 2026-08-10 at 7 33 52 AM"
src="https://github.com/user-attachments/assets/7eb12479-b705-4d00-9443-6851e0aa66f4"
/>
<img width="1100" height="668" alt="Screenshot 2026-08-10 at 7 34 48 AM"
src="https://github.com/user-attachments/assets/db760e61-1bfa-47c8-8123-1e2db21971ca"
/>
<img width="1100" height="437" alt="Screenshot 2026-08-10 at 7 35 01 AM"
src="https://github.com/user-attachments/assets/90f259bd-fcae-4073-909f-d74e38537a4f"
/>
<img width="1306" height="255" alt="Screenshot 2026-08-10 at 7 36 07 AM"
src="https://github.com/user-attachments/assets/1d8b677f-8e9a-4597-a921-0e4c77914112"
/>
[choosingAggregateRefactorLogs_NFS3.rtf](https://github.com/user-attachments/files/30884337/choosingAggregateRefactorLogs_NFS3.rtf)
Choosing LIFs and aggregates might need further enhancement and a
backlog story has been created for it
https://netapp.atlassian.net/browse/CSTACKEX-3431 parent 698008f commit 42b3d88
4 files changed
Lines changed: 423 additions & 247 deletions
File tree
- plugins/storage/volume/ontap/src
- main/java/org/apache/cloudstack/storage
- lifecycle
- service
- test/java/org/apache/cloudstack/storage
- lifecycle
- service
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
| |||
68 | 69 | | |
69 | 70 | | |
70 | 71 | | |
71 | | - | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
150 | 170 | | |
151 | 171 | | |
152 | 172 | | |
153 | | - | |
| 173 | + | |
154 | 174 | | |
155 | 175 | | |
156 | 176 | | |
| |||
162 | 182 | | |
163 | 183 | | |
164 | 184 | | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | 185 | | |
175 | 186 | | |
176 | 187 | | |
| |||
289 | 300 | | |
290 | 301 | | |
291 | 302 | | |
292 | | - | |
| 303 | + | |
293 | 304 | | |
294 | | - | |
295 | 305 | | |
296 | 306 | | |
297 | 307 | | |
298 | 308 | | |
299 | 309 | | |
300 | 310 | | |
301 | 311 | | |
302 | | - | |
303 | | - | |
| 312 | + | |
304 | 313 | | |
305 | 314 | | |
306 | 315 | | |
| |||
0 commit comments