fix: align WebAudioContext.decodeAudioData signature with weapp doc #17081
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p docs Updated the `decodeAudioData` method in `WebAudioContext` to match the official WeChat Mini Program documentation: - Modified the return type to `Promise<AudioBuffer>` instead of `AudioBuffer`, because of this method' actual response. - Adjusted method parameters to accept `audioData`, `successCallback`, and `errorCallback`. This fixes the TypeScript error and aligns the implementation with the expected API behavior. Closes NervJS#17080
This was referenced Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…at docs
Updated the
decodeAudioDatamethod inWebAudioContextto match the official WeChat Mini Program documentation:Promise<AudioBuffer>instead ofAudioBuffer, because of this method' actual response.audioData,successCallback, anderrorCallback.This fixes the TypeScript error and aligns the implementation with the expected API behavior. Closes #17080
这个 PR 做了什么? (简要描述所做更改)
修复了 WebAudioContext.decodeAudioData 的签名
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: