Skip to content

Commit 10a2d2e

Browse files
authored
feat: ns8 (#5508)
* chore: handle staleFiles * refactor: clean up karma-execution * fix(arm64): run pod install via rosetta2 * chore: webpack5 wip * test: fix assertion to include new staleFiles * chore(release): 8.0.0-alpha.0 * chore: improved webpack5 handling * chore: cleanup * fix: ignore empty compilation * chore(release): 8.0.0-alpha.1 * chore(release): 8.0.0-alpha.2 * chore: fix hmr regex * chore(release): 8.0.0-alpha.3 * feat: migrations for ns8 * chore: remove console.logs * chore: bump ios-device-lib * feat: allow defaultValue fallback in config getValue * chore: adjust migration desiredVersions
1 parent 04eba0d commit 10a2d2e

23 files changed

+1013
-629
lines changed

lib/bootstrap.ts

+2
Original file line numberDiff line numberDiff line change
@@ -472,3 +472,5 @@ injector.require(
472472
"./services/metadata-filtering-service"
473473
);
474474
injector.require("tempService", "./services/temp-service");
475+
476+
injector.require("sharedEventBus", "./shared-event-bus");

lib/commands/migrate.ts

+3-8
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ export class MigrateCommand implements ICommand {
99
constructor(
1010
private $devicePlatformsConstants: Mobile.IDevicePlatformsConstants,
1111
private $migrateController: IMigrateController,
12+
private $staticConfig: Config.IStaticConfig,
1213
private $projectData: IProjectData,
1314
private $logger: ILogger
1415
) {
@@ -28,18 +29,12 @@ export class MigrateCommand implements ICommand {
2829
);
2930

3031
if (!shouldMigrateResult) {
32+
const cliVersion = this.$staticConfig.version;
3133
this.$logger.printMarkdown(
32-
'__Project is compatible with NativeScript "v7.0.0". To get the latest NativeScript packages execute "ns update".__'
34+
`__Project is compatible with NativeScript \`v${cliVersion}\`__`
3335
);
3436
return;
3537
}
36-
// else if (shouldMigrateResult.shouldMigrate === ShouldMigrate.ADVISED) {
37-
// // todo: this shouldn't be here, because this is already the `ns migrate` path.
38-
// this.$logger.printMarkdown(
39-
// '__Project should work with NativeScript "v7.0.0" but a migration is advised. Run ns migrate to migrate.__'
40-
// );
41-
// return;
42-
// }
4338

4439
await this.$migrateController.migrate(migrationData);
4540
}

lib/commands/update.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export class UpdateCommand implements ICommand {
6161
this.$devicePlatformsConstants.Android,
6262
this.$devicePlatformsConstants.iOS,
6363
],
64-
allowInvalidVersions: true,
64+
loose: true,
6565
});
6666

6767
if (shouldMigrate) {

lib/common/dispatchers.ts

+1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export class CommandDispatcher implements ICommandDispatcher {
3737

3838
if (this.$logger.getLevel() === "TRACE") {
3939
// CommandDispatcher is called from external CLI's only, so pass the path to their package.json
40+
this.$logger.trace("Collecting system information...");
4041
const sysInfo = await this.$sysInfo.getSysInfo({
4142
pathToNativeScriptCliPackageJson: path.join(
4243
__dirname,

0 commit comments

Comments
 (0)