fix: ensure same mtime for js and code cache to prevent loading old code caches (#1822)

Author: edusperoni

test-app/runtime/src/main/cpp/ModuleInternal.cpp

@@ -23,6 +23,8 @@
 #include <libgen.h>
 #include <dlfcn.h>
 #include <sys/stat.h>
+#include <time.h>
+#include <utime.h>
 
 using namespace v8;
 using namespace std;
@@ -478,8 +480,9 @@ ScriptCompiler::CachedData* ModuleInternal::TryLoadScriptCache(const std::string
         auto cacheLastModifiedTime = result.st_mtime;
         if (stat(path.c_str(), &result) == 0) {
             auto jsLastModifiedTime = result.st_mtime;
-            if (jsLastModifiedTime > 0 && cacheLastModifiedTime > 0 && jsLastModifiedTime > cacheLastModifiedTime) {
-                // The javascript file is more recent than the cache file => ignore the cache
+            if (jsLastModifiedTime != cacheLastModifiedTime) {
+                // files have different dates, ignore the cache file (this is enforced by the
+                // SaveScriptCache function)
                 return nullptr;
             }
         }
@@ -508,6 +511,16 @@ void ModuleInternal::SaveScriptCache(const Local<Script> script, const std::stri
     auto cachePath = path + ".cache";
     File::WriteBinary(cachePath, cachedData->data, length);
     delete cachedData;
+    // make sure cache and js file have the same modification date
+    struct stat result;
+    struct utimbuf new_times;
+    new_times.actime = time(nullptr);
+    new_times.modtime = time(nullptr);
+    if (stat(path.c_str(), &result) == 0) {
+        auto jsLastModifiedTime = result.st_mtime;
+        new_times.modtime = jsLastModifiedTime;
+    }
+    utime(cachePath.c_str(), &new_times);
 }
 
 ModuleInternal::ModulePathKind ModuleInternal::GetModulePathKind(const std::string& path) {